<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>261244</bug_id>
          
          <creation_ts>2023-09-06 17:01:27 -0700</creation_ts>
          <short_desc>[css-grid] grid should not always put first and last baseline aligned items into different alignment contexts</short_desc>
          <delta_ts>2023-09-12 15:13:33 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>260570</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Sammy Gill">sgill26</reporter>
          <assigned_to name="Sammy Gill">sgill26</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>zalan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1975988</commentid>
    <comment_count>0</comment_count>
    <who name="Sammy Gill">sgill26</who>
    <bug_when>2023-09-06 17:01:27 -0700</bug_when>
    <thetext>Currently grid computes the alignment context for first/last baseline aligned items as follows:

auto spanForBaselineAlignment = align == ItemPosition::Baseline ? span.startLine() : span.endLine()

This is not correct because items that are in the same track with different baseline alignments are technically in the same alignment context. As a result, items in the same alignment context can be in the same baseline sharing group is their baseline alignment preferences are compatible

https://drafts.csswg.org/css-align-3/#baseline-terms</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1975989</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2023-09-06 17:01:42 -0700</bug_when>
    <thetext>&lt;rdar://problem/115083708&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1975993</commentid>
    <comment_count>2</comment_count>
    <who name="Sammy Gill">sgill26</who>
    <bug_when>2023-09-06 17:17:31 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/17517</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1977152</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-09-12 15:13:30 -0700</bug_when>
    <thetext>Committed 267922@main (caab01d5e748): &lt;https://commits.webkit.org/267922@main&gt;

Reviewed commits have been landed. Closing PR #17517 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>