<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>261242</bug_id>
          
          <creation_ts>2023-09-06 16:43:09 -0700</creation_ts>
          <short_desc>[git-webkit] Add screen-reader friendly review wizard</short_desc>
          <delta_ts>2024-05-23 21:05:23 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>Safari Technology Preview</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>261246</dependson>
    
    <dependson>261277</dependson>
    
    <dependson>263652</dependson>
    
    <dependson>263653</dependson>
    
    <dependson>273781</dependson>
    
    <dependson>273784</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jonathan Bedard">jbedard</reporter>
          <assigned_to name="Jonathan Bedard">jbedard</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>andresg_22</cc>
    
    <cc>ap</cc>
    
    <cc>dewei_zhu</cc>
    
    <cc>ryanhaddad</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1975979</commentid>
    <comment_count>0</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2023-09-06 16:43:09 -0700</bug_when>
    <thetext>HTML based code review tools are not friendly for blind developers. This was true in bugzilla, although GitHub&apos;s review interface is a regression. It seems that other HTML review tools (notably, Bitbucket) have this same problem.

Andres Gonzalez and I proto-typed a text-based command-line review wizard that he was able to utilize to great effect last week. We should clean up and land the code for that wizard.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1975980</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2023-09-06 16:43:40 -0700</bug_when>
    <thetext>&lt;rdar://problem/115083100&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1975982</commentid>
    <comment_count>2</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2023-09-06 16:44:20 -0700</bug_when>
    <thetext>Proto-type uploaded in https://github.com/WebKit/WebKit/pull/17187, although that change needs to be divided up to be landed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2030542</commentid>
    <comment_count>3</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2024-04-23 07:47:49 -0700</bug_when>
    <thetext>*** Bug 273123 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2030544</commentid>
    <comment_count>4</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2024-04-23 07:55:35 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/27628</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2034529</commentid>
    <comment_count>5</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2024-05-10 07:35:33 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/28389</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2037513</commentid>
    <comment_count>6</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2024-05-23 16:52:13 -0700</bug_when>
    <thetext>Committed 279244@main (26ef083bdcb3): &lt;https://commits.webkit.org/279244@main&gt;

Reviewed commits have been landed. Closing PR #27628 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2037545</commentid>
    <comment_count>7</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2024-05-23 21:05:23 -0700</bug_when>
    <thetext>Committed 279255@main (74313d0521aa): &lt;https://commits.webkit.org/279255@main&gt;

Reviewed commits have been landed. Closing PR #28389 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>