261131 2023-09-04 19:47:04 -0700 [IFC] isLastLineWithInlineContent should should not return true for float/out-of-flow content only 2023-09-04 23:02:00 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham simon.fraser webkit-bug-importer zalan oldest_to_newest 1975449 0 zalan 2023-09-04 19:47:04 -0700 ssia 1975450 1 467548 zalan 2023-09-04 19:55:02 -0700 Created attachment 467548 Patch 1975455 2 ews-feeder 2023-09-04 21:52:21 -0700 Committed 267617@main (f8882f5669c3): <https://commits.webkit.org/267617@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 467548. 1975456 3 webkit-bug-importer 2023-09-04 21:53:14 -0700 <rdar://problem/114960875> 467548 2023-09-04 19:55:02 -0700 2023-09-04 23:02:00 -0700 Patch bug-261131-20230904195501.patch text/plain 7562 zalan RnJvbSA5NmI0ODMzMGIwY2Y2MzAxYjBjY2IwNTllNzg1ZjgyMzhhOGRhYjRhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJhcmFkbGF5IDx6YWxhbkBhcHBsZS5jb20+CkRhdGU6 IE1vbiwgNCBTZXAgMjAyMyAxOTo1MzoyMCAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIFtJRkNdIGlz TGFzdExpbmVXaXRoSW5saW5lQ29udGVudCBzaG91bGQgc2hvdWxkIG5vdCByZXR1cm4KIHRydWUg Zm9yIGZsb2F0L291dC1vZi1mbG93IGNvbnRlbnQgb25seQogaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTI2MTEzMQoKUmV2aWV3ZWQgYnkgQW50dGkgS29pdmlzdG8uCgoq IFNvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29udGV4dHMvaW5saW5lL0lubGluZUxp bmVCdWlsZGVyLmNwcDoKKFdlYkNvcmU6OkxheW91dDo6TGluZUJ1aWxkZXI6OmxheW91dElubGlu ZUNvbnRlbnQpOgooV2ViQ29yZTo6TGF5b3V0OjpMaW5lQnVpbGRlcjo6cGxhY2VJbmxpbmVBbmRG bG9hdENvbnRlbnQpOgooV2ViQ29yZTo6TGF5b3V0OjpMaW5lQnVpbGRlcjo6aXNMYXN0TGluZVdp dGhJbmxpbmVDb250ZW50IGNvbnN0KToKKFdlYkNvcmU6OkxheW91dDo6aXNMYXN0TGluZVdpdGhJ bmxpbmVDb250ZW50KTogRGVsZXRlZC4KKiBTb3VyY2UvV2ViQ29yZS9sYXlvdXQvZm9ybWF0dGlu Z0NvbnRleHRzL2lubGluZS9JbmxpbmVMaW5lQnVpbGRlci5oOgoqIFNvdXJjZS9XZWJDb3JlL2xh eW91dC9pbnRlZ3JhdGlvbi9pbmxpbmUvTGF5b3V0SW50ZWdyYXRpb25MaW5lTGF5b3V0LmNwcDoK KFdlYkNvcmU6OkxheW91dEludGVncmF0aW9uOjpMaW5lTGF5b3V0Ojpjb250ZW50Qm94TG9naWNh bEhlaWdodCBjb25zdCk6Ci0tLQogLi4uL2lubGluZS9JbmxpbmVMaW5lQnVpbGRlci5jcHAgICAg ICAgICAgICAgIHwgNDMgKysrKysrKysrKy0tLS0tLS0tLQogLi4uL2lubGluZS9JbmxpbmVMaW5l QnVpbGRlci5oICAgICAgICAgICAgICAgIHwgIDEgKwogLi4uL2lubGluZS9MYXlvdXRJbnRlZ3Jh dGlvbkxpbmVMYXlvdXQuY3BwICAgIHwgMTIgKysrKystCiAzIGZpbGVzIGNoYW5nZWQsIDM1IGlu c2VydGlvbnMoKyksIDIxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2xheW91dC9mb3JtYXR0aW5nQ29udGV4dHMvaW5saW5lL0lubGluZUxpbmVCdWlsZGVyLmNwcCBi L1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29udGV4dHMvaW5saW5lL0lubGluZUxp bmVCdWlsZGVyLmNwcAppbmRleCAwNWU5M2I3NjgzNDYuLmFkMmQyNjUxMWE2MyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9pbmxpbmUvSW5saW5l TGluZUJ1aWxkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29u dGV4dHMvaW5saW5lL0lubGluZUxpbmVCdWlsZGVyLmNwcApAQCAtOTYsMjQgKzk2LDYgQEAgc3Rh dGljIGlubGluZSBWZWN0b3I8aW50MzJfdD4gY29tcHV0ZWRWaXN1YWxPcmRlcihjb25zdCBMaW5l OjpSdW5MaXN0JiBsaW5lUnVucywKICAgICByZXR1cm4gdmlzdWFsT3JkZXJMaXN0OwogfQogCi1z dGF0aWMgYm9vbCBpc0xhc3RMaW5lV2l0aElubGluZUNvbnRlbnQoY29uc3QgSW5saW5lSXRlbVJh bmdlJiBsaW5lUmFuZ2UsIGNvbnN0IElubGluZUl0ZW1zJiBpbmxpbmVJdGVtcywgc2l6ZV90IGxh c3RJbmxpbmVJdGVtSW5kZXgsIGJvb2wgaGFzUGFydGlhbFRyYWlsaW5nQ29udGVudCkKLXsKLSAg ICBpZiAoaGFzUGFydGlhbFRyYWlsaW5nQ29udGVudCkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwot ICAgIGlmIChsaW5lUmFuZ2UuZW5kSW5kZXgoKSA9PSBsYXN0SW5saW5lSXRlbUluZGV4KSB7Ci0g ICAgICAgIC8vIFdlIG11c3QgaGF2ZSBvbmx5IGNvbW1pdHRlZCB0cmFpbGluZyAob3ZlcmNvbnN0 cmFpbmluZykgZmxvYXRzIG9uIHRoZSBsaW5lIHdoZW4gdGhlIHJhbmdlIGlzIGVtcHR5LgotICAg ICAgICByZXR1cm4gIWxpbmVSYW5nZS5pc0VtcHR5KCk7Ci0gICAgfQotICAgIC8vIE9taXQgZmxv YXRzIHRvIHNlZSBpZiB0aGlzIGlzIHRoZSBsYXN0IGxpbmUgd2l0aCBpbmxpbmUgY29udGVudC4K LSAgICBmb3IgKGF1dG8gaSA9IGxhc3RJbmxpbmVJdGVtSW5kZXg7IGktLTspIHsKLSAgICAgICAg aWYgKCFpbmxpbmVJdGVtc1tpXS5pc0Zsb2F0KCkpCi0gICAgICAgICAgICByZXR1cm4gaSA9PSBs aW5lUmFuZ2UuZW5kSW5kZXgoKSAtIDE7Ci0gICAgfQotICAgIC8vIFRoZXJlIGhhcyB0byBiZSBh dCBsZWFzdCBvbmUgbm9uLWZsb2F0IGl0ZW0uCi0gICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Ci0g ICAgcmV0dXJuIGZhbHNlOwotfQotCiBzdGF0aWMgYm9vbCBoYXNUcmFpbGluZ1NvZnRXcmFwT3Bw b3J0dW5pdHkoc2l6ZV90IHNvZnRXcmFwT3Bwb3J0dW5pdHlJbmRleCwgc2l6ZV90IGxheW91dFJh bmdlRW5kLCBjb25zdCBJbmxpbmVJdGVtcyYgaW5saW5lSXRlbXMpCiB7CiAgICAgaWYgKCFzb2Z0 V3JhcE9wcG9ydHVuaXR5SW5kZXggfHwgc29mdFdyYXBPcHBvcnR1bml0eUluZGV4ID09IGxheW91 dFJhbmdlRW5kKSB7CkBAIC0yNjIsNyArMjQ0LDcgQEAgTGluZUxheW91dFJlc3VsdCBMaW5lQnVp bGRlcjo6bGF5b3V0SW5saW5lQ29udGVudChjb25zdCBMaW5lSW5wdXQmIGxpbmVJbnB1dCwgY28K ICAgICAgICAgfTsKICAgICB9CiAKLSAgICBhdXRvIGlzTGFzdExpbmUgPSBpc0xhc3RMaW5lV2l0 aElubGluZUNvbnRlbnQobGluZUNvbnRlbnQucmFuZ2UsIG1faW5saW5lSXRlbXMsIGxpbmVJbnB1 dC5uZWVkc0xheW91dFJhbmdlLmVuZEluZGV4KCksIGxpbmVDb250ZW50LnBhcnRpYWxUcmFpbGlu Z0NvbnRlbnRMZW5ndGgpOworICAgIGF1dG8gaXNMYXN0TGluZSA9IGlzTGFzdExpbmVXaXRoSW5s aW5lQ29udGVudChsaW5lQ29udGVudCwgbGluZUlucHV0Lm5lZWRzTGF5b3V0UmFuZ2UuZW5kSW5k ZXgoKSwgIXJlc3VsdC5ydW5zLmlzRW1wdHkoKSk7CiAgICAgYXV0byBpbmxpbmVCYXNlRGlyZWN0 aW9uID0gIXJlc3VsdC5ydW5zLmlzRW1wdHkoKSA/IGlubGluZUJhc2VEaXJlY3Rpb25Gb3JMaW5l Q29udGVudChyZXN1bHQucnVucywgcm9vdFN0eWxlKCksIG1fcHJldmlvdXNMaW5lKSA6IFRleHRE aXJlY3Rpb246OkxUUjsKICAgICBhdXRvIGNvbnRlbnRMb2dpY2FsTGVmdCA9ICFyZXN1bHQucnVu cy5pc0VtcHR5KCkgPyBJbmxpbmVGb3JtYXR0aW5nR2VvbWV0cnk6Omhvcml6b250YWxBbGlnbm1l bnRPZmZzZXQocm9vdFN0eWxlKCksIHJlc3VsdC5jb250ZW50TG9naWNhbFJpZ2h0LCBtX2xpbmVM b2dpY2FsUmVjdC53aWR0aCgpLCByZXN1bHQuaGFuZ2luZ1RyYWlsaW5nQ29udGVudFdpZHRoLCBy ZXN1bHQucnVucywgaXNMYXN0TGluZSwgaW5saW5lQmFzZURpcmVjdGlvbikgOiAwLmY7CiAgICAg VmVjdG9yPGludDMyX3Q+IHZpc3VhbE9yZGVyTGlzdDsKQEAgLTQ2MCw3ICs0NDIsNyBAQCBMaW5l Q29udGVudCBMaW5lQnVpbGRlcjo6cGxhY2VJbmxpbmVBbmRGbG9hdENvbnRlbnQoY29uc3QgSW5s aW5lSXRlbVJhbmdlJiBuZWVkcwogICAgIEFTU0VSVChsaW5lQ29udGVudC5yYW5nZS5lbmRJbmRl eCgpIDw9IG5lZWRzTGF5b3V0UmFuZ2UuZW5kSW5kZXgoKSk7CiAKICAgICBhdXRvIGhhbmRsZUxp bmVFbmRpbmcgPSBbJl0gewotICAgICAgICBhdXRvIGlzTGFzdExpbmUgPSBpc0xhc3RMaW5lV2l0 aElubGluZUNvbnRlbnQobGluZUNvbnRlbnQucmFuZ2UsIG1faW5saW5lSXRlbXMsIG5lZWRzTGF5 b3V0UmFuZ2UuZW5kSW5kZXgoKSwgbGluZUNvbnRlbnQucGFydGlhbFRyYWlsaW5nQ29udGVudExl bmd0aCk7CisgICAgICAgIGF1dG8gaXNMYXN0TGluZSA9IGlzTGFzdExpbmVXaXRoSW5saW5lQ29u dGVudChsaW5lQ29udGVudCwgbmVlZHNMYXlvdXRSYW5nZS5lbmRJbmRleCgpLCAhbV9saW5lLnJ1 bnMoKS5pc0VtcHR5KCkpOwogICAgICAgICBhdXRvIGhvcml6b250YWxBdmFpbGFibGVTcGFjZSA9 IG1fbGluZUxvZ2ljYWxSZWN0LndpZHRoKCk7CiAgICAgICAgIGF1dG8mIHJvb3RTdHlsZSA9IHRo aXMtPnJvb3RTdHlsZSgpOwogCkBAIC0xMjA4LDYgKzExOTAsMjcgQEAgc2l6ZV90IExpbmVCdWls ZGVyOjpyZWJ1aWxkTGluZUZvclRyYWlsaW5nU29mdEh5cGhlbihjb25zdCBJbmxpbmVJdGVtUmFu Z2UmIGxheW8KICAgICByZXR1cm4gY29tbWl0dGVkQ291bnQ7CiB9CiAKK2Jvb2wgTGluZUJ1aWxk ZXI6OmlzTGFzdExpbmVXaXRoSW5saW5lQ29udGVudChjb25zdCBMaW5lQ29udGVudCYgbGluZUNv bnRlbnQsIHNpemVfdCBuZWVkc0xheW91dEVuZCwgYm9vbCBsaW5lSGFzSW5saW5lQ29udGVudCkg Y29uc3QKK3sKKyAgICBpZiAobGluZUNvbnRlbnQucGFydGlhbFRyYWlsaW5nQ29udGVudExlbmd0 aCkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIC8vIEZJWE1FOiBUaGlzIG5lZWRzIHdvcmsg d2l0aCBwYXJ0aWFsIGxheW91dC4KKyAgICBpZiAobGluZUNvbnRlbnQucmFuZ2UuZW5kSW5kZXgo KSA9PSBuZWVkc0xheW91dEVuZCkKKyAgICAgICAgcmV0dXJuIGxpbmVIYXNJbmxpbmVDb250ZW50 OworICAgIC8vIE9taXQgZmxvYXRzIHRvIHNlZSBpZiB0aGlzIGlzIHRoZSBsYXN0IGxpbmUgd2l0 aCBpbmxpbmUgY29udGVudC4KKyAgICBmb3IgKGF1dG8gaSA9IG5lZWRzTGF5b3V0RW5kOyBpLS07 KSB7CisgICAgICAgIGF1dG8mIGlubGluZUl0ZW0gPSBtX2lubGluZUl0ZW1zW2ldOworICAgICAg ICBhdXRvIGlzQ29udGVudGZ1bElubGluZVR5cGUgPSAhaW5saW5lSXRlbS5pc0Zsb2F0KCkgJiYg IWlubGluZUl0ZW0uaXNPcGFxdWUoKSAmJiAoIWlubGluZUl0ZW0uaXNUZXh0KCkgfHwgIWRvd25j YXN0PElubGluZVRleHRJdGVtPihpbmxpbmVJdGVtKS5pc1doaXRlc3BhY2UoKSB8fCBJbmxpbmVU ZXh0SXRlbTo6c2hvdWxkUHJlc2VydmVTcGFjZXNBbmRUYWJzKGRvd25jYXN0PElubGluZVRleHRJ dGVtPihpbmxpbmVJdGVtKSkpOworICAgICAgICBpZiAoaXNDb250ZW50ZnVsSW5saW5lVHlwZSkg eworICAgICAgICAgICAgLy8gSW5saW5lSXRlbXMgYmV5b25kIHRoaXMgbGluZSByYW5nZSB3b24n dCBwcm9kdWNlIGFueSBpbmxpbmUgY29udGVudC4KKyAgICAgICAgICAgIHJldHVybiBpID09IGxp bmVDb250ZW50LnJhbmdlLmVuZEluZGV4KCkgLSAxOworICAgICAgICB9CisgICAgfQorICAgIC8v IFRoZXJlIGhhcyB0byBiZSBhdCBsZWFzdCBvbmUgbm9uLWZsb2F0IGl0ZW0uCisgICAgQVNTRVJU X05PVF9SRUFDSEVEKCk7CisgICAgcmV0dXJuIGZhbHNlOworfQorCiBjb25zdCBFbGVtZW50Qm94 JiBMaW5lQnVpbGRlcjo6cm9vdCgpIGNvbnN0CiB7CiAgICAgcmV0dXJuIGZvcm1hdHRpbmdDb250 ZXh0KCkucm9vdCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRp bmdDb250ZXh0cy9pbmxpbmUvSW5saW5lTGluZUJ1aWxkZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2xh eW91dC9mb3JtYXR0aW5nQ29udGV4dHMvaW5saW5lL0lubGluZUxpbmVCdWlsZGVyLmgKaW5kZXgg MWYxYjI1NDFjMzFjLi4zYWFiYmZhMGZlMTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xh eW91dC9mb3JtYXR0aW5nQ29udGV4dHMvaW5saW5lL0lubGluZUxpbmVCdWlsZGVyLmgKKysrIGIv U291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9pbmxpbmUvSW5saW5lTGlu ZUJ1aWxkZXIuaApAQCAtODMsNiArODMsNyBAQCBwcml2YXRlOgogICAgICAgICBMYXlvdXRVbml0 IHN1bmtlbkJlbG93Rmlyc3RMaW5lT2Zmc2V0OwogICAgIH07CiAgICAgc3RkOjpvcHRpb25hbDxJ bml0aWFsTGV0dGVyT2Zmc2V0cz4gYWRqdXN0TGluZVJlY3RGb3JJbml0aWFsTGV0dGVySWZBcHBs aWNhYmxlKGNvbnN0IEJveCYgZmxvYXRCb3gpOworICAgIGJvb2wgaXNMYXN0TGluZVdpdGhJbmxp bmVDb250ZW50KGNvbnN0IExpbmVDb250ZW50Jiwgc2l6ZV90IG5lZWRzTGF5b3V0RW5kLCBib29s IGxpbmVIYXNJbmxpbmVDb250ZW50KSBjb25zdDsKIAogICAgIGJvb2wgaXNGbG9hdExheW91dFN1 c3BlbmRlZCgpIGNvbnN0IHsgcmV0dXJuICFtX3N1c3BlbmRlZEZsb2F0cy5pc0VtcHR5KCk7IH0K ICAgICBib29sIHNob3VsZFRyeVRvUGxhY2VGbG9hdEJveChjb25zdCBCb3gmIGZsb2F0Qm94LCBM YXlvdXRVbml0IGZsb2F0Qm94TWFyZ2luQm94V2lkdGgsIE1heU92ZXJDb25zdHJhaW5MaW5lKSBj b25zdDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlvbi9pbmxp bmUvTGF5b3V0SW50ZWdyYXRpb25MaW5lTGF5b3V0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91 dC9pbnRlZ3JhdGlvbi9pbmxpbmUvTGF5b3V0SW50ZWdyYXRpb25MaW5lTGF5b3V0LmNwcAppbmRl eCBkYzEwNDRkMzc1ZTkuLjU1MmU1NDNjZjgxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv bGF5b3V0L2ludGVncmF0aW9uL2lubGluZS9MYXlvdXRJbnRlZ3JhdGlvbkxpbmVMYXlvdXQuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlvbi9pbmxpbmUvTGF5b3V0SW50 ZWdyYXRpb25MaW5lTGF5b3V0LmNwcApAQCAtODU4LDcgKzg1OCwxNyBAQCBMYXlvdXRVbml0IExp bmVMYXlvdXQ6OmNvbnRlbnRCb3hMb2dpY2FsSGVpZ2h0KCkgY29uc3QKICAgICAgICAgcmV0dXJu IHsgfTsKICAgICB9CiAKLSAgICBhdXRvIGNvbnRlbnRIZWlnaHQgPSBsaW5lcy5sYXN0KCkubGlu ZUJveExvZ2ljYWxSZWN0KCkubWF4WSgpIC0gbGluZXMuZmlyc3QoKS5saW5lQm94TG9naWNhbFJl Y3QoKS55KCk7CisgICAgYXV0byBsYXN0TGluZVdpdGhJbmxpbmVDb250ZW50ID0gWyZdIHsKKyAg ICAgICAgLy8gT3V0LW9mLWZsb3cvZmxvYXQgY29udGVudCBvbmx5IGRvbid0IHByb2R1Y2UgbGlu ZXMgd2l0aCBpbmxpbmUgY29udGVudC4gVGhleSBzaG91bGQgbm90IGJlIHRha2VuIGludG8KKyAg ICAgICAgLy8gYWNjb3VudCB3aGVuIGNvbXB1dGluZyBjb250ZW50IGJveCBoZWlnaHQuCisgICAg ICAgIGZvciAoYXV0byYgbGluZSA6IG1ha2VSZXZlcnNlZFJhbmdlKGxpbmVzKSkgeworICAgICAg ICAgICAgQVNTRVJUKGxpbmUuYm94Q291bnQoKSk7CisgICAgICAgICAgICBpZiAobGluZS5ib3hD b3VudCgpID4gMSkKKyAgICAgICAgICAgICAgICByZXR1cm4gbGluZTsKKyAgICAgICAgfQorICAg ICAgICByZXR1cm4gbGluZXMuZmlyc3QoKTsKKyAgICB9OworICAgIGF1dG8gY29udGVudEhlaWdo dCA9IGxhc3RMaW5lV2l0aElubGluZUNvbnRlbnQoKS5saW5lQm94TG9naWNhbFJlY3QoKS5tYXhZ KCkgLSBsaW5lcy5maXJzdCgpLmxpbmVCb3hMb2dpY2FsUmVjdCgpLnkoKTsKICAgICBhdXRvIGFk ZGl0aW9uYWxIZWlnaHQgPSBtX2lubGluZUNvbnRlbnQtPmZpcnN0TGluZVBhZ2luYXRpb25PZmZz ZXQgKyBtX2lubGluZUNvbnRlbnQtPmNsZWFyR2FwQmVmb3JlRmlyc3RMaW5lICsgbV9pbmxpbmVD b250ZW50LT5jbGVhckdhcEFmdGVyTGFzdExpbmU7CiAgICAgcmV0dXJuIExheW91dFVuaXQgeyBj b250ZW50SGVpZ2h0ICsgYWRkaXRpb25hbEhlaWdodCB9OwogfQo=