261127 2023-09-04 16:56:52 -0700 Let the compiler generate more comparison operators in JSC 2023-11-16 13:13:21 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=264896 InRadar P2 Normal --- 1 cdumez cdumez bfulgham darin rniwa webkit-bug-importer oldest_to_newest 1975428 0 cdumez 2023-09-04 16:56:52 -0700 Let the compiler generate more comparison operators in JSC now that we support C++20. 1975429 1 cdumez 2023-09-04 16:58:32 -0700 Pull request: https://github.com/WebKit/WebKit/pull/17417 1975630 2 ews-feeder 2023-09-05 12:41:17 -0700 Committed 267645@main (e9e93692891c): <https://commits.webkit.org/267645@main> Reviewed commits have been landed. Closing PR #17417 and removing active labels. 1975631 3 webkit-bug-importer 2023-09-05 12:42:15 -0700 <rdar://problem/115001681> 1993149 4 cdumez 2023-11-16 09:38:15 -0800 This caused a 3MB binary size increase and I am unclear why. The compiler should in theory generate identical code to the one we had.. At first I thought it was because I newly inlined 2 of the comparison operators. However, moving them back out of line didn't reduce binary size significantly. 1993222 5 darin 2023-11-16 13:13:21 -0800 Maybe the generated ones are always implicitly generated inline?