261082 2023-09-03 05:06:42 -0700 AutoInstaller needs PEP 517 build system support (don't use `setup.py build`) 2025-05-14 10:33:04 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=261113 https://bugs.webkit.org/show_bug.cgi?id=263299 https://bugs.webkit.org/show_bug.cgi?id=289909 InRadar P2 Normal --- 1 gsnedders webkit-unassigned cklim4101 fujii jbedard mcatanzaro webkit-bug-importer oldest_to_newest 1975249 0 gsnedders 2023-09-03 05:06:42 -0700 This packages relies on PEP 517 (https://peps.python.org/pep-0517/) being properly implemented; while Jonathan implemented a hackish workaround with bug 253066 that works for some packages, it doesn't work for bs4 which declares in its pyproject.toml: [build-system] requires = ["hatchling"] build-backend = "hatchling.build" I still feel like us having to reimplement more and more of the Python packaging ecosystem is likely fragile, and we should simply leverage more existing tools (whether by calling pip from the autoinstaller, or by vendoring packages such as build). 1975252 1 mcatanzaro 2023-09-03 07:10:54 -0700 So https://github.com/WebKit/WebKit/pull/17201 uses this version of bs4 and it works for me. That's strange. 1975254 2 gsnedders 2023-09-03 07:52:41 -0700 (In reply to Michael Catanzaro from comment #1) > So https://github.com/WebKit/WebKit/pull/17201 uses this version of bs4 and > it works for me. That's strange. My first guess is somehow our hacky workaround from bug 253066 suffices with the version of setuptools we have on Python 3.8+: https://github.com/WebKit/WebKit/blob/5ea837d2ce2e325744ef5d63d11e1c41e8a2c5e8/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py#L61-L62 2051405 3 gsnedders 2024-08-08 07:52:28 -0700 BS4 does always have a wheel, so if we simply oblige it to install from the wheel it should work, I think. 2053464 4 gsnedders 2024-08-16 18:51:34 -0700 Let's make this more generic than just BS4, and just use this for the entire build support issue. 2053465 5 webkit-bug-importer 2024-08-16 18:52:38 -0700 <rdar://problem/134102588> 2103803 6 gsnedders 2025-03-17 12:00:19 -0700 If we're using build, we probably need to implement our own isolated env that installs things via the AutoInstaller: https://build.pypa.io/en/stable/api.html#build.env.DefaultIsolatedEnv