261080 2023-09-03 04:03:08 -0700 WorkQueue should inherit from ConcurrentWorkQueue 2023-09-03 04:03:28 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=260779 InRadar P2 Normal --- 1 jean-yves.avenard jean-yves.avenard webkit-bug-importer oldest_to_newest 1975244 0 jean-yves.avenard 2023-09-03 04:03:08 -0700 There are currently multiple issues that needs to be resoved: - A WorkQueue is a ConcurrentWorkQueue - A ConcurrentWorkQueue may be a serial workqueue - A WorkQueue must be a SerialFunctionDispatcher to be able to use it interchangeably with other thread-like object (like a RunLoop or a WorkerThread) - IOCache class can use either a WorkQueue or a ConcurrentWorkQueue and as such they have to be related, currently it is using the WorkQueueBase class which is a bad thing. (WorkQueueBase should be a private inheritance) It is essential that we can distinguish a serial WorkQueue from a concurrent one. One issue is that the class name ConcurrentWorkQueue seems to indicate that it is only a concurrent queue (even though it may behave just like a serial WorkQueue (and this is the default implementation on non cocoa platform). A rename to something more helpful would be useful. Maybe `WorkDispatcher` ? We handle the WorkQueue inheriting from a SerialFunctionDispatch in bug 260779. While this code change should be straightforward, there are linkage issues due to WebKit only exporting some symbols from a class and this is conflicting with the vtables used for the multiple inheritance. 1975245 1 webkit-bug-importer 2023-09-03 04:03:28 -0700 <rdar://problem/114894859>