261067 2023-09-02 11:57:10 -0700 Check for NaN when creating a DelayNode for WebAudio 2023-09-05 13:51:19 -0700 1 1 1 Unclassified WebKit Web Audio Safari 16 Unspecified Unspecified RESOLVED FIXED BrowserCompat, InRadar P2 Normal --- 1 ahmad.saleem792 webkit-unassigned cdumez karlcow webkit-bug-importer oldest_to_newest 1975198 0 ahmad.saleem792 2023-09-02 11:57:10 -0700 Hi Team, I think it would be good to merge this and also update 'Layout Test' for 'NaN' check. Blink Commit: https://chromium.googlesource.com/chromium/src.git/+/c8c4a710be6292a220177fef0c3f1c7c7853d062 WebKit Source: https://searchfox.org/wubkat/source/Source/WebCore/Modules/webaudio/DelayNode.cpp#55 & https://searchfox.org/wubkat/source/Source/WebCore/Modules/webaudio/DelayDSPKernel.cpp#75 ___ Test Output: PASS context.createDelay(NaN) threw exception TypeError: The provided value is non-finite. ___ Just wanted to raise to get opinion whether we should merge it or not. Thanks! 1975434 1 karlcow 2023-09-04 17:50:59 -0700 https://wpt.fyi/results/webaudio/the-audio-api/the-delaynode-interface?label=master&label=experimental&aligned&q=delaynode%20 1975435 2 karlcow 2023-09-04 17:54:19 -0700 https://searchfox.org/wubkat/rev/68e96f24aae90f5a0a5e0c56c932c93616766cc7/Source/WebCore/Modules/webaudio/DelayNode.cpp#50-67 Maybe it's already checked in some ways. 1975654 3 ews-feeder 2023-09-05 13:50:57 -0700 Committed 267650@main (5736f9dd89ea): <https://commits.webkit.org/267650@main> Reviewed commits have been landed. Closing PR #17379 and removing active labels. 1975655 4 webkit-bug-importer 2023-09-05 13:51:19 -0700 <rdar://problem/115008784>