261033 2023-09-01 07:40:13 -0700 makeUnique isn't always a substitute for std::make_unique 2023-09-22 17:03:55 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=261985 InRadar P2 Normal --- 1 jean-yves.avenard webkit-unassigned webkit-bug-importer oldest_to_newest 1974991 0 jean-yves.avenard 2023-09-01 07:40:13 -0700 consider the following: auto b = std::make_unique<int>(12345); b is now an unique_ptr<int>, pointing to a single int* with a valid of 12345. makeUnique<int>(12345> gives the error: ``` /Users/jyavenard/Work/webkit/OpenSource/WebKitBuild/Debug/usr/local/include/wtf/StdLibExtras.h:595:41: error: type 'int' cannot be used prior to '::' because it has no members static_assert(std::is_same<typename T::webkitFastMalloced, int>::value, "T is FastMalloced"); ^ /Users/jyavenard/Work/webkit/OpenSource/Tools/TestWebKitAPI/Tests/WebCore/MediaPromise.cpp:524:17: note: in instantiation of function template specialization 'WTF::makeUnique<int, int>' requested here auto test = makeUnique<int>(12345); ``` 1974992 1 webkit-bug-importer 2023-09-01 07:40:31 -0700 <rdar://problem/114820281>