260997 2023-08-31 15:01:38 -0700 AutoInstall.install_everything is unsafe 2023-09-01 08:38:16 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 261004 1 gsnedders gsnedders jbedard webkit-bug-importer oldest_to_newest 1974839 0 gsnedders 2023-08-31 15:01:38 -0700 INTERNALERROR> File "/Volumes/gsnedders/projects/Safari/OpenSource/Tools/Scripts/libraries/resultsdbpy/.tox/py39/lib/python3.9/site-packages/webkitcorepy/autoinstall.py", line 642, in install_everything INTERNALERROR> for packages in cls.packages.values(): INTERNALERROR> RuntimeError: dictionary changed size during iteration I believe this is caused by: AutoInstall.register(Package('twisted', Version(21, 2, 0), pypi_name='Twisted', implicit_deps=[ Package('incremental', Version(21, 3, 0)), ])) …where the AutoInstaller will AutoInstall twisted, and then recurse into its implicit_deps, and it will then register incremental as it begins to install it—thus mutating the dict being iterated over. 1974886 1 gsnedders 2023-08-31 18:01:58 -0700 Pull request: https://github.com/WebKit/WebKit/pull/17317 1974998 2 ews-feeder 2023-09-01 08:37:56 -0700 Committed 267552@main (d94691e07a31): <https://commits.webkit.org/267552@main> Reviewed commits have been landed. Closing PR #17317 and removing active labels. 1974999 3 webkit-bug-importer 2023-09-01 08:38:16 -0700 <rdar://problem/114822346>