26095 2009-05-29 20:15:03 -0700 Crash with 3d transform on generated content div (with ACCELERATED_COMPOSITING) 2009-06-12 17:11:49 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser oldest_to_newest 123672 0 simon.fraser 2009-05-29 20:15:03 -0700 When ACCELERATED_COMPOSITING is on, putting a 3d transform on a generated content div crashes in a debug build. 125575 1 31222 simon.fraser 2009-06-12 17:07:41 -0700 Created attachment 31222 Patch, testcase, changelog No pixel results for the test because DRT is broken with compositing currently. 125576 2 31222 mitz 2009-06-12 17:09:48 -0700 Comment on attachment 31222 Patch, testcase, changelog > + } else { > + m_graphicsLayer->setName("Anonymous Node"); > } Please remove the braces around this 1-line block. r=me 125577 3 simon.fraser 2009-06-12 17:11:49 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog A LayoutTests/compositing/generated-content.html A LayoutTests/platform/mac/compositing/generated-content-expected.txt M WebCore/ChangeLog M WebCore/rendering/RenderLayerBacking.cpp Committed r44640 31222 2009-06-12 17:07:41 -0700 2009-06-12 17:09:48 -0700 Patch, testcase, changelog 26095_patch.txt text/plain 7027 simon.fraser ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA4YTQxY2ZmLi40NjBlMGI2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDYt MTIgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTI2MDk1CisgICAgICAgIAorICAgICAgICBUZXN0Y2FzZSBmb3Ig Y3JlYXRpbmcgYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgbGF5ZXJzIGZvciBhbm9ueW1vdXMgY29u dGVudC4KKyAgICAgICAgCisgICAgICAgICogY29tcG9zaXRpbmcvZ2VuZXJhdGVkLWNvbnRlbnQu aHRtbDogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vbWFjL2NvbXBvc2l0aW5nL2dlbmVyYXRl ZC1jb250ZW50LWV4cGVjdGVkLnR4dDogQWRkZWQuCisKIDIwMDktMDYtMTIgIEd1c3Rhdm8gTm9y b25oYSBTaWx2YSAgPGduc0Bnbm9tZS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSmFuIEFs b256by4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL2dlbmVyYXRlZC1jb250 ZW50Lmh0bWwgYi9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy9nZW5lcmF0ZWQtY29udGVudC5odG1s Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmJmMzE4NTQKLS0tIC9kZXYvbnVs bAorKysgYi9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy9nZW5lcmF0ZWQtY29udGVudC5odG1sCkBA IC0wLDAgKzEsMjggQEAKKzwhRE9DVFlQRSBodG1sIFBVQkxJQyAiLS8vVzNDLy9EVEQgSFRNTCA0 LjAxIFRyYW5zaXRpb25hbC8vRU4iCisgICAiaHR0cDovL3d3dy53My5vcmcvVFIvaHRtbDQvbG9v c2UuZHRkIj4KKworPGh0bWwgbGFuZz0iZW4iPgorPGhlYWQ+CisgIDx0aXRsZT5HZW5lcmF0ZWQg Q29udGVudCBhbmQgVHJhbnNmb3JtczwvdGl0bGU+CisgIDxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyIg bWVkaWE9InNjcmVlbiI+CisgICAgLmJveCB7CisgICAgICB3aWR0aDogMjAwcHg7CisgICAgICBo ZWlnaHQ6IDIwMHB4OworICAgICAgYm9yZGVyOiAxcHggc29saWQgYmxhY2s7CisgICAgfQorICAg IAorICAgIC5ib3g6YWZ0ZXIgeworICAgICAgY29udGVudDogJ0dlbmVyYXRlZCc7CisgICAgICBk aXNwbGF5OiBibG9jazsKKyAgICAgIHdpZHRoOiAxMDAlOworICAgICAgaGVpZ2h0OiAxMDAlOwor ICAgICAgLXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0ZTNkKDAsIDAsIDApOworICAgIH0KKyAg PC9zdHlsZT4KKzwvaGVhZD4KKzxib2R5PgorICA8cD48YSBocmVmPSJodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjYwOTUiPmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yNjA5NTwvYT48L3A+CisgIDxwPlRlc3RzIHRoYXQgYSAzRCB0cmFuc2Zv cm0gb24gYSBnZW5lcmF0ZWQgbm9kZSBkb2VzIG5vdCBjcmFzaC48L3A+CisgIDxkaXYgY2xhc3M9 ImJveCI+PC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9tYWMvY29tcG9zaXRpbmcvZ2VuZXJhdGVkLWNvbnRlbnQtZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2NvbXBvc2l0aW5nL2dlbmVyYXRlZC1jb250ZW50LWV4 cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5iMGQ5YjQ4Ci0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2NvbXBvc2l0aW5nL2dl bmVyYXRlZC1jb250ZW50LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDE3IEBACitsYXllciBhdCAo MCwwKSBzaXplIDgwMHg2MDAKKyAgUmVuZGVyVmlldyBhdCAoMCwwKSBzaXplIDgwMHg2MDAKK2xh eWVyIGF0ICgwLDApIHNpemUgODAweDI5NAorICBSZW5kZXJCbG9jayB7SFRNTH0gYXQgKDAsMCkg c2l6ZSA4MDB4Mjk0CisgICAgUmVuZGVyQm9keSB7Qk9EWX0gYXQgKDgsMTYpIHNpemUgNzg0eDI3 MAorICAgICAgUmVuZGVyQmxvY2sge1B9IGF0ICgwLDApIHNpemUgNzg0eDE4CisgICAgICAgIFJl bmRlcklubGluZSB7QX0gYXQgKDAsMCkgc2l6ZSAzMDV4MTggW2NvbG9yPSMwMDAwRUVdCisgICAg ICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgwLDApIHNpemUgMzA1eDE4CisgICAgICAgICAg ICB0ZXh0IHJ1biBhdCAoMCwwKSB3aWR0aCAzMDU6ICJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjYwOTUiCisgICAgICBSZW5kZXJCbG9jayB7UH0gYXQgKDAsMzQpIHNp emUgNzg0eDE4CisgICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMCwwKSBzaXplIDM4OHgx OAorICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDApIHdpZHRoIDM4ODogIlRlc3RzIHRoYXQgYSAz RCB0cmFuc2Zvcm0gb24gYSBnZW5lcmF0ZWQgbm9kZSBkb2VzIG5vdCBjcmFzaC4iCisgICAgICBS ZW5kZXJCbG9jayB7RElWfSBhdCAoMCw2OCkgc2l6ZSAyMDJ4MjAyIFtib3JkZXI6ICgxcHggc29s aWQgIzAwMDAwMCldCitsYXllciBhdCAoOSw4NSkgc2l6ZSAyMDB4MjAwCisgIFJlbmRlckJsb2Nr IChnZW5lcmF0ZWQpIGF0ICgxLDEpIHNpemUgMjAweDIwMAorICAgIFJlbmRlclRleHQgYXQgKDAs MCkgc2l6ZSA2NXgxOAorICAgICAgdGV4dCBydW4gYXQgKDAsMCkgd2lkdGggNjU6ICJHZW5lcmF0 ZWQiCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmlu ZGV4IDJmYjQzZjUuLmRkMmVkNmQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBi L1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjMgQEAKIDIwMDktMDYtMTIgIFNpbW9uIEZy YXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTI2MDk1CisgICAgICAgIAorICAgICAgICBGaXggY3Jhc2ggd2hlbiBhIHJlbmRlcmVy IGZvciBhbiBhbm9ueW1vdXMgbm9kZSBpcyBjb21wb3NpdGVkCisgICAgICAgIGJ5IG51bGwtY2hl Y2tpbmcgcmVuZGVyZXIoKS0+bm9kZSgpLgorICAgICAgICAKKyAgICAgICAgVGVzdDogY29tcG9z aXRpbmcvZ2VuZXJhdGVkLWNvbnRlbnQuaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRl ckxheWVyQmFja2luZy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckJhY2tpbmc6 OmNyZWF0ZUdyYXBoaWNzTGF5ZXIpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJCYWNr aW5nOjpyZW5kZXJlckhhc0JhY2tncm91bmQpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5 ZXJCYWNraW5nOjpyZW5kZXJlckJhY2tncm91bmRDb2xvcik6CisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJMYXllckJhY2tpbmc6OmlzU2ltcGxlQ29udGFpbmVyQ29tcG9zaXRpbmdMYXllcik6Cisg ICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckJhY2tpbmc6OnBhaW50SW50b0xheWVyKToKKwor MjAwOS0wNi0xMiAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKwogICAg ICAgICBGaXggYnVpbGQgd2hlbiBBQ0NFTEVSQVRFRF9DT01QT1NJVElORyBpcyBkZWZpbmVkLgog CiAgICAgICAgICogbG9hZGVyL0VtcHR5Q2xpZW50cy5oOgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcCBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckxheWVyQmFja2luZy5jcHAKaW5kZXggZTE2ZWNmNy4uZDk1ODVhMiAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcAorKysgYi9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCkBAIC03NSwxMyArNzUsMTcgQEAgdm9pZCBSZW5k ZXJMYXllckJhY2tpbmc6OmNyZWF0ZUdyYXBoaWNzTGF5ZXIoKQogICAgIG1fZ3JhcGhpY3NMYXll ciA9IEdyYXBoaWNzTGF5ZXI6OmNyZWF0ZUdyYXBoaWNzTGF5ZXIodGhpcyk7CiAgICAgCiAjaWZu ZGVmIE5ERUJVRwotICAgIGlmIChyZW5kZXJlcigpLT5ub2RlKCktPmlzRG9jdW1lbnROb2RlKCkp Ci0gICAgICAgIG1fZ3JhcGhpY3NMYXllci0+c2V0TmFtZSgiRG9jdW1lbnQgTm9kZSIpOwotICAg IGVsc2UgewotICAgICAgICBpZiAocmVuZGVyZXIoKS0+bm9kZSgpLT5pc0hUTUxFbGVtZW50KCkg JiYgcmVuZGVyZXIoKS0+bm9kZSgpLT5oYXNJRCgpKQotICAgICAgICAgICAgbV9ncmFwaGljc0xh eWVyLT5zZXROYW1lKHJlbmRlcmVyKCktPnJlbmRlck5hbWUoKSArIFN0cmluZygiICIpICsgc3Rh dGljX2Nhc3Q8SFRNTEVsZW1lbnQqPihyZW5kZXJlcigpLT5ub2RlKCkpLT5pZCgpKTsKLSAgICAg ICAgZWxzZQotICAgICAgICAgICAgbV9ncmFwaGljc0xheWVyLT5zZXROYW1lKHJlbmRlcmVyKCkt PnJlbmRlck5hbWUoKSk7CisgICAgaWYgKHJlbmRlcmVyKCktPm5vZGUoKSkgeworICAgICAgICBp ZiAocmVuZGVyZXIoKS0+bm9kZSgpLT5pc0RvY3VtZW50Tm9kZSgpKQorICAgICAgICAgICAgbV9n cmFwaGljc0xheWVyLT5zZXROYW1lKCJEb2N1bWVudCBOb2RlIik7CisgICAgICAgIGVsc2Ugewor ICAgICAgICAgICAgaWYgKHJlbmRlcmVyKCktPm5vZGUoKS0+aXNIVE1MRWxlbWVudCgpICYmIHJl bmRlcmVyKCktPm5vZGUoKS0+aGFzSUQoKSkKKyAgICAgICAgICAgICAgICBtX2dyYXBoaWNzTGF5 ZXItPnNldE5hbWUocmVuZGVyZXIoKS0+cmVuZGVyTmFtZSgpICsgU3RyaW5nKCIgIikgKyBzdGF0 aWNfY2FzdDxIVE1MRWxlbWVudCo+KHJlbmRlcmVyKCktPm5vZGUoKSktPmlkKCkpOworICAgICAg ICAgICAgZWxzZQorICAgICAgICAgICAgICAgIG1fZ3JhcGhpY3NMYXllci0+c2V0TmFtZShyZW5k ZXJlcigpLT5yZW5kZXJOYW1lKCkpOworICAgICAgICB9CisgICAgfSBlbHNlIHsKKyAgICAgICAg bV9ncmFwaGljc0xheWVyLT5zZXROYW1lKCJBbm9ueW1vdXMgTm9kZSIpOwogICAgIH0KICNlbmRp ZiAgLy8gTkRFQlVHCiAKQEAgLTQxMCw3ICs0MTQsNyBAQCBzdGF0aWMgYm9vbCBoYXNCb3hEZWNv cmF0aW9uc1dpdGhCYWNrZ3JvdW5kSW1hZ2UoY29uc3QgUmVuZGVyU3R5bGUqIHN0eWxlKQogYm9v bCBSZW5kZXJMYXllckJhY2tpbmc6OnJlbmRlcmVySGFzQmFja2dyb3VuZCgpIGNvbnN0CiB7CiAg ICAgLy8gRklYTUU6IHNoYXJlIG1vcmUgY29kZSBoZXJlCi0gICAgaWYgKHJlbmRlcmVyKCktPm5v ZGUoKS0+aXNEb2N1bWVudE5vZGUoKSkgeworICAgIGlmIChyZW5kZXJlcigpLT5ub2RlKCkgJiYg cmVuZGVyZXIoKS0+bm9kZSgpLT5pc0RvY3VtZW50Tm9kZSgpKSB7CiAgICAgICAgIFJlbmRlck9i amVjdCogaHRtbE9iamVjdCA9IHJlbmRlcmVyKCktPmZpcnN0Q2hpbGQoKTsKICAgICAgICAgaWYg KCFodG1sT2JqZWN0KQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwpAQCAtNDMzLDcgKzQzNyw3 IEBAIGJvb2wgUmVuZGVyTGF5ZXJCYWNraW5nOjpyZW5kZXJlckhhc0JhY2tncm91bmQoKSBjb25z dAogY29uc3QgQ29sb3ImIFJlbmRlckxheWVyQmFja2luZzo6cmVuZGVyZXJCYWNrZ3JvdW5kQ29s b3IoKSBjb25zdAogewogICAgIC8vIEZJWE1FOiBzaGFyZSBtb3JlIGNvZGUgaGVyZQotICAgIGlm IChyZW5kZXJlcigpLT5ub2RlKCktPmlzRG9jdW1lbnROb2RlKCkpIHsKKyAgICBpZiAocmVuZGVy ZXIoKS0+bm9kZSgpICYmIHJlbmRlcmVyKCktPm5vZGUoKS0+aXNEb2N1bWVudE5vZGUoKSkgewog ICAgICAgICBSZW5kZXJPYmplY3QqIGh0bWxPYmplY3QgPSByZW5kZXJlcigpLT5maXJzdENoaWxk KCk7CiAgICAgICAgIFJlbmRlclN0eWxlKiBzdHlsZSA9IGh0bWxPYmplY3QtPnN0eWxlKCk7CiAg ICAgICAgIGlmIChzdHlsZS0+aGFzQmFja2dyb3VuZCgpKQpAQCAtNDY5LDcgKzQ3Myw3IEBAIGJv b2wgUmVuZGVyTGF5ZXJCYWNraW5nOjppc1NpbXBsZUNvbnRhaW5lckNvbXBvc2l0aW5nTGF5ZXIo KSBjb25zdAogICAgIGlmICghcmVuZGVyT2JqZWN0LT5maXJzdENoaWxkKCkpCiAgICAgICAgIHJl dHVybiB0cnVlOwogICAgIAotICAgIGlmIChyZW5kZXJPYmplY3QtPm5vZGUoKS0+aXNEb2N1bWVu dE5vZGUoKSkgeworICAgIGlmIChyZW5kZXJPYmplY3QtPm5vZGUoKSAmJiByZW5kZXJPYmplY3Qt Pm5vZGUoKS0+aXNEb2N1bWVudE5vZGUoKSkgewogICAgICAgICAvLyBMb29rIHRvIHNlZSBpZiB0 aGUgcm9vdCBvYmplY3QgaGFzIGEgbm9uLXNpbXBsZSBiYWNrZ291bmQKICAgICAgICAgUmVuZGVy T2JqZWN0KiByb290T2JqZWN0ID0gcmVuZGVyT2JqZWN0LT5kb2N1bWVudCgpLT5kb2N1bWVudEVs ZW1lbnQoKS0+cmVuZGVyZXIoKTsKICAgICAgICAgaWYgKCFyb290T2JqZWN0KQpAQCAtNzUzLDcg Kzc1Nyw3IEBAIHZvaWQgUmVuZGVyTGF5ZXJCYWNraW5nOjpwYWludEludG9MYXllcihSZW5kZXJM YXllciogcm9vdExheWVyLCBHcmFwaGljc0NvbnRleHQqCiAgICAgICAgIEludFJlY3QgcGFpbnRC b3ggPSBjbGlwUmVjdFRvQXBwbHk7CiAgICAgICAgIAogICAgICAgICAvLyBGSVhNRTogZG8gd2Ug bmVlZCB0aGlzIGNvZGU/Ci0gICAgICAgIGlmIChyZW5kZXJlcigpLT5ub2RlKCktPmlzRG9jdW1l bnROb2RlKCkgJiYgcmVuZGVyZXIoKS0+ZG9jdW1lbnQoKS0+aXNIVE1MRG9jdW1lbnQoKSkgewor ICAgICAgICBpZiAocmVuZGVyZXIoKS0+bm9kZSgpICYmIHJlbmRlcmVyKCktPm5vZGUoKS0+aXNE b2N1bWVudE5vZGUoKSAmJiByZW5kZXJlcigpLT5kb2N1bWVudCgpLT5pc0hUTUxEb2N1bWVudCgp KSB7CiAgICAgICAgICAgICBSZW5kZXJCb3gqIGJveCA9IHRvUmVuZGVyQm94KHJlbmRlcmVyKCkp OwogICAgICAgICAgICAgaW50IHcgPSBib3gtPndpZHRoKCk7CiAgICAgICAgICAgICBpbnQgaCA9 IGJveC0+aGVpZ2h0KCk7Cg==