<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>26082</bug_id>
          
          <creation_ts>2009-05-29 11:15:01 -0700</creation_ts>
          <short_desc>REGRESSION: Conditionalize CFNetwork-specific logic in WebError.cpp</short_desc>
          <delta_ts>2009-05-29 11:52:20 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Brent Fulgham">bfulgham</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>123571</commentid>
    <comment_count>0</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2009-05-29 11:15:01 -0700</bug_when>
    <thetext>The WebKit Windows Cairo target no longer builds after @r42767, which added a new CFNetwork-specific (rather, WebKitSystemInterface) call.

(see http://trac.webkit.org/changeset?new=42767%40trunk%2FWebKit%2Fwin%2FWebError.cpp&amp;old=35460%40trunk%2FWebKit%2Fwin%2FWebError.cpp)

This patch adds a CFNetwork guard around this new code, similar to the other similar calls in this file.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>123572</commentid>
    <comment_count>1</comment_count>
      <attachid>30781</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2009-05-29 11:20:08 -0700</bug_when>
    <thetext>Created attachment 30781
Correct Windows Cairo build error.

Add conditional test around recently-added WebKitSystemInterface call.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>123582</commentid>
    <comment_count>2</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2009-05-29 11:52:20 -0700</bug_when>
    <thetext>Landed in r44267.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>30781</attachid>
            <date>2009-05-29 11:20:08 -0700</date>
            <delta_ts>2009-05-29 11:33:04 -0700</delta_ts>
            <desc>Correct Windows Cairo build error.</desc>
            <filename>winerror.patch</filename>
            <type>text/plain</type>
            <size>1105</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdC93aW4vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vQ2hh
bmdlTG9nCShyZXZpc2lvbiA0NDI2NSkKKysrIFdlYktpdC93aW4vQ2hhbmdlTG9nCSh3b3JraW5n
IGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDUtMjkgIEJyZW50IEZ1bGdoYW0gIDxiZnVs
Z2hhbUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor
CisgICAgICAgIENvcnJlY3QgV2luZG93cyBDYWlybyBidWlsZCBlcnJvciBjYXVzZWQgYnkgQHI0
Mjc2Ny4KKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjYw
ODIuCisKKyAgICAgICAgKiBXZWJFcnJvci5jcHA6CisgICAgICAgIChXZWJFcnJvcjo6bG9jYWxp
emVkRGVzY3JpcHRpb24pOgorCiAyMDA5LTA1LTIzICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBh
cHBsZS5jb20+CiAKICAgICAgICAgV2luZG93cyBidWlsZCBmaXggZm9yIFBhc3NPd25QdHIKSW5k
ZXg6IFdlYktpdC93aW4vV2ViRXJyb3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vV2Vi
RXJyb3IuY3BwCShyZXZpc2lvbiA0NDI2NSkKKysrIFdlYktpdC93aW4vV2ViRXJyb3IuY3BwCSh3
b3JraW5nIGNvcHkpCkBAIC0xMzcsMTAgKzEzNywxMiBAQCBIUkVTVUxUIFNURE1FVEhPRENBTExU
WVBFIFdlYkVycm9yOjpsb2NhCiAKICAgICAqcmVzdWx0ID0gQlN0cmluZyhtX2Vycm9yLmxvY2Fs
aXplZERlc2NyaXB0aW9uKCkpLnJlbGVhc2UoKTsKIAorI2lmIFBMQVRGT1JNKENGTkVUV09SSykK
ICAgICBpZiAoISpyZXN1bHQpIHsKICAgICAgICAgaWYgKGludCBjb2RlID0gbV9lcnJvci5lcnJv
ckNvZGUoKSkKICAgICAgICAgICAgICpyZXN1bHQgPSBCU3RyaW5nKHdrQ0ZOZXR3b3JrRXJyb3JH
ZXRMb2NhbGl6ZWREZXNjcmlwdGlvbihjb2RlKSkucmVsZWFzZSgpOwogICAgIH0KKyNlbmRpZgog
CiAgICAgcmV0dXJuIFNfT0s7CiB9Cg==
</data>
<flag name="review"
          id="15618"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>