26074 2009-05-29 01:09:27 -0700 SQLTransaction::executeSQL does an unnecessary call to String::copy. 2009-05-29 14:38:39 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 levin levin beidson oldest_to_newest 123526 0 levin 2009-05-29 01:09:27 -0700 The 1st argument is a string that is copied in this call: ... SQLStatement::create(sqlStatement.copy(), ...); SQLStatement also copies this string (see WebCore/storage/SQLStatement.cpp): SQLStatement::SQLStatement(const String& statement, ...) : m_statement(statement.copy()) 123527 1 30767 levin 2009-05-29 01:13:11 -0700 Created attachment 30767 Proposed fix. 123615 2 bfulgham 2009-05-29 14:38:39 -0700 Landed in @r44274. 30767 2009-05-29 01:13:11 -0700 2009-05-29 10:05:56 -0700 Proposed fix. bug26074.txt text/plain 1369 levin ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OWQwYWFjZi4uZDk2YmQ1NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wNS0yOSAgRGF2aWQgTGV2aW4g IDxsZXZpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQnVnIDI2MDc0OiBTUUxUcmFuc2FjdGlvbjo6ZXhlY3V0ZVNRTCBkb2Vz IGFuIHVubmVjZXNzYXJ5IGNhbGwgdG8gU3RyaW5nOjpjb3B5LgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjYwNzQKKworICAgICAgICBUaGUgY29uc3Ry dWN0b3IgZm9yIFNRTFN0YXRlbWVudCBhbHJlYWR5IGRvZXMgYSBjb3B5IGZvciB0aGlzIHN0cmlu Zy4KKworICAgICAgICAqIHN0b3JhZ2UvU1FMVHJhbnNhY3Rpb24uY3BwOgorICAgICAgICAoV2Vi Q29yZTo6U1FMVHJhbnNhY3Rpb246OmV4ZWN1dGVTUUwpOgorCiAyMDA5LTA1LTI4ICBEbWl0cnkg VGl0b3YgIDxkaW1pY2hAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0 cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvc3RvcmFnZS9TUUxUcmFuc2FjdGlvbi5j cHAgYi9XZWJDb3JlL3N0b3JhZ2UvU1FMVHJhbnNhY3Rpb24uY3BwCmluZGV4IGVjNDhjMTUuLjMz MzFlNmUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvc3RvcmFnZS9TUUxUcmFuc2FjdGlvbi5jcHAKKysr IGIvV2ViQ29yZS9zdG9yYWdlL1NRTFRyYW5zYWN0aW9uLmNwcApAQCAtOTYsNyArOTYsNyBAQCB2 b2lkIFNRTFRyYW5zYWN0aW9uOjpleGVjdXRlU1FMKGNvbnN0IFN0cmluZyYgc3FsU3RhdGVtZW50 LCBjb25zdCBWZWN0b3I8U1FMVmFsdQogICAgIGlmICghcGFnZSB8fCBwYWdlLT5zZXR0aW5ncygp LT5wcml2YXRlQnJvd3NpbmdFbmFibGVkKCkpCiAgICAgICAgIHJlYWRPbmx5TW9kZSA9IHRydWU7 CiAgICAgCi0gICAgUmVmUHRyPFNRTFN0YXRlbWVudD4gc3RhdGVtZW50ID0gU1FMU3RhdGVtZW50 OjpjcmVhdGUoc3FsU3RhdGVtZW50LmNvcHkoKSwgYXJndW1lbnRzLCBjYWxsYmFjaywgY2FsbGJh Y2tFcnJvciwgcmVhZE9ubHlNb2RlKTsKKyAgICBSZWZQdHI8U1FMU3RhdGVtZW50PiBzdGF0ZW1l bnQgPSBTUUxTdGF0ZW1lbnQ6OmNyZWF0ZShzcWxTdGF0ZW1lbnQsIGFyZ3VtZW50cywgY2FsbGJh Y2ssIGNhbGxiYWNrRXJyb3IsIHJlYWRPbmx5TW9kZSk7CiAKICAgICBpZiAobV9kYXRhYmFzZS0+ ZGVsZXRlZCgpKQogICAgICAgICBzdGF0ZW1lbnQtPnNldERhdGFiYXNlRGVsZXRlZEVycm9yKCk7 Cg==