26070 2009-05-28 14:54:11 -0700 [Qt] EventSender.keyDown doesn't support Arrow Up and Down keys. 2009-06-02 00:01:07 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All Linux RESOLVED FIXED Qt P2 Normal --- 20303 1 yongjun.zhang abarth abarth zecke oldest_to_newest 123477 0 yongjun.zhang 2009-05-28 14:54:11 -0700 It supports Left & Right key, but not Up and Down key. 123479 1 30754 yongjun.zhang 2009-05-28 14:58:00 -0700 Created attachment 30754 add support for Up Key and Down Key handling. 123510 2 zecke 2009-05-28 18:57:37 -0700 Okay, it looks good but for which unit test are you doing this? Why isn't the Skipped list updated after having fixed this issue? 123550 3 yongjun.zhang 2009-05-29 08:07:22 -0700 Hi, there is no existing layout testcase for this fix (at least I couldn't find one in Skipped list). I spot this bug when I was trying to create a layout test for https://bugs.webkit.org/show_bug.cgi?id=20303. How about I create a layout test case under LayoutTest/platform/qt/events to test this fix? 123660 4 30754 zecke 2009-05-29 18:17:06 -0700 Comment on attachment 30754 add support for Up Key and Down Key handling. Okay, the last comment was quite nice. Please land together with the fix in bug #20303 so we can sure to not touch this part of the code. 123946 5 abarth 2009-06-01 23:55:00 -0700 Will land. 123947 6 abarth 2009-06-02 00:01:07 -0700 Sending WebKitTools/ChangeLog Sending WebKitTools/DumpRenderTree/qt/jsobjects.cpp Transmitting file data .. Committed revision 44349. 30754 2009-05-28 14:58:00 -0700 2009-05-29 18:17:06 -0700 add support for Up Key and Down Key handling. DRT_up_down_key.patch text/plain 1661 yongjun.zhang SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQ0MjUyKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDUtMjggIFlvbmdqdW4gWmhhbmcgIDx5 b25nanVuLnpoYW5nQG5va2lhLmNvbT4+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yNjA3MD4KKworICAgICAgICBbUXRdIEV2ZW50U2VuZGVyLmtleURvd24gZG9lc24ndCBzdXBw b3J0IEFycm93IFVwIGFuZCBEb3duIGtleXMuCisgICAgICAgIEFkZCBEb3duIGFuZCBVcCBrZXkg c3VwcG9ydC4KKyAgICAgICAgCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvcXQvanNvYmplY3Rz LmNwcDoKKyAgICAgICAgKEV2ZW50U2VuZGVyOjprZXlEb3duKToKKwogMjAwOS0wNS0yOCAgT2xp dmllciBET0xFICA8b2RvbGVAcGxleW8uY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hY2ll ai4KSW5kZXg6IFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L2pzb2JqZWN0cy5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvanNvYmplY3RzLmNwcAko cmV2aXNpb24gNDQyNTIpCisrKyBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9qc29iamVj dHMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zOTQsNiArMzk0LDIwIEBAIHZvaWQgRXZlbnRTZW5k ZXI6OmtleURvd24oY29uc3QgUVN0cmluZyAKICAgICAgICAgICAgICAgICBjb2RlID0gUXQ6Oktl eV9FbmQ7CiAgICAgICAgICAgICAgICAgbW9kaWZzICY9IH5RdDo6TWV0YU1vZGlmaWVyOwogICAg ICAgICAgICAgfQorICAgICAgICB9IGVsc2UgaWYgKGNvZGUgPT0gMHhmNzAwKSB7CisgICAgICAg ICAgICBzID0gUVN0cmluZygpOworICAgICAgICAgICAgY29kZSA9IFF0OjpLZXlfVXA7CisgICAg ICAgICAgICBpZiAobW9kaWZzICYgUXQ6Ok1ldGFNb2RpZmllcikgeworICAgICAgICAgICAgICAg IGNvZGUgPSBRdDo6S2V5X1BhZ2VVcDsKKyAgICAgICAgICAgICAgICBtb2RpZnMgJj0gflF0OjpN ZXRhTW9kaWZpZXI7CisgICAgICAgICAgICB9CisgICAgICAgIH0gZWxzZSBpZiAoY29kZSA9PSAw eGY3MDEpIHsKKyAgICAgICAgICAgIHMgPSBRU3RyaW5nKCk7CisgICAgICAgICAgICBjb2RlID0g UXQ6OktleV9Eb3duOworICAgICAgICAgICAgaWYgKG1vZGlmcyAmIFF0OjpNZXRhTW9kaWZpZXIp IHsKKyAgICAgICAgICAgICAgICBjb2RlID0gUXQ6OktleV9QYWdlRG93bjsKKyAgICAgICAgICAg ICAgICBtb2RpZnMgJj0gflF0OjpNZXRhTW9kaWZpZXI7CisgICAgICAgICAgICB9CiAgICAgICAg IH0gZWxzZSBpZiAoY29kZSA9PSAnYScgJiYgbW9kaWZzID09IFF0OjpDb250cm9sTW9kaWZpZXIp IHsKICAgICAgICAgICAgIHMgPSBRU3RyaW5nKCk7CiAgICAgICAgICAgICBjb2RlID0gUXQ6Oktl eV9Ib21lOwo=