26069 2009-05-28 14:47:25 -0700 Fix a crash in custom V8 bindings code for XMLHttpRequest. 2009-05-29 16:18:13 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jianli jianli dglazkov levin oldest_to_newest 123475 0 jianli 2009-05-28 14:47:25 -0700 Fix a crash in custom V8 bindings code for XMLHttpRequest. Please see http://code.google.com/p/chromium/issues/detail?id=12792 for more details. 123478 1 30753 jianli 2009-05-28 14:54:40 -0700 Created attachment 30753 Proposed Patch 123493 2 dglazkov 2009-05-28 16:36:08 -0700 Is there a layout test that we could be used to exercise this fix? 123496 3 jianli 2009-05-28 17:07:02 -0700 (In reply to comment #2) > Is there a layout test that we could be used to exercise this fix? > I am afraid no. I could add one in WebKit. How do you think? 123610 4 30788 jianli 2009-05-29 14:12:05 -0700 Created attachment 30788 Proposed Patch 123613 5 30788 dglazkov 2009-05-29 14:33:54 -0700 Comment on attachment 30788 Proposed Patch Excellent. 123646 6 jianli 2009-05-29 16:18:13 -0700 Committed as http://trac.webkit.org/changeset/44275. 30753 2009-05-28 14:54:40 -0700 2009-05-29 14:12:05 -0700 Proposed Patch 26069 text/plain 1751 jianli ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MWQ2Y2U1YS4uZmI5NjcyZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0wNS0yOCAgSmlhbiBMaSAgPGpp YW5saUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI2MDY5 CisgICAgICAgIEZpeCBhIGNyYXNoIGluIGN1c3RvbSBWOCBiaW5kaW5ncyBjb2RlIGZvciBYTUxI dHRwUmVxdWVzdC4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOFhNTEh0dHBSZXF1 ZXN0Q3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNBTExCQUNLX0ZVTkNfREVDTCk6CisK IDIwMDktMDUtMjggIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3MvdjgvY3Vz dG9tL1Y4WE1MSHR0cFJlcXVlc3RDdXN0b20uY3BwIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0 b20vVjhYTUxIdHRwUmVxdWVzdEN1c3RvbS5jcHAKaW5kZXggODc4ZDVkMy4uY2I4MGE0ZiAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhYTUxIdHRwUmVxdWVzdEN1c3Rv bS5jcHAKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhYTUxIdHRwUmVxdWVzdEN1 c3RvbS5jcHAKQEAgLTMyMywxMiArMzIzLDIxIEBAIENBTExCQUNLX0ZVTkNfREVDTChYTUxIdHRw UmVxdWVzdE9wZW4pCiAgICAgU3RyaW5nIHVybHN0cmluZyA9IHRvV2ViQ29yZVN0cmluZyhhcmdz WzFdKTsKICAgICBTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0ID0gMDsKICNpZiBFTkFC TEUoV09SS0VSUykKLSAgICBXb3JrZXJDb250ZXh0RXhlY3V0aW9uUHJveHkqIHByb3h5ID0gV29y a2VyQ29udGV4dEV4ZWN1dGlvblByb3h5OjpyZXRyaWV2ZSgpOwotICAgIGlmIChwcm94eSkKLSAg ICAgICAgY29udGV4dCA9IHByb3h5LT53b3JrZXJDb250ZXh0KCk7Ci0gICAgZWxzZQorICAgIFdv cmtlckNvbnRleHRFeGVjdXRpb25Qcm94eSogd29ya2VyQ29udGV4dFByb3h5ID0gV29ya2VyQ29u dGV4dEV4ZWN1dGlvblByb3h5OjpyZXRyaWV2ZSgpOworICAgIGlmICh3b3JrZXJDb250ZXh0UHJv eHkpIHsKKyAgICAgICAgY29udGV4dCA9IHdvcmtlckNvbnRleHRQcm94eS0+d29ya2VyQ29udGV4 dCgpOworICAgICAgICBBU1NFUlQoY29udGV4dCk7CisgICAgfQogI2VuZGlmCi0gICAgICAgIGNv bnRleHQgPSBWOFByb3h5OjpyZXRyaWV2ZSgpLT5mcmFtZSgpLT5kb2N1bWVudCgpOworCisgICAg aWYgKCFjb250ZXh0KSB7CisgICAgICAgIFY4UHJveHkqIHByb3h5ID0gVjhQcm94eTo6cmV0cmll dmUoKTsKKyAgICAgICAgaWYgKCFwcm94eSkKKyAgICAgICAgICAgIHJldHVybiB2ODo6VW5kZWZp bmVkKCk7CisgICAgICAgIGNvbnRleHQgPSBwcm94eS0+ZnJhbWUoKS0+ZG9jdW1lbnQoKTsKKyAg ICAgICAgQVNTRVJUKGNvbnRleHQpOworICAgIH0KKwogICAgIEtVUkwgdXJsID0gY29udGV4dC0+ Y29tcGxldGVVUkwodXJsc3RyaW5nKTsKIAogICAgIGJvb2wgYXN5bmMgPSAoYXJncy5MZW5ndGgo KSA8IDMpID8gdHJ1ZSA6IGFyZ3NbMl0tPkJvb2xlYW5WYWx1ZSgpOwo= 30788 2009-05-29 14:12:05 -0700 2009-05-29 14:33:54 -0700 Proposed Patch 26069_2 text/plain 4566 jianli ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA4YWUxNDZmLi43YjIyYTgzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDUt MjkgIEppYW4gTGkgIDxqaWFubGlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yNjA2OQorICAgICAgICBUZXN0IGZvciB0aGUgYWJvdmUgYnVnLgorCisgICAg ICAgICogZmFzdC94bWxodHRwcmVxdWVzdC9yZXNvdXJjZXMveG1saHR0cHJlcXVlc3Qtb3Blbi1h ZnRlci1pZnJhbWUtb25sb2FkLXJlbW92ZS1zZWxmLWNoaWxkLmh0bWw6IEFkZGVkLgorICAgICAg ICAqIGZhc3QveG1saHR0cHJlcXVlc3QveG1saHR0cHJlcXVlc3Qtb3Blbi1hZnRlci1pZnJhbWUt b25sb2FkLXJlbW92ZS1zZWxmLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC94 bWxodHRwcmVxdWVzdC94bWxodHRwcmVxdWVzdC1vcGVuLWFmdGVyLWlmcmFtZS1vbmxvYWQtcmVt b3ZlLXNlbGYuaHRtbDogQWRkZWQuCisKIDIwMDktMDUtMjkgIE9saXZlciBIdW50ICA8b2xpdmVy QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKFRlc3QgZml4KS4KZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QveG1saHR0cHJlcXVlc3QvcmVzb3VyY2VzL3htbGh0 dHByZXF1ZXN0LW9wZW4tYWZ0ZXItaWZyYW1lLW9ubG9hZC1yZW1vdmUtc2VsZi1jaGlsZC5odG1s IGIvTGF5b3V0VGVzdHMvZmFzdC94bWxodHRwcmVxdWVzdC9yZXNvdXJjZXMveG1saHR0cHJlcXVl c3Qtb3Blbi1hZnRlci1pZnJhbWUtb25sb2FkLXJlbW92ZS1zZWxmLWNoaWxkLmh0bWwKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uYzg5NmU2MwotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2Zhc3QveG1saHR0cHJlcXVlc3QvcmVzb3VyY2VzL3htbGh0dHByZXF1ZXN0 LW9wZW4tYWZ0ZXItaWZyYW1lLW9ubG9hZC1yZW1vdmUtc2VsZi1jaGlsZC5odG1sCkBAIC0wLDAg KzEsMyBAQAorPGh0bWw+Cis8c2NyaXB0PiBmdW5jdGlvbiBjbGllbnQoKSB7IHJldHVybiBuZXcg WE1MSHR0cFJlcXVlc3QoKTsgfSA8L3NjcmlwdD4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2Zhc3QveG1saHR0cHJlcXVlc3QveG1saHR0cHJlcXVlc3Qtb3Blbi1hZnRlci1pZnJh bWUtb25sb2FkLXJlbW92ZS1zZWxmLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QveG1s aHR0cHJlcXVlc3QveG1saHR0cHJlcXVlc3Qtb3Blbi1hZnRlci1pZnJhbWUtb25sb2FkLXJlbW92 ZS1zZWxmLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi44 MDZmZGM1Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC94bWxodHRwcmVxdWVz dC94bWxodHRwcmVxdWVzdC1vcGVuLWFmdGVyLWlmcmFtZS1vbmxvYWQtcmVtb3ZlLXNlbGYtZXhw ZWN0ZWQudHh0CkBAIC0wLDAgKzEsMiBAQAorVGhpcyB0ZXN0cyB0aGF0IHJlbW92aW5nIGEgY2hp bGQgZnJhbWUgaW4gWE1MSHR0cFJlcXVlc3QgZG9lcyBub3QgY3Jhc2ggdGhlIHJlbmRlcmVyLiAK KwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC94bWxodHRwcmVxdWVzdC94bWxodHRwcmVx dWVzdC1vcGVuLWFmdGVyLWlmcmFtZS1vbmxvYWQtcmVtb3ZlLXNlbGYuaHRtbCBiL0xheW91dFRl c3RzL2Zhc3QveG1saHR0cHJlcXVlc3QveG1saHR0cHJlcXVlc3Qtb3Blbi1hZnRlci1pZnJhbWUt b25sb2FkLXJlbW92ZS1zZWxmLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw MC4uYTFhNTFjYwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QveG1saHR0cHJl cXVlc3QveG1saHR0cHJlcXVlc3Qtb3Blbi1hZnRlci1pZnJhbWUtb25sb2FkLXJlbW92ZS1zZWxm Lmh0bWwKQEAgLTAsMCArMSwyMSBAQAorPGh0bWw+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlv dXRUZXN0Q29udHJvbGxlcikgeworICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7 CisgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKK30KKyAgCitmdW5jdGlv biBvbkZyYW1lTG9hZChmcmFtZSkgeworICB2YXIgY2xpZW50ID0gZnJhbWUuY29udGVudFdpbmRv dy5jbGllbnQoKTsKKyAgZnJhbWUucGFyZW50Tm9kZS5yZW1vdmVDaGlsZChmcmFtZSk7CisgIGNs aWVudC5vcGVuKCJHRVQiLCAiRG9lc05vdEV4aXN0LnR4dCIpOworICBpZiAod2luZG93LmxheW91 dFRlc3RDb250cm9sbGVyKQorICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsK K30KKzwvc2NyaXB0PgorPGJvZHk+CitUaGlzIHRlc3RzIHRoYXQgcmVtb3ZpbmcgYSBjaGlsZCBm cmFtZSBpbiBYTUxIdHRwUmVxdWVzdCBkb2VzIG5vdCBjcmFzaCB0aGUgcmVuZGVyZXIuCis8YnI+ Cis8aWZyYW1lIHNyYz0icmVzb3VyY2VzL3htbGh0dHByZXF1ZXN0LW9wZW4tYWZ0ZXItaWZyYW1l LW9ubG9hZC1yZW1vdmUtc2VsZi1jaGlsZC5odG1sIiBvbmxvYWQ9Im9uRnJhbWVMb2FkKHRoaXMp Ij48L2lmcmFtZT4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdl TG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDA1ZGU4Zi4uOGM3MGM2ZCAxMDA2NDQKLS0t IGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx NSBAQAorMjAwOS0wNS0yOSAgSmlhbiBMaSAgPGppYW5saUBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI2MDY5CisgICAgICAgIEZpeCBhIGNyYXNoIGluIGN1 c3RvbSBWOCBiaW5kaW5ncyBjb2RlIGZvciBYTUxIdHRwUmVxdWVzdC4KKworICAgICAgICBUZXN0 OiBmYXN0L3htbGh0dHByZXF1ZXN0L3htbGh0dHByZXF1ZXN0LW9wZW4tYWZ0ZXItaWZyYW1lLW9u bG9hZC1yZW1vdmUtc2VsZi5odG1sCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9jdXN0b20vVjhY TUxIdHRwUmVxdWVzdEN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDQUxMQkFDS19GVU5D X0RFQ0wpOgorCiAyMDA5LTA1LTI5ICBBbGV4YW5kZXIgTWFjZG9uYWxkICA8YWxleG1hY0BhZG9i ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFhNTEh0dHBSZXF1ZXN0Q3VzdG9tLmNwcCBiL1dl YkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4WE1MSHR0cFJlcXVlc3RDdXN0b20uY3BwCmluZGV4 IDg3OGQ1ZDMuLmNiODBhNGYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9t L1Y4WE1MSHR0cFJlcXVlc3RDdXN0b20uY3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvY3Vz dG9tL1Y4WE1MSHR0cFJlcXVlc3RDdXN0b20uY3BwCkBAIC0zMjMsMTIgKzMyMywyMSBAQCBDQUxM QkFDS19GVU5DX0RFQ0woWE1MSHR0cFJlcXVlc3RPcGVuKQogICAgIFN0cmluZyB1cmxzdHJpbmcg PSB0b1dlYkNvcmVTdHJpbmcoYXJnc1sxXSk7CiAgICAgU2NyaXB0RXhlY3V0aW9uQ29udGV4dCog Y29udGV4dCA9IDA7CiAjaWYgRU5BQkxFKFdPUktFUlMpCi0gICAgV29ya2VyQ29udGV4dEV4ZWN1 dGlvblByb3h5KiBwcm94eSA9IFdvcmtlckNvbnRleHRFeGVjdXRpb25Qcm94eTo6cmV0cmlldmUo KTsKLSAgICBpZiAocHJveHkpCi0gICAgICAgIGNvbnRleHQgPSBwcm94eS0+d29ya2VyQ29udGV4 dCgpOwotICAgIGVsc2UKKyAgICBXb3JrZXJDb250ZXh0RXhlY3V0aW9uUHJveHkqIHdvcmtlckNv bnRleHRQcm94eSA9IFdvcmtlckNvbnRleHRFeGVjdXRpb25Qcm94eTo6cmV0cmlldmUoKTsKKyAg ICBpZiAod29ya2VyQ29udGV4dFByb3h5KSB7CisgICAgICAgIGNvbnRleHQgPSB3b3JrZXJDb250 ZXh0UHJveHktPndvcmtlckNvbnRleHQoKTsKKyAgICAgICAgQVNTRVJUKGNvbnRleHQpOworICAg IH0KICNlbmRpZgotICAgICAgICBjb250ZXh0ID0gVjhQcm94eTo6cmV0cmlldmUoKS0+ZnJhbWUo KS0+ZG9jdW1lbnQoKTsKKworICAgIGlmICghY29udGV4dCkgeworICAgICAgICBWOFByb3h5KiBw cm94eSA9IFY4UHJveHk6OnJldHJpZXZlKCk7CisgICAgICAgIGlmICghcHJveHkpCisgICAgICAg ICAgICByZXR1cm4gdjg6OlVuZGVmaW5lZCgpOworICAgICAgICBjb250ZXh0ID0gcHJveHktPmZy YW1lKCktPmRvY3VtZW50KCk7CisgICAgICAgIEFTU0VSVChjb250ZXh0KTsKKyAgICB9CisKICAg ICBLVVJMIHVybCA9IGNvbnRleHQtPmNvbXBsZXRlVVJMKHVybHN0cmluZyk7CiAKICAgICBib29s IGFzeW5jID0gKGFyZ3MuTGVuZ3RoKCkgPCAzKSA/IHRydWUgOiBhcmdzWzJdLT5Cb29sZWFuVmFs dWUoKTsK