26068 2009-05-28 14:33:31 -0700 V8: Remove usage of v8::Locker in timer callbacks 2009-05-28 16:45:20 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dimich dimich dglazkov jianli oldest_to_newest 123466 0 dimich 2009-05-28 14:33:31 -0700 Since we have switched to running 1 worker per worker process, we've been removing the v8 locks from the code to avoid triggering unnecessary api checks. This is one of the v8::Locker usages that's left. 123470 1 30749 dimich 2009-05-28 14:40:15 -0700 Created attachment 30749 Proposed patch This completes the fix for bug 25944, since the patches for enabling timers and that bug have "crossed in the queue". Existing LayoutTests/fast/workers/worker-timeout.html covers this fix (will start work in Chromium). 123494 2 dimich 2009-05-28 16:45:20 -0700 Landed: http://trac.webkit.org/changeset/44256 30749 2009-05-28 14:40:15 -0700 2009-05-28 16:34:38 -0700 Proposed patch patch.txt text/plain 1441 dimich ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZWE1ODViZC4uOGVjZDA2NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wNS0yOCAgRG1pdHJ5IFRpdG92 ICA8ZGltaWNoQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjYwNjgKKyAgICAgICAgVjg6IFJlbW92ZSB0aGUgcmVtYWluaW5nIGI4OjpMb2NrZXIgdXNhZ2Ug aW4gd29ya2VyIGNvZGUuCisgICAgICAgIFRoaXMgY29tcGxldGVzIHRoZSBmaXggZm9yIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTk0NCwKKyAgICAgICAgc2luY2Ug dGhlIHBhdGNoZXMgZm9yIGVuYWJsaW5nIHRpbWVycyBhbmQgdGhhdCBidWcgaGF2ZSAiY3Jvc3Nl ZCBpbiB0aGUgcXVldWUiLgorICAgICAgICBFeGlzdGluZyBMYXlvdXRUZXN0cy9mYXN0L3dvcmtl cnMvd29ya2VyLXRpbWVvdXQuaHRtbCBjb3ZlcnMgdGhpcyBmaXggKHdpbGwgc3RhcnQgd29yayBp biBDaHJvbWl1bSkuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9TY2hlZHVsZWRBY3Rpb24uY3Bw OgorICAgICAgICAoV2ViQ29yZTo6U2NoZWR1bGVkQWN0aW9uOjpleGVjdXRlKToKKwogMjAwOS0w NS0yOCAgQnJldHQgV2lsc29uICA8YnJldHR3QGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJl dmlld2VkLCBidWlsZCBmaXguCmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjaGVk dWxlZEFjdGlvbi5jcHAgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjaGVkdWxlZEFjdGlvbi5jcHAK aW5kZXggZGMzOWQ0MS4uYWI1MTYwMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy92OC9T Y2hlZHVsZWRBY3Rpb24uY3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NoZWR1bGVkQWN0 aW9uLmNwcApAQCAtMTMzLDcgKzEzMyw2IEBAIHZvaWQgU2NoZWR1bGVkQWN0aW9uOjpleGVjdXRl KFdvcmtlckNvbnRleHQqIHdvcmtlckNvbnRleHQpCiAgICAgV29ya2VyU2NyaXB0Q29udHJvbGxl ciogc2NyaXB0Q29udHJvbGxlciA9IHdvcmtlckNvbnRleHQtPnNjcmlwdCgpOwogCiAgICAgaWYg KCFtX2Z1bmN0aW9uLklzRW1wdHkoKSAmJiBtX2Z1bmN0aW9uLT5Jc0Z1bmN0aW9uKCkpIHsKLSAg ICAgICAgdjg6OkxvY2tlciBsb2NrZWQ7CiAgICAgICAgIHY4OjpIYW5kbGVTY29wZSBoYW5kbGVT Y29wZTsKICAgICAgICAgdjg6OkxvY2FsPHY4OjpDb250ZXh0PiB2OENvbnRleHQgPSBzY3JpcHRD b250cm9sbGVyLT5wcm94eSgpLT5HZXRDb250ZXh0KCk7CiAgICAgICAgIEFTU0VSVCghdjhDb250 ZXh0LklzRW1wdHkoKSk7Cg==