26067 2009-05-28 13:30:43 -0700 Chromium build broken by IntSize change 2009-05-28 14:23:59 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED P1 Normal --- 1 brettw brettw bfulgham simon.fraser oldest_to_newest 123455 0 brettw 2009-05-28 13:30:43 -0700 https://bugs.webkit.org/show_bug.cgi?id=8736 broke the Chromium build which has stricter warnings. The addition of scale() to IntSize implicitly casts a float to int. Simon, are you sure this shouldn't round to nearest rather than round down? 123457 1 30748 brettw 2009-05-28 13:46:57 -0700 Created attachment 30748 Patch 123461 2 brettw 2009-05-28 14:15:10 -0700 Checked in as 44252 123462 3 30748 brettw 2009-05-28 14:15:33 -0700 Comment on attachment 30748 Patch Simon, it would still be nice if you could check this after the fact. 123464 4 simon.fraser 2009-05-28 14:23:59 -0700 This change is fine. I followed IntRect::scale(), which uses C-style casts. 30748 2009-05-28 13:46:57 -0700 2009-05-28 14:15:33 -0700 Patch intsize.diff text/plain 1105 brettw ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MWQ2Y2U1YS4uNjZiNzY2OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wNS0yOCAgQnJldHQgV2lsc29u ICA8YnJldHR3QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjYwNjcKKworICAgICAgICBBZGQgY2FzdHMgZm9yIHNjYWxlIGZ1bmN0aW9uIHRvIG1ha2UgbW9y ZSBleHBsaWNpdCB3aGF0IGlzIGhhcHBlbmluZworICAgICAgICBhbmQgZml4IGEgY29tcGlsZXIg d2FybmluZy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ludFNpemUuaDoKKyAgICAg ICAgKFdlYkNvcmU6OkludFNpemU6OnNjYWxlKToKKwogMjAwOS0wNS0yOCAgU2FtIFdlaW5pZyAg PHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbnRTaXplLmggYi9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL0ludFNpemUuaAppbmRleCA2MGE3NjEwLi5jYWMwYmQxIDEwMDY0NAot LS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ludFNpemUuaAorKysgYi9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL0ludFNpemUuaApAQCAtNzUsOCArNzUsOCBAQCBwdWJsaWM6CiAgICAg CiAgICAgdm9pZCBzY2FsZShmbG9hdCBzY2FsZSkKICAgICB7Ci0gICAgICAgIG1fd2lkdGggKj0g c2NhbGU7Ci0gICAgICAgIG1faGVpZ2h0ICo9IHNjYWxlOworICAgICAgICBtX3dpZHRoID0gc3Rh dGljX2Nhc3Q8aW50PihzdGF0aWNfY2FzdDxmbG9hdD4obV93aWR0aCkgKiBzY2FsZSk7CisgICAg ICAgIG1faGVpZ2h0ID0gc3RhdGljX2Nhc3Q8aW50PihzdGF0aWNfY2FzdDxmbG9hdD4obV9oZWln aHQpICogc2NhbGUpOwogICAgIH0KICAgICAKICAgICBJbnRTaXplIGV4cGFuZGVkVG8oY29uc3Qg SW50U2l6ZSYgb3RoZXIpIGNvbnN0Cg==