26061 2009-05-28 06:08:25 -0700 [SKIA] Crash when filling an empty pattern 2009-06-10 11:05:29 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 deanm webkit-unassigned eric skylined oldest_to_newest 123399 0 deanm 2009-05-28 06:08:25 -0700 Skia-specific crash, where we assume that the bitmap for a pattern is valid. In reality it can return NULL. For example: createPattern(new Image, "repeat") Original Chromium bug: http://code.google.com/p/chromium/issues/detail?id=10881 123400 1 30735 deanm 2009-05-28 06:10:57 -0700 Created attachment 30735 patch 124312 2 30735 eric 2009-06-04 09:05:16 -0700 Comment on attachment 30735 patch The patch looks fine. I would have used a named constant for the color. I'm surprised that skia doesn't have a "transparent" constant that you can return instead of having to manually construct a color. Color::transparent is identical, and is guaranteed to be the right format due to COMPILE_ASSERT checks in ColorSkia.cpp. Tab indent should be 4 spaces, not 2. Those are both nits someone could fix when landing. 125129 3 31129 deanm 2009-06-10 05:54:27 -0700 Created attachment 31129 Patch with indention fixed Fixed the indention line. I don't think making a constant (since Skia doesn't already have one) is worthwhile, it's pretty clear from the comment that I'm creating a transparent color. I don't like using Color in place of SkColor, even though I realize they have the same layout. 125171 4 bfulgham 2009-06-10 11:05:29 -0700 Please don't remove "Reviewed by (OOPS)" comment created by prepare-ChangeLog. Confirmed p-1.txt and p-2.txt differed only by spacing per Eric's comment and landed. Landed in @r44575. 30735 2009-05-28 06:10:57 -0700 2009-06-04 09:05:16 -0700 patch p text/plain 3390 deanm ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlZmE4ZWE1Li44MmIzMmFjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTEgQEAKKzIwMDktMDUt MjggIERlYW4gTWNOYW1lZSAgPGRlYW5tQGNocm9taXVtLm9yZz4KKworICAgICAgICBNYWtlIHN1 cmUgZmlsbGluZyBhIGNhbnZhcyBwYXR0ZXJuIHdpdGggYW4gZW1wdHkgaW1hZ2UgZG9lc24ndCBj cmFzaC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI2 MDYxCisKKyAgICAgICAgKiBmYXN0L2NhbnZhcy9jYW52YXMtZW1wdHktaW1hZ2UtcGF0dGVybi1l eHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY2FudmFzL2NhbnZhcy1lbXB0eS1p bWFnZS1wYXR0ZXJuLmh0bWw6IEFkZGVkLgorCiAyMDA5LTA1LTI4ICBBZGFtIEJhcnRoICA8YWJh cnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9jYW52YXMtZW1wdHktaW1hZ2UtcGF0dGVy bi1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9jYW52YXMtZW1wdHktaW1h Z2UtcGF0dGVybi1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw MC4uZDAxNWU5ZQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL2Nh bnZhcy1lbXB0eS1pbWFnZS1wYXR0ZXJuLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDggQEAKK2xh eWVyIGF0ICgwLDApIHNpemUgODAweDYwMAorICBSZW5kZXJWaWV3IGF0ICgwLDApIHNpemUgODAw eDYwMAorbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4MTIwCisgIFJlbmRlckJsb2NrIHtIVE1MfSBh dCAoMCwwKSBzaXplIDgwMHgxMjAKKyAgICBSZW5kZXJCb2R5IHtCT0RZfSBhdCAoOCw4KSBzaXpl IDc4NHgxMDQKKyAgICAgIFJlbmRlckhUTUxDYW52YXMge0NBTlZBU30gYXQgKDAsMCkgc2l6ZSAx MDB4MTAwCisgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAsMCkgc2l6ZSAweDAKKyAgICAg IFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMCwwKSBzaXplIDB4MApkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvZmFzdC9jYW52YXMvY2FudmFzLWVtcHR5LWltYWdlLXBhdHRlcm4uaHRtbCBiL0xheW91 dFRlc3RzL2Zhc3QvY2FudmFzL2NhbnZhcy1lbXB0eS1pbWFnZS1wYXR0ZXJuLmh0bWwKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uODNlM2RhOQotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL2NhbnZhcy1lbXB0eS1pbWFnZS1wYXR0ZXJuLmh0bWwK QEAgLTAsMCArMSw4IEBACis8IURPQ1RZUEUgSFRNTD4KKzx0aXRsZT5DYW52YXMgdGVzdDogZmls bGluZyBhIHBhdHRlcm4gd2l0aCBhbiBlbXB0eSBpbWFnZSBzaG91bGQgbm90IGNyYXNoLjwvdGl0 bGU+Cis8Y2FudmFzIGlkPSJjYW52YXMiIGNsYXNzPSJvdXRwdXQiIHdpZHRoPSIxMDAiIGhlaWdo dD0iMTAwIj48cCBjbGFzcz0iZmFsbGJhY2siPkZBSUwgKGZhbGxiYWNrIGNvbnRlbnQpPC9wPjwv Y2FudmFzPgorPHNjcmlwdD4KK3ZhciBjYW52YXMgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgi Y2FudmFzIikuZ2V0Q29udGV4dCgiMmQiKTsKK2NhbnZhcy5maWxsU3R5bGUgPSBjYW52YXMuY3Jl YXRlUGF0dGVybihuZXcgSW1hZ2UsICJyZXBlYXQiKQorY2FudmFzLmZpbGxSZWN0KDAsMCwxLDEp Cis8L3NjcmlwdD4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFu Z2VMb2cKaW5kZXggOWJkNjJmZi4uN2M4OGRmNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VM b2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0wNS0yOCAg RGVhbiBNY05hbWVlICA8ZGVhbm1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdoZW4gdGhlcmUg aXMgbm8gYmFja2luZyBiaXRtYXAsIHJldHVybiBhIHRyYW5zcGFyZW50IHBhdHRlcm4uCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjA2MQorCisgICAg ICAgIFRlc3Q6IGZhc3QvY2FudmFzL2NhbnZhcy1lbXB0eS1pbWFnZS1wYXR0ZXJuLmh0bWwKKwor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGF0dGVyblNraWEuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6UGF0dGVybjo6Y3JlYXRlUGxhdGZvcm1QYXR0ZXJuKToKKwogMjAwOS0wNS0y OCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lh L1BhdHRlcm5Ta2lhLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QYXR0ZXJu U2tpYS5jcHAKaW5kZXggYmU4ZWI4YS4uNDgxODIwZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9za2lhL1BhdHRlcm5Ta2lhLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3NraWEvUGF0dGVyblNraWEuY3BwCkBAIC0zMyw4ICszMywxMCBAQAogI2luY2x1 ZGUgIk5hdGl2ZUltYWdlU2tpYS5oIgogI2luY2x1ZGUgIlRyYW5zZm9ybWF0aW9uTWF0cml4Lmgi CiAKLSNpbmNsdWRlICJTa1NoYWRlci5oIgogI2luY2x1ZGUgIlNrQ2FudmFzLmgiCisjaW5jbHVk ZSAiU2tDb2xvci5oIgorI2luY2x1ZGUgIlNrQ29sb3JTaGFkZXIuaCIKKyNpbmNsdWRlICJTa1No YWRlci5oIgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKQEAgLTQ5LDYgKzUxLDEwIEBAIFBsYXRm b3JtUGF0dGVyblB0ciBQYXR0ZXJuOjpjcmVhdGVQbGF0Zm9ybVBhdHRlcm4oY29uc3QgVHJhbnNm b3JtYXRpb25NYXRyaXgmIHBhCiAgICAgLy8gTGF5b3V0VGVzdHMvc3ZnL1czQy1TVkctMS4xL3Bz ZXJ2ZXJzLWdyYWQtMDYtYi5zdmcKIAogICAgIFNrQml0bWFwKiBibSA9IG1fdGlsZUltYWdlLT5u YXRpdmVJbWFnZUZvckN1cnJlbnRGcmFtZSgpOworICAgIC8vIElmIHdlIGRvbid0IGhhdmUgYSBi aXRtYXAsIHJldHVybiBhIHRyYW5zcGFyZW50IHNoYWRlci4KKyAgICBpZiAoIWJtKQorICAgICAg cmV0dXJuIG5ldyBTa0NvbG9yU2hhZGVyKFNrQ29sb3JTZXRBUkdCKDAsIDAsIDAsIDApKTsKKwog ICAgIGlmIChtX3JlcGVhdFggJiYgbV9yZXBlYXRZKQogICAgICAgICByZXR1cm4gU2tTaGFkZXI6 OkNyZWF0ZUJpdG1hcFNoYWRlcigqYm0sIFNrU2hhZGVyOjprUmVwZWF0X1RpbGVNb2RlLCBTa1No YWRlcjo6a1JlcGVhdF9UaWxlTW9kZSk7CiAK 31129 2009-06-10 05:54:27 -0700 2009-06-10 05:54:27 -0700 Patch with indention fixed p text/plain 3449 deanm ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxMDUzNjlhLi42Njk3ODc5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTEgQEAKKzIwMDktMDYt MTAgIERlYW4gTWNOYW1lZSAgPGRlYW5tQGNocm9taXVtLm9yZz4KKworICAgICAgICBNYWtlIHN1 cmUgZmlsbGluZyBhIGNhbnZhcyBwYXR0ZXJuIHdpdGggYW4gZW1wdHkgaW1hZ2UgZG9lc24ndCBj cmFzaC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI2 MDYxCisKKyAgICAgICAgKiBmYXN0L2NhbnZhcy9jYW52YXMtZW1wdHktaW1hZ2UtcGF0dGVybi1l eHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY2FudmFzL2NhbnZhcy1lbXB0eS1p bWFnZS1wYXR0ZXJuLmh0bWw6IEFkZGVkLgorCiAyMDA5LTA2LTA4ICBCcmFkeSBFaWRzb24gIDxi ZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbnR0aSBLb2l2aXN0bwpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvY2FudmFzLWVtcHR5LWltYWdlLXBh dHRlcm4tZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvY2FudmFzLWVtcHR5 LWltYWdlLXBhdHRlcm4tZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAuLmQwMTVlOWUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2NhbnZh cy9jYW52YXMtZW1wdHktaW1hZ2UtcGF0dGVybi1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw4IEBA CitsYXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgUmVuZGVyVmlldyBhdCAoMCwwKSBzaXpl IDgwMHg2MDAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDEyMAorICBSZW5kZXJCbG9jayB7SFRN TH0gYXQgKDAsMCkgc2l6ZSA4MDB4MTIwCisgICAgUmVuZGVyQm9keSB7Qk9EWX0gYXQgKDgsOCkg c2l6ZSA3ODR4MTA0CisgICAgICBSZW5kZXJIVE1MQ2FudmFzIHtDQU5WQVN9IGF0ICgwLDApIHNp emUgMTAweDEwMAorICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgwLDApIHNpemUgMHgwCisg ICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAsMCkgc2l6ZSAweDAKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2Zhc3QvY2FudmFzL2NhbnZhcy1lbXB0eS1pbWFnZS1wYXR0ZXJuLmh0bWwgYi9M YXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9jYW52YXMtZW1wdHktaW1hZ2UtcGF0dGVybi5odG1sCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjgzZTNkYTkKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9jYW52YXMtZW1wdHktaW1hZ2UtcGF0dGVybi5o dG1sCkBAIC0wLDAgKzEsOCBAQAorPCFET0NUWVBFIEhUTUw+Cis8dGl0bGU+Q2FudmFzIHRlc3Q6 IGZpbGxpbmcgYSBwYXR0ZXJuIHdpdGggYW4gZW1wdHkgaW1hZ2Ugc2hvdWxkIG5vdCBjcmFzaC48 L3RpdGxlPgorPGNhbnZhcyBpZD0iY2FudmFzIiBjbGFzcz0ib3V0cHV0IiB3aWR0aD0iMTAwIiBo ZWlnaHQ9IjEwMCI+PHAgY2xhc3M9ImZhbGxiYWNrIj5GQUlMIChmYWxsYmFjayBjb250ZW50KTwv cD48L2NhbnZhcz4KKzxzY3JpcHQ+Cit2YXIgY2FudmFzID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoImNhbnZhcyIpLmdldENvbnRleHQoIjJkIik7CitjYW52YXMuZmlsbFN0eWxlID0gY2FudmFz LmNyZWF0ZVBhdHRlcm4obmV3IEltYWdlLCAicmVwZWF0IikKK2NhbnZhcy5maWxsUmVjdCgwLDAs MSwxKQorPC9zY3JpcHQ+CmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUv Q2hhbmdlTG9nCmluZGV4IDE3ZDMyMzIuLjkxZWZhNWYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hh bmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDYt MTAgIERlYW4gTWNOYW1lZSAgPGRlYW5tQGNocm9taXVtLm9yZz4KKworICAgICAgICBXaGVuIHRo ZXJlIGlzIG5vIGJhY2tpbmcgYml0bWFwLCByZXR1cm4gYSB0cmFuc3BhcmVudCBwYXR0ZXJuLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjYwNjEKKwor ICAgICAgICBUZXN0OiBmYXN0L2NhbnZhcy9jYW52YXMtZW1wdHktaW1hZ2UtcGF0dGVybi5odG1s CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BhdHRlcm5Ta2lhLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlBhdHRlcm46OmNyZWF0ZVBsYXRmb3JtUGF0dGVybik6CisKIDIwMDkt MDYtMDkgIFNpbW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29tPgogCiAgICAg ICAgIEZpeCB0aGUgUXQgYnVpbGQsIHRoZSB0aW1lIGZ1bmN0aW9ucyBtb3ZlZCBpbnRvIHRoZSBX VEYgbmFtZXNwYWNlLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lh L1BhdHRlcm5Ta2lhLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QYXR0ZXJu U2tpYS5jcHAKaW5kZXggYmU4ZWI4YS4uMTFiNWNmMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9za2lhL1BhdHRlcm5Ta2lhLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3NraWEvUGF0dGVyblNraWEuY3BwCkBAIC0zMyw4ICszMywxMCBAQAogI2luY2x1 ZGUgIk5hdGl2ZUltYWdlU2tpYS5oIgogI2luY2x1ZGUgIlRyYW5zZm9ybWF0aW9uTWF0cml4Lmgi CiAKLSNpbmNsdWRlICJTa1NoYWRlci5oIgogI2luY2x1ZGUgIlNrQ2FudmFzLmgiCisjaW5jbHVk ZSAiU2tDb2xvci5oIgorI2luY2x1ZGUgIlNrQ29sb3JTaGFkZXIuaCIKKyNpbmNsdWRlICJTa1No YWRlci5oIgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKQEAgLTQ5LDYgKzUxLDEwIEBAIFBsYXRm b3JtUGF0dGVyblB0ciBQYXR0ZXJuOjpjcmVhdGVQbGF0Zm9ybVBhdHRlcm4oY29uc3QgVHJhbnNm b3JtYXRpb25NYXRyaXgmIHBhCiAgICAgLy8gTGF5b3V0VGVzdHMvc3ZnL1czQy1TVkctMS4xL3Bz ZXJ2ZXJzLWdyYWQtMDYtYi5zdmcKIAogICAgIFNrQml0bWFwKiBibSA9IG1fdGlsZUltYWdlLT5u YXRpdmVJbWFnZUZvckN1cnJlbnRGcmFtZSgpOworICAgIC8vIElmIHdlIGRvbid0IGhhdmUgYSBi aXRtYXAsIHJldHVybiBhIHRyYW5zcGFyZW50IHNoYWRlci4KKyAgICBpZiAoIWJtKQorICAgICAg ICByZXR1cm4gbmV3IFNrQ29sb3JTaGFkZXIoU2tDb2xvclNldEFSR0IoMCwgMCwgMCwgMCkpOwor CiAgICAgaWYgKG1fcmVwZWF0WCAmJiBtX3JlcGVhdFkpCiAgICAgICAgIHJldHVybiBTa1NoYWRl cjo6Q3JlYXRlQml0bWFwU2hhZGVyKCpibSwgU2tTaGFkZXI6OmtSZXBlYXRfVGlsZU1vZGUsIFNr U2hhZGVyOjprUmVwZWF0X1RpbGVNb2RlKTsKIAo=