26056 2009-05-27 22:57:18 -0700 XPath string() function can be very slow 2009-05-27 23:02:47 -0700 1 1 1 Unclassified WebKit XML 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ap ap oldest_to_newest 123357 0 ap 2009-05-27 22:57:18 -0700 stringValue(Node*) appends values to a String, which is very slow for a large tree. Patch forthcoming. 123358 1 30727 ap 2009-05-27 22:58:52 -0700 Created attachment 30727 proposed fix 123359 2 30727 oliver 2009-05-27 23:01:15 -0700 Comment on attachment 30727 proposed fix r=me 123360 3 ap 2009-05-27 23:02:47 -0700 Committed r44220. 30727 2009-05-27 22:58:52 -0700 2009-05-27 23:01:15 -0700 proposed fix XPathStringVector.txt text/plain 1649 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NDIxOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDktMDUtMjcgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjA1NgorICAgICAgICBY UGF0aCBzdHJpbmcoKSBmdW5jdGlvbiBjYW4gYmUgdmVyeSBzbG93CisKKyAgICAgICAgKiB4bWwv WFBhdGhVdGlsLmNwcDogKFdlYkNvcmU6OlhQYXRoOjpzdHJpbmdWYWx1ZSk6IFVzZSBhbiBpbnRl cm1lZGlhdGUgVmVjdG9yIHdoZW4gYXBwZWFuZGluZy4KKwogMjAwOS0wNS0yNyAgRGFuIEJlcm5z dGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcu CkluZGV4OiBXZWJDb3JlL3htbC9YUGF0aFV0aWwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUv eG1sL1hQYXRoVXRpbC5jcHAJKHJldmlzaW9uIDQ0MjE3KQorKysgV2ViQ29yZS94bWwvWFBhdGhV dGlsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTEsMTMgKzUxLDE2IEBAIFN0cmluZyBzdHJpbmdW YWx1ZShOb2RlKiBub2RlKQogICAgICAgICAgICAgcmV0dXJuIG5vZGUtPm5vZGVWYWx1ZSgpOwog ICAgICAgICBkZWZhdWx0OgogICAgICAgICAgICAgaWYgKGlzUm9vdERvbU5vZGUobm9kZSkgfHwg bm9kZS0+bm9kZVR5cGUoKSA9PSBOb2RlOjpFTEVNRU5UX05PREUpIHsKLSAgICAgICAgICAgICAg ICBTdHJpbmcgc3RyOwotICAgICAgICAgICAgICAgIAotICAgICAgICAgICAgICAgIGZvciAoTm9k ZSogbiA9IG5vZGUtPmZpcnN0Q2hpbGQoKTsgbjsgbiA9IG4tPnRyYXZlcnNlTmV4dE5vZGUobm9k ZSkpCi0gICAgICAgICAgICAgICAgICAgIGlmIChuLT5pc1RleHROb2RlKCkpCi0gICAgICAgICAg ICAgICAgICAgICAgICBzdHIgKz0gbi0+bm9kZVZhbHVlKCk7CisgICAgICAgICAgICAgICAgVmVj dG9yPFVDaGFyPiByZXN1bHQ7CiAKLSAgICAgICAgICAgICAgICByZXR1cm4gc3RyOworICAgICAg ICAgICAgICAgIGZvciAoTm9kZSogbiA9IG5vZGUtPmZpcnN0Q2hpbGQoKTsgbjsgbiA9IG4tPnRy YXZlcnNlTmV4dE5vZGUobm9kZSkpIHsKKyAgICAgICAgICAgICAgICAgICAgaWYgKG4tPmlzVGV4 dE5vZGUoKSkgeworICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgU3RyaW5nJiBub2RlVmFs dWUgPSBuLT5ub2RlVmFsdWUoKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIHJlc3VsdC5hcHBl bmQobm9kZVZhbHVlLmNoYXJhY3RlcnMoKSwgbm9kZVZhbHVlLmxlbmd0aCgpKTsKKyAgICAgICAg ICAgICAgICAgICAgfQorICAgICAgICAgICAgICAgIH0KKworICAgICAgICAgICAgICAgIHJldHVy biBTdHJpbmc6OmFkb3B0KHJlc3VsdCk7CiAgICAgICAgICAgICB9CiAgICAgfQogICAgIAo=