260541 2023-08-22 14:10:08 -0700 REGRESSION(267124@main): [Win] layout tests using a context menu are timing out 2023-08-29 14:35:24 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 260821 https://bugs.webkit.org/show_bug.cgi?id=260356 InRadar P2 Normal --- 1 fujii webkit-unassigned webkit-bug-importer oldest_to_newest 1972714 0 fujii 2023-08-22 14:10:08 -0700 REGRESSION(267124@main): [Win] layout tests using a context menu are timing out After 267124@main (bug#260356). Buildbot: builder WinCairo-64-bit-Release-Tests build 1905 (267125@main) https://build.webkit.org/#/builders/728/builds/1905 Regressions: Unexpected timeouts (17) editing/selection/5354455-1.html [ Timeout ] editing/selection/5354455-2.html [ Timeout ] editing/selection/button-right-click.html [ Timeout ] editing/selection/context-menu-on-text.html [ Timeout ] editing/selection/context-menu-text-selection-lookup.html [ Timeout ] editing/selection/context-menu-text-selection.html [ Timeout ] editing/selection/empty-cell-right-click.html [ Timeout ] editing/selection/minimal-user-select-crash.html [ Timeout ] fast/events/context-no-deselect.html [ Timeout ] fast/events/context-nodrag.html [ Timeout ] fast/events/context-onmousedown-event.html [ Timeout ] fast/events/contextmenu-actions-in-selected-text.html [ Timeout ] fast/events/contextmenu-dismiss-blink-caret.html [ Timeout ] fast/events/contextmenu-lookup-action-for-image.html [ Timeout ] fast/events/contextmenu-scrolled-page-with-frame.html [ Timeout ] fast/events/right-click-focus.html [ Timeout ] fast/events/selectstart-prevent-selection-on-right-click.html [ Timeout ] 1972928 1 fujii 2023-08-23 01:32:43 -0700 Before the change, popup menu of context menu doesn't show. After the change, a context menu shows by the following callstack. > WebKit2.dll!WebKit::WebContextMenu::show() Line 55 C++ > WebKit2.dll!WebKit::WebFrame::handleContextMenuEvent(const WebCore::PlatformMouseEvent & platformMouseEvent) Line 1235 C++ > WebKit2.dll!WebKit::WebPage::contextMenuAtPointInWindow(WebCore::ProcessQualified<WTF::ObjectIdentifierGeneric<WebCore::FrameIdentifierType,WTF::ObjectIdentifierMainThreadAccessTraits>> frameID, const WebCore::IntPoint & point) Line 3102 C++ > WebKit2.dll!WKBundlePageCopyContextMenuAtPointInWindow(const OpaqueWKBundlePage * pageRef, WKPoint point) Line 224 C++ > TestRunnerInjectedBundle.dll!WTR::EventSendingController::contextClick() Line 441 C++ > TestRunnerInjectedBundle.dll!WTR::JSEventSendingController::contextClick(const OpaqueJSContext * context, OpaqueJSValue * __formal, OpaqueJSValue * thisObject, unsigned __int64 argumentCount, const OpaqueJSValue * const * arguments, const OpaqueJSValue * * exception) Line 256 C++ > JavaScriptCore.dll!JSC::APICallbackFunction::callImpl<JSC::JSCallbackFunction>(JSC::JSGlobalObject * globalObject, JSC::CallFrame * callFrame) Line 61 C++ > JavaScriptCore.dll!JSC::callJSCallbackFunction(JSC::JSGlobalObject * globalObject, JSC::CallFrame * callFrame) Line 43 C++ > (...) The context menu never closes. All tests time out. 1973153 2 467406 fujii 2023-08-23 17:28:51 -0700 Created attachment 467406 WIP patch The original code doesn't show a context menu for contextMenuAtPointInWindow. How about this patch? 1974294 3 webkit-bug-importer 2023-08-29 14:11:16 -0700 <rdar://problem/114659223> 1974304 4 fujii 2023-08-29 14:35:24 -0700 *** This bug has been marked as a duplicate of bug 260821 *** 467406 2023-08-23 17:28:51 -0700 2023-08-23 17:28:51 -0700 WIP patch do-not-show-context-menu.diff text/plain 2763 fujii ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkZyYW1lLmNw cCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkZyYW1lLmNwcAppbmRleCBi MDE2NDA5YmM5MzYuLmEwOGRlN2RhZTFiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQ cm9jZXNzL1dlYlBhZ2UvV2ViRnJhbWUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vz cy9XZWJQYWdlL1dlYkZyYW1lLmNwcApAQCAtMTIxNCw3ICsxMjE0LDcgQEAgc3RhdGljIGJvb2wg aXNDb250ZXh0Q2xpY2soY29uc3QgUGxhdGZvcm1Nb3VzZUV2ZW50JiBldmVudCkKICNlbmRpZgog fQogCi1ib29sIFdlYkZyYW1lOjpoYW5kbGVDb250ZXh0TWVudUV2ZW50KGNvbnN0IFBsYXRmb3Jt TW91c2VFdmVudCYgcGxhdGZvcm1Nb3VzZUV2ZW50KQorYm9vbCBXZWJGcmFtZTo6aGFuZGxlQ29u dGV4dE1lbnVFdmVudChjb25zdCBQbGF0Zm9ybU1vdXNlRXZlbnQmIHBsYXRmb3JtTW91c2VFdmVu dCwgYm9vbCBzaG93c0NvbnRleHRNZW51KQogewogICAgIGF1dG8qIGNvcmVMb2NhbEZyYW1lID0g ZHluYW1pY0Rvd25jYXN0PExvY2FsRnJhbWU+KGNvcmVGcmFtZSgpKTsKICAgICBpZiAoIWNvcmVM b2NhbEZyYW1lKQpAQCAtMTIyOSw4ICsxMjI5LDEwIEBAIGJvb2wgV2ViRnJhbWU6OmhhbmRsZUNv bnRleHRNZW51RXZlbnQoY29uc3QgUGxhdGZvcm1Nb3VzZUV2ZW50JiBwbGF0Zm9ybU1vdXNlRXZl CiAKICAgICBib29sIGhhbmRsZWQgPSBjb3JlTG9jYWxGcmFtZS0+dXNlcklucHV0QnJpZGdlKCku aGFuZGxlQ29udGV4dE1lbnVFdmVudChwbGF0Zm9ybU1vdXNlRXZlbnQpOwogI2lmIEVOQUJMRShD T05URVhUX01FTlVTKQotICAgIGlmIChoYW5kbGVkKQorICAgIGlmIChoYW5kbGVkICYmIHNob3dz Q29udGV4dE1lbnUpCiAgICAgICAgIHBhZ2UoKS0+Y29udGV4dE1lbnUoKS5zaG93KCk7CisjZWxz ZQorICAgIFVOVVNFRF9QQVJBTShzaG93c0NvbnRleHRNZW51KQogI2VuZGlmCiAgICAgcmV0dXJu IGhhbmRsZWQ7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFn ZS9XZWJGcmFtZS5oIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViRnJhbWUu aAppbmRleCAxMDljMDc3NWJlMTQuLmU1ZTI4MzVkZTkyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViRnJhbWUuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1dl YlByb2Nlc3MvV2ViUGFnZS9XZWJGcmFtZS5oCkBAIC0yMjgsNyArMjI4LDcgQEAgcHVibGljOgog ICAgIE9wdGlvblNldDxXZWJDb3JlOjpBZHZhbmNlZFByaXZhY3lQcm90ZWN0aW9ucz4gYWR2YW5j ZWRQcml2YWN5UHJvdGVjdGlvbnMoKSBjb25zdDsKICAgICBPcHRpb25TZXQ8V2ViQ29yZTo6QWR2 YW5jZWRQcml2YWN5UHJvdGVjdGlvbnM+IG9yaWdpbmF0b3JBZHZhbmNlZFByaXZhY3lQcm90ZWN0 aW9ucygpIGNvbnN0OwogCi0gICAgYm9vbCBoYW5kbGVDb250ZXh0TWVudUV2ZW50KGNvbnN0IFdl YkNvcmU6OlBsYXRmb3JtTW91c2VFdmVudCYpOworICAgIGJvb2wgaGFuZGxlQ29udGV4dE1lbnVF dmVudChjb25zdCBXZWJDb3JlOjpQbGF0Zm9ybU1vdXNlRXZlbnQmLCBib29sIHNob3dzQ29udGV4 dE1lbnUgPSB0cnVlKTsKICAgICBib29sIGhhbmRsZU1vdXNlRXZlbnQoY29uc3QgV2ViTW91c2VF dmVudCYpOwogICAgIGJvb2wgaGFuZGxlS2V5RXZlbnQoY29uc3QgV2ViS2V5Ym9hcmRFdmVudCYp OwogcHJpdmF0ZToKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdl L1dlYlBhZ2UuY3BwIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5j cHAKaW5kZXggYjk0OWU2ZDhmZDcxLi5lZTIwYjczNThkZDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCkBAIC0zMDk5LDcgKzMwOTksNyBAQCBXZWJD b250ZXh0TWVudSogV2ViUGFnZTo6Y29udGV4dE1lbnVBdFBvaW50SW5XaW5kb3coRnJhbWVJZGVu dGlmaWVyIGZyYW1lSUQsIGNvbgogICAgIGNvcmVGcmFtZS0+dXNlcklucHV0QnJpZGdlKCkuaGFu ZGxlTW91c2VQcmVzc0V2ZW50KG1vdXNlUHJlc3NFdmVudCk7CiAgICAgYm9vbCBoYW5kbGVkID0g ZmFsc2U7CiAgICAgaWYgKFdlYkZyYW1lKiBmcmFtZSA9IFdlYlByb2Nlc3M6OnNpbmdsZXRvbigp LndlYkZyYW1lKGZyYW1lSUQpKQotICAgICAgICBoYW5kbGVkID0gZnJhbWUtPmhhbmRsZUNvbnRl eHRNZW51RXZlbnQobW91c2VQcmVzc0V2ZW50KTsKKyAgICAgICAgaGFuZGxlZCA9IGZyYW1lLT5o YW5kbGVDb250ZXh0TWVudUV2ZW50KG1vdXNlUHJlc3NFdmVudCwgZmFsc2UpOwogICAgIGF1dG8q IG1lbnUgPSBoYW5kbGVkID8gJmNvbnRleHRNZW51KCkgOiBudWxscHRyOwogICAgIFBsYXRmb3Jt TW91c2VFdmVudCBtb3VzZVJlbGVhc2VFdmVudChwb2ludCwgcG9pbnQsIFJpZ2h0QnV0dG9uLCBQ bGF0Zm9ybUV2ZW50OjpUeXBlOjpNb3VzZVJlbGVhc2VkLCAxLCB7IH0sIFdhbGxUaW1lOjpub3co KSwgV2ViQ29yZTo6Rm9yY2VBdENsaWNrLCBXZWJDb3JlOjpTeW50aGV0aWNDbGlja1R5cGU6Ok5v VGFwKTsKICAgICBjb3JlRnJhbWUtPnVzZXJJbnB1dEJyaWRnZSgpLmhhbmRsZU1vdXNlUmVsZWFz ZUV2ZW50KG1vdXNlUmVsZWFzZUV2ZW50KTsK