26048 2009-05-27 14:38:11 -0700 navigation-policy-decision-requested documentation incomplete 2009-05-28 11:39:59 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 bunk webkit-unassigned gustavo oldest_to_newest 123327 0 bunk 2009-05-27 14:38:11 -0700 I was quite surprised to hear that when returning TRUE from a navigation-policy-decision-requested handler, it is expected that webkit_policy_decision_* was called on policy_decision. Please add this information to http://webkitgtk.org/reference/webkitgtk-WebKitWebView.html#WebKitWebView-navigation-policy-decision-requested 123438 1 30741 gustavo 2009-05-28 11:17:50 -0700 Created attachment 30741 Improve policy decision signals documentation WebKit/gtk/ChangeLog | 14 ++++++++++++++ WebKit/gtk/webkit/webkitwebview.cpp | 21 +++++++++++++++++++++ 2 files changed, 35 insertions(+), 0 deletions(-) 123440 2 gustavo 2009-05-28 11:39:59 -0700 Landed as r44248, with a small addition I talked to Xan about on IRC. 30741 2009-05-28 11:17:50 -0700 2009-05-28 11:21:55 -0700 Improve policy decision signals documentation Improve-policy-decision-signals-documentation.patch text/plain 3019 gustavo N2QwMzU3NjY4YTBhZjk3ZGFkODBmMmJkYzgwNTJjNzY5YmYwNWI4OApkaWZmIC0tZ2l0IGEvV2Vi S2l0L2d0ay9DaGFuZ2VMb2cgYi9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCBkNTc2OWFjLi41 MmQ1YTMwIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL0NoYW5nZUxvZworKysgYi9XZWJLaXQvZ3Rr L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDA5LTA1LTI4ICBHdXN0YXZvIE5vcm9uaGEg U2lsdmEgIDxndXN0YXZvLm5vcm9uaGFAY29sbGFib3JhLmNvLnVrPgogCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yNjA0OAorICAgICAgICBuYXZpZ2F0aW9uLXBvbGljeS1kZWNpc2lv bi1yZXF1ZXN0ZWQgZG9jdW1lbnRhdGlvbiBpbmNvbXBsZXRlCisKKyAgICAgICAgRml4IGRvY3Vt ZW50YXRpb24gZm9yIGFsbCBwb2xpY3kgZGVjaXNpb24gcmVxdWVzdCBzaWduYWxzLCB0bworICAg ICAgICBtZW50aW9uIHRoYXQgYW4gYWN0dWFsIGRlY2lzaW9uIGlzIGV4cGVjdGVkIHdoZW4geW91 IHJldHVybiBUUlVFLAorICAgICAgICBtZWFuaW5nIHRoYXQgeW91IGhhbmRsZWQgdGhlIHNpZ25h bC4KKworICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcDoKKyAgICAgICAgKHdlYmtp dF93ZWJfdmlld19jbGFzc19pbml0KToKKworMjAwOS0wNS0yOCAgR3VzdGF2byBOb3JvbmhhIFNp bHZhICA8Z3VzdGF2by5ub3JvbmhhQGNvbGxhYm9yYS5jby51az4KKwogICAgICAgICBSZXZpZXdl ZCBieSBYYW4gTG9wZXouCiAKICAgICAgICAgRG9jdW1lbnQgY2hhbmdlcyB3b3J0aCBub3Rpbmcg Zm9yIDEuMS44LgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5j cHAgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAppbmRleCAxYTY0YzMzLi45 OGEwY2M1IDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAor KysgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcApAQCAtMTE0Niw2ICsxMTQ2 LDEzIEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld19jbGFzc19pbml0KFdlYktpdFdlYlZp ZXdDbGFzcyogd2ViVmlld0NsYXNzKQogICAgICAqIGluZm9ybWF0aW9uIGFib3V0IHRoZSBhY3Rp b24gdGhhdCBtYWRlIHRoaXMgbmV3IHdpbmRvdyB0byBiZQogICAgICAqIG9wZW5lZC4KICAgICAg KgorICAgICAqIE5vdGljZSB0aGF0IGlmIHlvdSByZXR1cm4gVFJVRSwgbWVhbmluZyB0aGF0IHlv dSBoYW5kbGVkIHRoZQorICAgICAqIHNpZ25hbCwgeW91IGFyZSBleHBlY3RlZCB0byBoYXZlIGRl Y2lkZWQgd2hhdCB0byBkbywgYnkgY2FsbGluZworICAgICAqIHdlYmtpdF93ZWJfcG9saWN5X2Rl Y2lzaW9uX2lnbm9yZSgpLAorICAgICAqIHdlYmtpdF93ZWJfcG9saWN5X2RlY2lzaW9uX3VzZSgp LCBvcgorICAgICAqIHdlYmtpdF93ZWJfcG9saWN5X2RlY2lzaW9uX2Rvd25sb2FkKCkgb24gdGhl IEBwb2xpY3lfZGVjaXNpb24KKyAgICAgKiBvYmplY3QuCisgICAgICoKICAgICAgKiBTaW5jZTog MS4xLjQKICAgICAgKi8KICAgICB3ZWJraXRfd2ViX3ZpZXdfc2lnbmFsc1tORVdfV0lORE9XX1BP TElDWV9ERUNJU0lPTl9SRVFVRVNURURdID0KQEAgLTExNzYsNiArMTE4MywxMyBAQCBzdGF0aWMg dm9pZCB3ZWJraXRfd2ViX3ZpZXdfY2xhc3NfaW5pdChXZWJLaXRXZWJWaWV3Q2xhc3MqIHdlYlZp ZXdDbGFzcykKICAgICAgKiBJZiB0aGlzIHNpZ25hbCBpcyBub3QgaGFuZGxlZCwgdGhlIGRlZmF1 bHQgYmVoYXZpb3IgaXMgdG8gYWxsb3cgdGhlCiAgICAgICogbmF2aWdhdGlvbi4KICAgICAgKgor ICAgICAqIE5vdGljZSB0aGF0IGlmIHlvdSByZXR1cm4gVFJVRSwgbWVhbmluZyB0aGF0IHlvdSBo YW5kbGVkIHRoZQorICAgICAqIHNpZ25hbCwgeW91IGFyZSBleHBlY3RlZCB0byBoYXZlIGRlY2lk ZWQgd2hhdCB0byBkbywgYnkgY2FsbGluZworICAgICAqIHdlYmtpdF93ZWJfcG9saWN5X2RlY2lz aW9uX2lnbm9yZSgpLAorICAgICAqIHdlYmtpdF93ZWJfcG9saWN5X2RlY2lzaW9uX3VzZSgpLCBv cgorICAgICAqIHdlYmtpdF93ZWJfcG9saWN5X2RlY2lzaW9uX2Rvd25sb2FkKCkgb24gdGhlIEBw b2xpY3lfZGVjaXNpb24KKyAgICAgKiBvYmplY3QuCisgICAgICoKICAgICAgKiBTaW5jZTogMS4w LjMKICAgICAgKi8KICAgICB3ZWJraXRfd2ViX3ZpZXdfc2lnbmFsc1tOQVZJR0FUSU9OX1BPTElD WV9ERUNJU0lPTl9SRVFVRVNURURdID0gZ19zaWduYWxfbmV3KCJuYXZpZ2F0aW9uLXBvbGljeS1k ZWNpc2lvbi1yZXF1ZXN0ZWQiLApAQCAtMTIwNyw2ICsxMjIxLDEzIEBAIHN0YXRpYyB2b2lkIHdl YmtpdF93ZWJfdmlld19jbGFzc19pbml0KFdlYktpdFdlYlZpZXdDbGFzcyogd2ViVmlld0NsYXNz KQogICAgICAqIHR5cGU7IGlmIFdlYktpdCBpcyBub3QgYWJsZSB0byBzaG93IHRoZSBNSU1FIHR5 cGUgbm90aGluZwogICAgICAqIGhhcHBlbnMuCiAgICAgICoKKyAgICAgKiBOb3RpY2UgdGhhdCBp ZiB5b3UgcmV0dXJuIFRSVUUsIG1lYW5pbmcgdGhhdCB5b3UgaGFuZGxlZCB0aGUKKyAgICAgKiBz aWduYWwsIHlvdSBhcmUgZXhwZWN0ZWQgdG8gaGF2ZSBkZWNpZGVkIHdoYXQgdG8gZG8sIGJ5IGNh bGxpbmcKKyAgICAgKiB3ZWJraXRfd2ViX3BvbGljeV9kZWNpc2lvbl9pZ25vcmUoKSwKKyAgICAg KiB3ZWJraXRfd2ViX3BvbGljeV9kZWNpc2lvbl91c2UoKSwgb3IKKyAgICAgKiB3ZWJraXRfd2Vi X3BvbGljeV9kZWNpc2lvbl9kb3dubG9hZCgpIG9uIHRoZSBAcG9saWN5X2RlY2lzaW9uCisgICAg ICogb2JqZWN0LgorICAgICAqCiAgICAgICogU2luY2U6IDEuMC4zCiAgICAgICovCiAgICAgd2Vi a2l0X3dlYl92aWV3X3NpZ25hbHNbTUlNRV9UWVBFX1BPTElDWV9ERUNJU0lPTl9SRVFVRVNURURd ID0gZ19zaWduYWxfbmV3KCJtaW1lLXR5cGUtcG9saWN5LWRlY2lzaW9uLXJlcXVlc3RlZCIsCg==