<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>260469</bug_id>
          
          <creation_ts>2023-08-21 08:46:36 -0700</creation_ts>
          <short_desc>[WebCrypto] We lack a check for the Ed25519 priv/pub key pair during the JWK import</short_desc>
          <delta_ts>2023-09-08 01:44:42 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>245778</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Javier Fernandez">jfernandez</reporter>
          <assigned_to name="Javier Fernandez">jfernandez</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1972385</commentid>
    <comment_count>0</comment_count>
    <who name="Javier Fernandez">jfernandez</who>
    <bug_when>2023-08-21 08:46:36 -0700</bug_when>
    <thetext>When importing an Ed25519 key pair in JWK format we need to ensure that the value in the &apos;x&apos; and &apos;d&apos; keys correspond valid key pair. We need to ensure that the public key generated from the value got from the &apos;d&apos; key matches the value imported from the &apos;x&apos; value. 

It&apos;s worth mentioning that the Web Cryptography API spec doesn&apos;t describes explicitly such test, but I think it&apos;s implied by the need of ensure the integrity of the import of key pairs in the JWK format. Additionally, there are Web Platform Tests that fail due t the lack of this check in WebKit&apos;s implementation of the Ed25519 algorithm.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1972387</commentid>
    <comment_count>1</comment_count>
    <who name="Javier Fernandez">jfernandez</who>
    <bug_when>2023-08-21 09:01:28 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/16888</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1972969</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-08-23 07:26:38 -0700</bug_when>
    <thetext>Committed 267184@main (8c9a448b18a4): &lt;https://commits.webkit.org/267184@main&gt;

Reviewed commits have been landed. Closing PR #16888 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1972970</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2023-08-23 07:27:14 -0700</bug_when>
    <thetext>&lt;rdar://problem/114322427&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>