260369 2023-08-17 16:09:22 -0700 Enable requestIdleCallback by default in Apple's ports 2023-10-03 09:10:09 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=262551 InRadar P2 Normal --- 164193 262358 1 rniwa rniwa bfulgham mcatanzaro webkit-bug-importer oldest_to_newest 1971934 0 rniwa 2023-08-17 16:09:22 -0700 Enable this feature by default on Apple ports. 1971937 1 rniwa 2023-08-17 16:14:20 -0700 Pull request: https://github.com/WebKit/WebKit/pull/16813 1971954 2 ews-feeder 2023-08-17 18:01:28 -0700 Committed 267023@main (e225f383b875): <https://commits.webkit.org/267023@main> Reviewed commits have been landed. Closing PR #16813 and removing active labels. 1971955 3 webkit-bug-importer 2023-08-17 18:02:16 -0700 <rdar://problem/114057284> 1972031 4 mcatanzaro 2023-08-18 06:07:22 -0700 Isn't this needed everywhere? Is there something wrong with the implementation on other ports? 1972070 5 bfulgham 2023-08-18 09:47:48 -0700 (In reply to Michael Catanzaro from comment #4) > Isn't this needed everywhere? Is there something wrong with the > implementation on other ports? The current code is specific to the CoreFoundation runloop implementation. Similar changes for GTK's run loop API would be needed on that platform (and likewise for Windows). 1972237 6 mcatanzaro 2023-08-19 08:09:33 -0700 Can you give me some pointers to what needs implemented, please? I skimmed through all recent commits looking for platform-specific code and didn't find anything. And since the implementation is built unconditionally, we already know it doesn't use any platform-specific methods of RunLoop. GTK/WPE will have an issue where idle callbacks will be scheduled at too-high priority, which will need to be fixed, but that shouldn't stop the feature from working. 1972249 7 rniwa 2023-08-19 12:57:55 -0700 (In reply to Michael Catanzaro from comment #6) > Can you give me some pointers to what needs implemented, please? I skimmed > through all recent commits looking for platform-specific code and didn't > find anything. And since the implementation is built unconditionally, we > already know it doesn't use any platform-specific methods of RunLoop. > > GTK/WPE will have an issue where idle callbacks will be scheduled at > too-high priority, which will need to be fixed, but that shouldn't stop the > feature from working. You need to implement these functions: RunLoopObserver::schedule, RunLoopObserver::invalidate, and RunLoopObserver::isScheduled(): https://github.com/WebKit/WebKit/blob/main/Source/WebCore/platform/RunLoopObserver.cpp 1972454 8 mcatanzaro 2023-08-21 12:27:11 -0700 Thanks! Unfortunately this looks hard, so I've created bug #260478 to track it.