26035 2009-05-26 17:57:10 -0700 Make ImageSource::frameHasAlphaAtIndex() return false for JPEGs with CG 2009-05-26 22:20:41 -0700 1 1 1 Unclassified WebKit Images 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 zwarich zwarich oldest_to_newest 123216 0 zwarich 2009-05-26 17:57:10 -0700 There is a FIXME in the code to return false for JPEG and other image formats that don't support transparency. JPEG is the most common of these, so we should simply do this optimization. 123217 1 zwarich 2009-05-26 17:57:35 -0700 <rdar://problem/6924087> 123220 2 30691 zwarich 2009-05-26 19:20:04 -0700 Created attachment 30691 Proposed patch 123230 3 30691 mjs 2009-05-26 21:37:30 -0700 Comment on attachment 30691 Proposed patch r=me 123231 4 zwarich 2009-05-26 22:20:41 -0700 Landed in r44176. 30691 2009-05-26 19:20:04 -0700 2009-05-26 21:37:30 -0700 Proposed patch jpeg.diff text/plain 1844 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQ0MTcw KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDUt MjYgIENhbWVyb24gWndhcmljaCAgPHp3YXJpY2hAYXBwbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAyNjAzNTogTWFrZSBJbWFnZVNv dXJjZTo6ZnJhbWVIYXNBbHBoYUF0SW5kZXgoKSByZXR1cm4gZmFsc2UgZm9yIEpQRUdzIHdpdGgg Q0cKKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjAz NT4KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY5MjQwODc+CisKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9jZy9JbWFnZVNvdXJjZUNHLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkltYWdl U291cmNlOjpmcmFtZUhhc0FscGhhQXRJbmRleCk6IHJldHVybiBmYWxzZSBpZiB0aGUgaW1hZ2UK KyAgICAgICAgaXMgSlBFRyBvciBpZiBtX2RlY29kZXIgaXMgbnVsbC4KKwogMjAwOS0wNS0yNiAg QW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IERhbiBCZXJuc3RlaW4uCkluZGV4OiBwbGF0Zm9ybS9ncmFwaGljcy9jZy9JbWFnZVNvdXJj ZUNHLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBwbGF0Zm9ybS9ncmFwaGljcy9jZy9JbWFnZVNvdXJjZUNH LmNwcAkocmV2aXNpb24gNDQxNzApCisrKyBwbGF0Zm9ybS9ncmFwaGljcy9jZy9JbWFnZVNvdXJj ZUNHLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjQyLDkgKzI0MiwxNiBAQCBmbG9hdCBJbWFnZVNv dXJjZTo6ZnJhbWVEdXJhdGlvbkF0SW5kZXgoCiAKIGJvb2wgSW1hZ2VTb3VyY2U6OmZyYW1lSGFz QWxwaGFBdEluZGV4KHNpemVfdCkKIHsKLSAgICAvLyBNaWdodCBiZSBpbnRlcmVzdGluZyB0byBk byB0aGlzIG9wdGltaXphdGlvbiBvbiBNYWMgc29tZSBkYXksIGJ1dCBmb3Igbm93IHdlJ3JlIGp1 c3QgdXNpbmcgdGhpcwotICAgIC8vIGZvciB0aGUgQ2Fpcm8gc291cmNlLCBzaW5jZSBpdCB1c2Vz IG91ciBkZWNvZGVycywgYW5kIG91ciBkZWNvZGVycyBjYW4gYW5zd2VyIHRoaXMgcXVlc3Rpb24u Ci0gICAgLy8gRklYTUU6IENvdWxkIHJldHVybiBmYWxzZSBmb3IgSlBFRyBhbmQgb3RoZXIgbm9u LXRyYW5zcGFyZW50IGltYWdlIGZvcm1hdHMuCisgICAgaWYgKCFtX2RlY29kZXIpCisgICAgICAg IHJldHVybiBmYWxzZTsKKworICAgIENGU3RyaW5nUmVmIGltYWdlVHlwZSA9IENHSW1hZ2VTb3Vy Y2VHZXRUeXBlKG1fZGVjb2Rlcik7CisKKyAgICAvLyBSZXR1cm4gZmFsc2UgZm9yIEpQRUcuCisg ICAgaWYgKCFpbWFnZVR5cGUgfHwgQ0ZFcXVhbChpbWFnZVR5cGUsIENGU1RSKCJwdWJsaWMuanBl ZyIpKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgLy8gRklYTUU6IENvdWxkIHJldHVy biBmYWxzZSBmb3Igb3RoZXIgbm9uLXRyYW5zcGFyZW50IGltYWdlIGZvcm1hdHMuCiAgICAgLy8g RklYTUU6IENvdWxkIG1heWJlIHJldHVybiBmYWxzZSBmb3IgYSBHSUYgRnJhbWUgaWYgd2UgaGF2 ZSBlbm91Z2ggaW5mbyBpbiB0aGUgR0lGIHByb3BlcnRpZXMgZGljdGlvbmFyeQogICAgIC8vIHRv IGRldGVybWluZSB3aGV0aGVyIG9yIG5vdCBhIHRyYW5zcGFyZW50IGNvbG9yIHdhcyBkZWZpbmVk LgogICAgIHJldHVybiB0cnVlOwo=