260303 2023-08-16 14:28:05 -0700 os_log_set_hook return value is improperly ignored 2023-08-17 11:22:16 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham webkit-bug-importer oldest_to_newest 1971619 0 bfulgham 2023-08-16 14:28:05 -0700 In Bug 253342 we adopted `os_log_set_hook` so that we could relay logging information from the WebContent process to the Network process to add to the logging system. The documentation for this method says: * os_log_set_hook returns the previously registered hook or NULL * when this function is first called. As a client, if you register a hook and the * return value is not NULL then it is your responsibility to chain the * previous hook into the new hook so that both are invoked. Any previously registered hook is unlikely to be able to interact with `logd`, since we are sandboxed, but perhaps there are other side-effects we want to retain. To comply with the API design, we should invoke any preregistered hooks before calling our own logic. <rdar://112032774> 1971631 1 bfulgham 2023-08-16 14:41:18 -0700 Pull request: https://github.com/WebKit/WebKit/pull/16754 1971875 2 ews-feeder 2023-08-17 11:22:15 -0700 Committed 267007@main (3372a68e3655): <https://commits.webkit.org/267007@main> Reviewed commits have been landed. Closing PR #16754 and removing active labels.