26026 2009-05-26 12:51:49 -0700 infinite loop when using keyboard in select popups 2009-06-01 00:43:41 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 tony abarth abarth oldest_to_newest 123166 0 tony 2009-05-26 12:51:49 -0700 To repro, open a select drop down, use the arrow keys, then close the select. This triggers an infinite loop in PopupMenuChromium.cpp which crashes once we overflow the stack: WebCore::PopupMenu::updateFromElement() Line 1177 WebCore::RenderMenuList::updateFromElement() Line 176 WebCore::HTMLSelectElement::setSelectedIndex(...) Line 183 WebCore::RenderMenuList::valueChanged(...) Line 307 WebCore::PopupListBox::updateFromElement() Line 1026 WebCore::PopupMenu::updateFromElement() Line 1177 One line fix coming... 123167 1 30676 tony 2009-05-26 12:55:24 -0700 Created attachment 30676 v1 Make sure to set the flag so we don't recurse. 123796 2 abarth 2009-06-01 00:36:25 -0700 Will land. 123799 3 abarth 2009-06-01 00:41:56 -0700 In the future, please base your patches in the main WebKit directory so we can use the awesomesauce WebKitTools. 123800 4 abarth 2009-06-01 00:43:41 -0700 Sending WebCore/ChangeLog Sending WebCore/platform/chromium/PopupMenuChromium.cpp Transmitting file data .. Committed revision 44312. 30676 2009-05-26 12:55:24 -0700 2009-05-29 10:12:16 -0700 v1 popups-26026.diff text/plain 1415 tony SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQ0MTU1 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMDUt MjYgIHRvbnkgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjYwMjYKKyAgICAgICAgRml4IGFuIGluZmluaXRlIGxvb3Agd2hlbiB1c2luZyB0aGUg a2V5Ym9hcmQgaW4gQ2hyb21pdW0gc2VsZWN0CisgICAgICAgIHBvcHVwcy4KKworICAgICAgICBO b3QgdGVzdGFibGUgc2luY2UgaXQgaW52b2x2ZXMgc2VuZGluZyBhIGtleWJvYXJkIGV2ZW50IHRv CisgICAgICAgIHRoZSBwb3B1cCwgd2hpY2ggaXMgbm90IHBvc3NpYmxlIChldmVudFNlbmRlciBz ZW5kcyB0aGUga2V5CisgICAgICAgIGV2ZW50cyB0aHJvdWdoIHdlYnZpZXcsIHdlIHdhbnQgdG8g Z28gdGhyb3VnaCB0aGUgd2Vid2lkZ2V0KS4KKworICAgICAgICAqIC4uLy4uLy4uL2Nocm9taXVt L1BvcHVwTWVudUNocm9taXVtLmNwcDoKKwogMjAwOS0wNS0yNiAgRGltaXRyaSBHbGF6a292ICA8 ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hY2llaiBTdGFj aG93aWFrLgpJbmRleDogcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIHBsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcAkocmV2 aXNpb24gNDQxNDMpCisrKyBwbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTEwMjIsOCArMTAyMiw4IEBAIHZvaWQgUG9wdXBMaXN0Qm94Ojp1 cGRhdGVGcm9tRWxlbWVudCgpCiAgICAgLy8gbW91c2UgdG8gZ2V0IGF3YXkgZnJvbSB0aGUgc2Vs ZWN0IGJveC4gSW4gdGhhdCBjYXNlLCB1cGRhdGVGcm9tRWxlbWVudAogICAgIC8vIGlzIGNhbGxl ZCBiZWZvcmUgYWJhbmRvbiwgd2hpY2ggY2F1c2VzIGRpc2NhcmRpbmcgb2YgdGhlIHNlbGVjdCBy ZXN1bHQuICAgIAogICAgIGlmIChtX3dpbGxBY2NlcHRPbkFiYW5kb24pIHsKLSAgICAgICAgbV9w b3B1cENsaWVudC0+dmFsdWVDaGFuZ2VkKG1fc2VsZWN0ZWRJbmRleCk7CiAgICAgICAgIG1fd2ls bEFjY2VwdE9uQWJhbmRvbiA9IGZhbHNlOworICAgICAgICBtX3BvcHVwQ2xpZW50LT52YWx1ZUNo YW5nZWQobV9zZWxlY3RlZEluZGV4KTsKICAgICB9CiAKICAgICBjbGVhcigpOwo=