260255 2023-08-16 04:37:58 -0700 REGRESSION (262875@main): animation of `rotate` property doesn't work if there's a `scale` 2023-10-18 00:24:39 -0700 1 1 1 Unclassified WebKit Animations Safari 17 Unspecified Unspecified RESOLVED FIXED https://github.com/web-platform-tests/wpt/pull/42577 InRadar P2 Normal --- 1 hasather+webkitbugs graouts ahmad.saleem792 dino graouts graouts simon.fraser webkit-bug-importer zalan oldest_to_newest 1971479 0 467288 hasather+webkitbugs 2023-08-16 04:37:58 -0700 Created attachment 467288 Animation bug See attached file. The two animations should look the same. They do in all common browsers, including Safari 16, but no rotation is happening in Safari 17. 1971484 1 467289 hasather+webkitbugs 2023-08-16 06:00:16 -0700 Created attachment 467289 Bug with filter filter also disabled rotation, see new TC 1971617 2 ahmad.saleem792 2023-08-16 14:08:38 -0700 I am able to reproduce this bug on WebKit ToT (266957@main) as well and blurred does not flip like non-filtered text. 1971704 3 webkit-bug-importer 2023-08-16 18:14:33 -0700 <rdar://problem/113999490> 1972435 4 simon.fraser 2023-08-21 11:09:51 -0700 Regression range: https://github.com/WebKit/WebKit/compare/a465a8a38ab52cfd57d2c2e710d72ea6f53d9c81...2160e724153a80c80fb6d42b05809ff14bcd930f 1985313 5 graouts 2023-10-16 06:48:56 -0700 The issue is that the animation here has two transform-related properties per keyframe: scale and rotate. In RenderLayerBacking::startAnimation() we call GraphicsLayerCA::addAnimation() twice as a result, once for scale and once for rotate, but in both cases we use the same animation name. Then in GraphicsLayerCA::createTransformAnimationsFromKeyframes() we will remove any animation with that same name which means only one of the two properties will end up being animated. We need to find a way to keep the notion that these GraphicsLayerCA animations were generated from the same KeyframeEffect but also have a way to distinguish such animations when adding and removing them. 1985530 6 graouts 2023-10-17 01:44:52 -0700 Pull request: https://github.com/WebKit/WebKit/pull/19157 1985532 7 graouts 2023-10-17 01:46:21 -0700 Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/42577 1985809 8 ews-feeder 2023-10-18 00:24:37 -0700 Committed 269453@main (add5da728e89): <https://commits.webkit.org/269453@main> Reviewed commits have been landed. Closing PR #19157 and removing active labels. 467288 2023-08-16 04:37:58 -0700 2023-08-16 04:37:58 -0700 Animation bug animation-bug.html text/html 595 hasather+webkitbugs PCFET0NUWVBFIGh0bWw+Cgo8c3R5bGU+CiAgc3BhbiB7CiAgICBkaXNwbGF5OiBpbmxpbmUtYmxv Y2s7CiAgICBmb250LXNpemU6IDEwMHB4OwogIH0KPC9zdHlsZT4KCjxkaXY+PHNwYW4gaWQ9ImEi PnRlc3Q8L3NwYW4+PC9kaXY+CjxkaXY+PHNwYW4gaWQ9ImIiPnRlc3Q8L3NwYW4+PC9kaXY+Cgo8 c2NyaXB0PgogIGEuYW5pbWF0ZSgKICAgIFsKICAgICAgewogICAgICAgIHRyYW5zZm9ybTogInNj YWxlKC41KSByb3RhdGVYKDBkZWcpIiwKICAgICAgfSwKICAgICAgewogICAgICAgIHRyYW5zZm9y bTogInNjYWxlKDEpIHJvdGF0ZVgoLTkwZGVnKSIsCiAgICAgIH0sCiAgICBdLAogICAgeyBkdXJh dGlvbjogMTAwMCwgaXRlcmF0aW9uczogSW5maW5pdHkgfQogICk7CgogIGIuYW5pbWF0ZSgKICAg IFsKICAgICAgewogICAgICAgIHNjYWxlOiAwLjUsCiAgICAgICAgcm90YXRlOiAieCAwZGVnIiwK ICAgICAgfSwKICAgICAgewogICAgICAgIHNjYWxlOiAxLAogICAgICAgIHJvdGF0ZTogInggLTkw ZGVnIiwKICAgICAgfSwKICAgIF0sCiAgICB7IGR1cmF0aW9uOiAxMDAwLCBpdGVyYXRpb25zOiBJ bmZpbml0eSB9CiAgKTsKPC9zY3JpcHQ+Cg== 467289 2023-08-16 06:00:16 -0700 2023-08-16 06:00:59 -0700 Bug with filter file_260255.txt text/html 644 hasather+webkitbugs PCFET0NUWVBFIGh0bWw+DQoNCjxzdHlsZT4NCiAgc3BhbiB7DQogICAgZGlzcGxheTogaW5saW5l LWJsb2NrOw0KICAgIGZvbnQtc2l6ZTogMTAwcHg7DQogIH0NCjwvc3R5bGU+DQoNCjxkaXY+PHNw YW4gaWQ9ImEiPnRlc3Q8L3NwYW4+PC9kaXY+DQo8ZGl2PjxzcGFuIGlkPSJiIj50ZXN0PC9zcGFu PjwvZGl2Pg0KDQo8c2NyaXB0Pg0KICBhLmFuaW1hdGUoDQogICAgWw0KICAgICAgew0KICAgICAg ICB0cmFuc2Zvcm06ICJyb3RhdGVYKDBkZWcpIg0KICAgICAgfSwNCiAgICAgIHsNCiAgICAgICAg dHJhbnNmb3JtOiAicm90YXRlWCgtOTBkZWcpIg0KICAgICAgfQ0KICAgIF0sDQogICAgeyBkdXJh dGlvbjogMTAwMCwgaXRlcmF0aW9uczogSW5maW5pdHkgfQ0KICApOw0KDQogIGIuYW5pbWF0ZSgN CiAgICBbDQogICAgICB7DQogICAgICAgIGZpbHRlcjogIm5vbmUiLA0KICAgICAgICB0cmFuc2Zv cm06ICJyb3RhdGVYKDBkZWcpIg0KICAgICAgfSwNCiAgICAgIHsNCiAgICAgICAgZmlsdGVyOiAi Ymx1cig1cHgpIiwNCiAgICAgICAgdHJhbnNmb3JtOiAicm90YXRlWCgtOTBkZWcpIg0KICAgICAg fQ0KICAgIF0sDQogICAgeyBkdXJhdGlvbjogMTAwMCwgaXRlcmF0aW9uczogSW5maW5pdHkgfQ0K ICApOw0KPC9zY3JpcHQ+DQo=