<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>260218</bug_id>
          
          <creation_ts>2023-08-15 13:14:06 -0700</creation_ts>
          <short_desc>[CMake] Generate a usable compile_commands.json</short_desc>
          <delta_ts>2023-08-28 21:26:09 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CMake</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=260769</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=260841</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Patrick Griffis">pgriffis</reporter>
          <assigned_to name="Patrick Griffis">pgriffis</assigned_to>
          <cc>fujii</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1971362</commentid>
    <comment_count>0</comment_count>
    <who name="Patrick Griffis">pgriffis</who>
    <bug_when>2023-08-15 13:14:06 -0700</bug_when>
    <thetext>When using unified builds CMake generates a compile_commands.json that isn&apos;t useful by many tools as it lacks much of the sources.

This adds a script to expand UnifiedSources into the full list of sources. It outputs it to webkit_compile_commands.json.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1971363</commentid>
    <comment_count>1</comment_count>
    <who name="Patrick Griffis">pgriffis</who>
    <bug_when>2023-08-15 13:14:52 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/16718</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1971495</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-08-16 08:23:59 -0700</bug_when>
    <thetext>Committed 266947@main (5c9dd47913bc): &lt;https://commits.webkit.org/266947@main&gt;

Reviewed commits have been landed. Closing PR #16718 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1974130</commentid>
    <comment_count>3</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2023-08-28 21:26:09 -0700</bug_when>
    <thetext>rewrite-compile-commands outputs annoying messages.
Filed: Bug 260841 – [CMake] rewrite-compile-commands reports a lot of warning messages &quot;Failed to find ...&quot;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>