26018 2009-05-26 03:02:24 -0700 Fix behavior of the Element View for double clicking the element outline tree 2009-05-31 19:41:13 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) PC Windows Vista RESOLVED FIXED P2 Normal --- 0 tyoshino levin oldest_to_newest 123112 0 tyoshino 2009-05-26 03:02:24 -0700 Fix behavior of the Element View of the Web Inspector for double clicking the element outline tree. Double clicking the element outline tree should 1) on attribute: enter attribute editing mode 2) on text: enter text editing mode 3) otherwise: change root node to the parent element of double clicked element. Now, 3) is broken. For example, clicking <html> clears the element outline view. rootDOMNode should be updated to this.representedObject.parentNode, not this.parent.representedObject which is parent inside the element outline tree itself. 123113 1 30665 tyoshino 2009-05-26 03:04:39 -0700 Created attachment 30665 Proposed fix for 26018 123138 2 30665 darin 2009-05-26 09:08:27 -0700 Comment on attachment 30665 Proposed fix for 26018 r=me 123229 3 tyoshino 2009-05-26 21:33:50 -0700 Thank you for review. Could you please land this? I don't have commit access. 123564 4 levin 2009-05-29 11:01:57 -0700 Assign to levin for landing. 123639 5 levin 2009-05-29 16:06:04 -0700 Committed as http://trac.webkit.org/changeset/44280 123772 6 tyoshino 2009-05-31 19:41:13 -0700 Thank you all for reviewing and landing. 30665 2009-05-26 03:04:39 -0700 2009-05-26 09:08:27 -0700 Proposed fix for 26018 26018.patch text/plain 1753 tyoshino SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQ0MTQ4 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjggQEAKKzIwMDktMDUt MjYgIFRha2VzaGkgWW9zaGlubyAgPHR5b3NoaW5vQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTI2MDE4CisKKyAgICAgICAgRml4IGJlaGF2aW9yIG9mIHRoZSBF bGVtZW50IFZpZXcgb2YgdGhlIFdlYiBJbnNwZWN0b3IgZm9yIGRvdWJsZQorICAgICAgICBjbGlj a2luZyB0aGUgZWxlbWVudCBvdXRsaW5lIHRyZWUuCisKKyAgICAgICAgRG91YmxlIGNsaWNraW5n IHRoZSBlbGVtZW50IG91dGxpbmUgdHJlZSBzaG91bGQKKyAgICAgICAgMSkgb24gYXR0cmlidXRl OiBlbnRlciBhdHRyaWJ1dGUgZWRpdGluZyBtb2RlCisgICAgICAgIDIpIG9uIHRleHQ6IGVudGVy IHRleHQgZWRpdGluZyBtb2RlCisgICAgICAgIDMpIG90aGVyd2lzZTogY2hhbmdlIHJvb3Qgbm9k ZSB0byB0aGUgcGFyZW50IGVsZW1lbnQgb2YgZG91YmxlIGNsaWNrZWQKKyAgICAgICAgICAgZWxl bWVudC4KKworICAgICAgICBOb3csIDMpIGlzIGJyb2tlbi4gRm9yIGV4YW1wbGUsIGNsaWNraW5n IDxodG1sPiBjbGVhcnMgdGhlIGVsZW1lbnQKKyAgICAgICAgb3V0bGluZSB2aWV3LgorCisgICAg ICAgIHJvb3RET01Ob2RlIHNob3VsZCBiZSB1cGRhdGVkIHRvIHRoaXMucmVwcmVzZW50ZWRPYmpl Y3QucGFyZW50Tm9kZSwgbm90CisgICAgICAgIHRoaXMucGFyZW50LnJlcHJlc2VudGVkT2JqZWN0 IHdoaWNoIGlzIHBhcmVudCBpbnNpZGUgdGhlIGVsZW1lbnQKKyAgICAgICAgb3V0bGluZSB0cmVl IGl0c2VsZi4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0 bGluZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5FbGVtZW50c1RyZWVFbGVtZW50LnByb3Rv dHlwZS5vbmRibGNsaWNrKToKKwogMjAwOS0wNS0yNSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFw QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBp bnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanMKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g aW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpzCShyZXZpc2lvbiA0NDE0 MykKKysrIGluc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcwkod29ya2lu ZyBjb3B5KQpAQCAtNDg3LDcgKzQ4Nyw3IEBACiAgICAgICAgICAgICByZXR1cm47CiAKICAgICAg ICAgaWYgKHRoaXMudHJlZU91dGxpbmUucGFuZWwpIHsKLSAgICAgICAgICAgIHRoaXMudHJlZU91 dGxpbmUucm9vdERPTU5vZGUgPSB0aGlzLnBhcmVudC5yZXByZXNlbnRlZE9iamVjdDsKKyAgICAg ICAgICAgIHRoaXMudHJlZU91dGxpbmUucm9vdERPTU5vZGUgPSB0aGlzLnJlcHJlc2VudGVkT2Jq ZWN0LnBhcmVudE5vZGU7CiAgICAgICAgICAgICB0aGlzLnRyZWVPdXRsaW5lLmZvY3VzZWRET01O b2RlID0gdGhpcy5yZXByZXNlbnRlZE9iamVjdDsKICAgICAgICAgfQogCg==