26015 2009-05-25 19:02:30 -0700 [Qt] Single-threaded QtWebKit configuration 2009-06-11 10:58:27 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 laszlo.gombos webkit-unassigned ariya.hidayat oldest_to_newest 123088 0 laszlo.gombos 2009-05-25 19:02:30 -0700 The following patch introduces a new configuration option (ENABLE_NO_THREADING) for the Qt port to build single-threaded WebKit. The proposed change impacts only the build system. The single-threaded option builds on top of existing WebKit configuration options. The motivation of this change is to maintain a single-threaded QtWebKit option for embedded systems where creating threads dynamically is not desired. 123093 1 30662 laszlo.gombos 2009-05-25 19:46:38 -0700 Created attachment 30662 Proposed patch. 123169 2 mrowe 2009-05-26 12:57:51 -0700 ENABLE_NO_THREADING is an awkward name. Why not DISABLE_THREADING, or set ENABLE_THREADING=0? 123215 3 laszlo.gombos 2009-05-26 17:29:59 -0700 (In reply to comment #2) > ENABLE_NO_THREADING is an awkward name. Why not DISABLE_THREADING, or set > ENABLE_THREADING=0? The guidelines I set to myself - stay consistent with the ENABLE_XXX naming schema - the build should not change if the newly introduced flag is not set to minimize the impact of this less frequently used configuration. How about ENABLE_SINGLE_THREADED ? 123864 4 30838 laszlo.gombos 2009-06-01 11:59:17 -0700 Created attachment 30838 Updated the patch to use ENABLE_SINGLE_THREADED as the guard. 124285 5 ariya.hidayat 2009-06-04 04:04:31 -0700 Landed in 44411 124613 6 31026 laszlo.gombos 2009-06-05 20:23:32 -0700 Created attachment 31026 Fix compilation warnings in ThreadingNone.cpp It seems to me that changes to ThreadingNone.cpp has not been committed as part of 44411; created a new patch just for those changes. 124614 7 laszlo.gombos 2009-06-05 20:26:00 -0700 Reopen as part of https://bugs.webkit.org/attachment.cgi?id=30838 has not been committed as part of 44411. 124743 8 ariya.hidayat 2009-06-08 02:41:12 -0700 I prefer that we use UNUSED_PARAM macro. The argument names are always useful to help understanding the function. 124808 9 31062 laszlo.gombos 2009-06-08 14:15:11 -0700 Created attachment 31062 Use UNUSED_PARAM macro for unused arguments as Ariya suggested. 124941 10 zecke 2009-06-09 07:51:51 -0700 (In reply to comment #8) > I prefer that we use UNUSED_PARAM macro. The argument names are always useful > to help understanding the function. Hehe, it is a matter of taste. In general we omit parameter names when it is obvious. I would argue that for a *None file the parameter names are not relevant at all and should be omitted. Something funny I stumbled across is in in UnusedParam.h: /* don't use this for C++, it should only be used in plain C files or ObjC methods, where leaving off the parameter name is not allowed. */ #define UNUSED_PARAM(x) (void)x we obviously don't stick to that rule... 124969 11 laszlo.gombos 2009-06-09 10:41:08 -0700 I share Zecke's opinion for *None files so I canceled the review for https://bugs.webkit.org/attachment.cgi?id=31062. 125330 12 ariya.hidayat 2009-06-11 10:35:26 -0700 Closing it, since the issue is settled 125334 13 laszlo.gombos 2009-06-11 10:41:54 -0700 (In reply to comment #12) > Closing it, since the issue is settled Ariya, I think we should still commit https://bugs.webkit.org/attachment.cgi?id=31026 before closing this bug. Change the status back to REOPEN. 125343 14 ariya.hidayat 2009-06-11 10:58:27 -0700 Oops, sorry. I didn't read it carefully. Landed in r44607 http://trac.webkit.org/changeset/44607 30662 2009-05-25 19:46:38 -0700 2009-06-01 11:59:17 -0700 Proposed patch. patch_26015.txt text/plain 4194 laszlo.gombos SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ0MTQzKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMDUtMjUgIExhc3psbyBH b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gU2luZ2xlLXRocmVhZGVkIFF0V2ViS2l0 IGNvbmZpZ3VyYXRpb24KKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yNjAxNT4KKworICAgICAgICAqIEphdmFTY3JpcHRDb3JlLnByaTogVXNlIFRocmVh ZGluZ05vbmUuY3BwIGluc3RlYWQgb2YKKyAgICAgICAgVGhyZWFkaW5nUXQuY3BwIGFuZCBtYWtl IHN1cmUgRU5BQkxFX0pTQ19NVUxUSVBMRV9USFJFQURTIGlzIHR1cm5lZCBvZmYgCisgICAgICAg IHdoZW4gRU5BQkxFX05PX1RIUkVBRElORyBpcyB0dW5lZCBvbgorICAgICAgICAqIHd0Zi9UaHJl YWRpbmdOb25lLmNwcDoKKyAgICAgICAgKFdURjo6VGhyZWFkQ29uZGl0aW9uOjp3YWl0KTogRml4 IGNvbXBpbGF0aW9uIHdhcm5pbmcuCisgICAgICAgIChXVEY6OlRocmVhZENvbmRpdGlvbjo6dGlt ZWRXYWl0KTogRGl0dG8uCisKIDIwMDktMDUtMjUgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYWNpZWogU3RhY2hvd2lhay4KSW5kZXg6IEph dmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnByaQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9KYXZhU2NyaXB0Q29yZS5wcmkJKHJldmlzaW9uIDQ0MTE1KQorKysgSmF2YVNjcmlwdENv cmUvSmF2YVNjcmlwdENvcmUucHJpCSh3b3JraW5nIGNvcHkpCkBAIC0yMjEsOSArMjIxLDE1IEBA IFNPVVJDRVMgKz0gXAogICAgIHByb2ZpbGVyL1RyZWVQcm9maWxlLmNwcCBcCiAgICAgd3RmL0Zh c3RNYWxsb2MuY3BwIFwKICAgICB3dGYvVGhyZWFkaW5nLmNwcCBcCi0gICAgd3RmL3F0L1RocmVh ZGluZ1F0LmNwcCBcCiAgICAgd3RmL3F0L01haW5UaHJlYWRRdC5jcHAKIAorIWNvbnRhaW5zKERF RklORVMsIEVOQUJMRV9OT19USFJFQURJTkc9MSkgeworICAgIFNPVVJDRVMgKz0gd3RmL3F0L1Ro cmVhZGluZ1F0LmNwcAorfSBlbHNlIHsgCisgICAgREVGSU5FUyArPSBFTkFCTEVfSlNDX01VTFRJ UExFX1RIUkVBRFM9MAorICAgIFNPVVJDRVMgKz0gd3RmL1RocmVhZGluZ05vbmUuY3BwIAorfQor CiAjIEdFTkVSQVRPUiAxLUE6IExVVCBjcmVhdG9yCiBsdXQub3V0cHV0ID0gJCRHRU5FUkFURURf U09VUkNFU19ESVIvJHtRTUFLRV9GSUxFX0JBU0V9Lmx1dC5oCiBsdXQuY29tbWFuZHMgPSBwZXJs ICQkUFdEL2NyZWF0ZV9oYXNoX3RhYmxlICR7UU1BS0VfRklMRV9OQU1FfSAtaSA+ICR7UU1BS0Vf RklMRV9PVVR9CkluZGV4OiBKYXZhU2NyaXB0Q29yZS93dGYvVGhyZWFkaW5nTm9uZS5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZGluZ05vbmUuY3BwCShyZXZpc2lv biA0NDExNSkKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRpbmdOb25lLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNDgsOCArNDgsOCBAQCB2b2lkIE11dGV4Ojp1bmxvY2soKSB7IH0KIAogVGhy ZWFkQ29uZGl0aW9uOjpUaHJlYWRDb25kaXRpb24oKSB7IH0KIFRocmVhZENvbmRpdGlvbjo6flRo cmVhZENvbmRpdGlvbigpIHsgfQotdm9pZCBUaHJlYWRDb25kaXRpb246OndhaXQoTXV0ZXgmIG11 dGV4KSB7IH0KLWJvb2wgVGhyZWFkQ29uZGl0aW9uOjp0aW1lZFdhaXQoTXV0ZXgmIG11dGV4LCBk b3VibGUgYWJzb2x1dGVUaW1lKSB7IHJldHVybiBmYWxzZTsgfQordm9pZCBUaHJlYWRDb25kaXRp b246OndhaXQoTXV0ZXgmKSB7IH0KK2Jvb2wgVGhyZWFkQ29uZGl0aW9uOjp0aW1lZFdhaXQoTXV0 ZXgmLCBkb3VibGUpIHsgcmV0dXJuIGZhbHNlOyB9CiB2b2lkIFRocmVhZENvbmRpdGlvbjo6c2ln bmFsKCkgeyB9CiB2b2lkIFRocmVhZENvbmRpdGlvbjo6YnJvYWRjYXN0KCkgeyB9CiAKSW5kZXg6 IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9nCShyZXZp c2lvbiA0NDE0MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTkgQEAKKzIwMDktMDUtMjUgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjAxNQorCisgICAgICAg IFtRdF0gU2luZ2xlLXRocmVhZGVkIFF0V2ViS2l0IGNvbmZpZ3VyYXRpb24KKworICAgICAgICBU dXJuIG9mZiBEYXRhYmFzZSwgRE9NIHN0b3JhZ2UsIGljb24gZGF0YWJhc2UgYW5kIFdlYiBXb3Jr ZXJzIHN1cHBvcnQKKyAgICAgICAgd2hlbiBFTkFCTEVfTk9fVEhSRUFESU5HIGlzIHR1cm5lZCBv bi4KKworICAgICAgICBTZXQgU1FMSVRFX1RIUkVBRFNBRkUgdG8gZmFsc2UgdG8gdHVybiBvZmYg U1FMaXRlIG11dGV4ZXMKKyAgICAgICAgd2hlbiBFTkFCTEVfTk9fVEhSRUFESU5HIGlzIHR1cm5l ZCBvbi4KKworICAgICAgICAqIFdlYkNvcmUucHJvOgorCiAyMDA5LTA1LTI1ICBBbmRlcnMgQ2Fy bHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdl aW5pZy4KSW5kZXg6IFdlYkNvcmUvV2ViQ29yZS5wcm8KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9X ZWJDb3JlLnBybwkocmV2aXNpb24gNDQxMTUpCisrKyBXZWJDb3JlL1dlYkNvcmUucHJvCSh3b3Jr aW5nIGNvcHkpCkBAIC04MSw2ICs4MSwxMCBAQCBDT05GSUcoUVRESVJfYnVpbGQpIHsKIAogIyBP cHRpb25hbCBjb21wb25lbnRzIChsb29rIGZvciBkZWZzIGluIGNvbmZpZy5oIGFuZCBpbmNsdWRl ZCBmaWxlcyEpCiAKK2NvbnRhaW5zKERFRklORVMsIEVOQUJMRV9OT19USFJFQURJTkc9MSkgewor ICAgIERFRklORVMrPUVOQUJMRV9EQVRBQkFTRT0wIEVOQUJMRV9ET01fU1RPUkFHRT0wIEVOQUJM RV9JQ09OREFUQUJBU0U9MCBFTkFCTEVfV09SS0VSUz0wCit9CisKICMgdHVybiBvZmYgU1FMSVRF IHN1cHBvcnQgaWYgd2UgZG8gbm90IGhhdmUgc3FsaXRlMyBhdmFpbGFibGUKICFDT05GSUcoUVRE SVJfYnVpbGQpOndpbjMyLSo6IWV4aXN0cyggJCR7U1FMSVRFM1NSQ0RJUn0vc3FsaXRlMy5jICk6 IERFRklORVMgKz0gRU5BQkxFX1NRTElURT0wIEVOQUJMRV9EQVRBQkFTRT0wIEVOQUJMRV9JQ09O REFUQUJBU0U9MCBFTkFCTEVfT0ZGTElORV9XRUJfQVBQTElDQVRJT05TPTAgRU5BQkxFX0RPTV9T VE9SQUdFPTAKIApAQCAtMTI2NCw2ICsxMjY4LDkgQEAgY29udGFpbnMoREVGSU5FUywgRU5BQkxF X1NRTElURT0xKSB7CiAgICAgICAgICAgICAjIHdlIGhhdmUgc291cmNlIC0gdXNlIGl0CiAgICAg ICAgICAgICBDT05GSUcocmVsZWFzZSwgZGVidWd8cmVsZWFzZSk6REVGSU5FUyAqPSBOREVCVUcK ICAgICAgICAgICAgIERFRklORVMgKz0gU1FMSVRFX0NPUkUgU1FMSVRFX09NSVRfTE9BRF9FWFRF TlNJT04gU1FMSVRFX09NSVRfQ09NUExFVEUgCisgICAgICAgICAgICBjb250YWlucyhERUZJTkVT LCBFTkFCTEVfTk9fVEhSRUFESU5HPTEpIHsKKyAgICAgICAgICAgICAgICBERUZJTkVTKz1TUUxJ VEVfVEhSRUFEU0FGRT0wCisgICAgICAgICAgICB9CiAgICAgICAgICAgICBJTkNMVURFUEFUSCAr PSAkJHtTUUxJVEUzU1JDRElSfQogICAgICAgICAgICAgU09VUkNFUyArPSAkJHtTUUxJVEUzU1JD RElSfS9zcWxpdGUzLmMKICAgICAgICAgfSBlbHNlIHsK 30838 2009-06-01 11:59:17 -0700 2009-06-04 01:56:33 -0700 Updated the patch to use ENABLE_SINGLE_THREADED as the guard. patch_26015_2.txt text/plain 4302 laszlo.gombos SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ0MzIxKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMDYtMDEgIExhc3psbyBH b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gU2luZ2xlLXRocmVhZGVkIFF0V2ViS2l0 IGNvbmZpZ3VyYXRpb24KKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yNjAxNT4KKworICAgICAgICAqIEphdmFTY3JpcHRDb3JlLnByaTogVXNlIFRocmVh ZGluZ05vbmUuY3BwIGluc3RlYWQgb2YKKyAgICAgICAgVGhyZWFkaW5nUXQuY3BwIGFuZCBtYWtl IHN1cmUgRU5BQkxFX0pTQ19NVUxUSVBMRV9USFJFQURTIGlzIHR1cm5lZCBvZmYgCisgICAgICAg IHdoZW4gRU5BQkxFX1NJTkdMRV9USFJFQURFRCBpcyB0dW5lZCBvbgorICAgICAgICAqIHd0Zi9U aHJlYWRpbmdOb25lLmNwcDoKKyAgICAgICAgKFdURjo6VGhyZWFkQ29uZGl0aW9uOjp3YWl0KTog Rml4IGNvbXBpbGF0aW9uIHdhcm5pbmcuCisgICAgICAgIChXVEY6OlRocmVhZENvbmRpdGlvbjo6 dGltZWRXYWl0KTogRGl0dG8uCisKIDIwMDktMDUtMzEgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFy cmFjbG91Z2hAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9sbGllaiAieW91IGp1 c3QgbmVlZCB0byBjaGFuZ2UgTmF0aXZlRnVuY3Rpb25XcmFwcGVyLmgiIEh1bnQuCkluZGV4OiBK YXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5wcmkKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlw dENvcmUvSmF2YVNjcmlwdENvcmUucHJpCShyZXZpc2lvbiA0NDMyMSkKKysrIEphdmFTY3JpcHRD b3JlL0phdmFTY3JpcHRDb3JlLnByaQkod29ya2luZyBjb3B5KQpAQCAtMjIxLDkgKzIyMSwxNSBA QCBTT1VSQ0VTICs9IFwKICAgICBwcm9maWxlci9UcmVlUHJvZmlsZS5jcHAgXAogICAgIHd0Zi9G YXN0TWFsbG9jLmNwcCBcCiAgICAgd3RmL1RocmVhZGluZy5jcHAgXAotICAgIHd0Zi9xdC9UaHJl YWRpbmdRdC5jcHAgXAogICAgIHd0Zi9xdC9NYWluVGhyZWFkUXQuY3BwCiAKKyFjb250YWlucyhE RUZJTkVTLCBFTkFCTEVfU0lOR0xFX1RIUkVBREVEPTEpIHsKKyAgICBTT1VSQ0VTICs9IHd0Zi9x dC9UaHJlYWRpbmdRdC5jcHAKK30gZWxzZSB7IAorICAgIERFRklORVMgKz0gRU5BQkxFX0pTQ19N VUxUSVBMRV9USFJFQURTPTAKKyAgICBTT1VSQ0VTICs9IHd0Zi9UaHJlYWRpbmdOb25lLmNwcCAK K30KKwogIyBHRU5FUkFUT1IgMS1BOiBMVVQgY3JlYXRvcgogbHV0Lm91dHB1dCA9ICQkR0VORVJB VEVEX1NPVVJDRVNfRElSLyR7UU1BS0VfRklMRV9CQVNFfS5sdXQuaAogbHV0LmNvbW1hbmRzID0g cGVybCAkJFBXRC9jcmVhdGVfaGFzaF90YWJsZSAke1FNQUtFX0ZJTEVfTkFNRX0gLWkgPiAke1FN QUtFX0ZJTEVfT1VUfQpJbmRleDogSmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZGluZ05vbmUuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRpbmdOb25lLmNwcAkocmV2 aXNpb24gNDQzMjEpCisrKyBKYXZhU2NyaXB0Q29yZS93dGYvVGhyZWFkaW5nTm9uZS5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTQ4LDggKzQ4LDggQEAgdm9pZCBNdXRleDo6dW5sb2NrKCkgeyB9CiAK IFRocmVhZENvbmRpdGlvbjo6VGhyZWFkQ29uZGl0aW9uKCkgeyB9CiBUaHJlYWRDb25kaXRpb246 On5UaHJlYWRDb25kaXRpb24oKSB7IH0KLXZvaWQgVGhyZWFkQ29uZGl0aW9uOjp3YWl0KE11dGV4 JiBtdXRleCkgeyB9Ci1ib29sIFRocmVhZENvbmRpdGlvbjo6dGltZWRXYWl0KE11dGV4JiBtdXRl eCwgZG91YmxlIGFic29sdXRlVGltZSkgeyByZXR1cm4gZmFsc2U7IH0KK3ZvaWQgVGhyZWFkQ29u ZGl0aW9uOjp3YWl0KE11dGV4JikgeyB9Citib29sIFRocmVhZENvbmRpdGlvbjo6dGltZWRXYWl0 KE11dGV4JiwgZG91YmxlKSB7IHJldHVybiBmYWxzZTsgfQogdm9pZCBUaHJlYWRDb25kaXRpb246 OnNpZ25hbCgpIHsgfQogdm9pZCBUaHJlYWRDb25kaXRpb246OmJyb2FkY2FzdCgpIHsgfQogCklu ZGV4OiBXZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL0NoYW5nZUxvZwko cmV2aXNpb24gNDQzMjEpCisrKyBXZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAt MSwzICsxLDE5IEBACisyMDA5LTA2LTAxICBMYXN6bG8gR29tYm9zICA8bGFzemxvLjEuZ29tYm9z QG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjYwMTUKKworICAg ICAgICBbUXRdIFNpbmdsZS10aHJlYWRlZCBRdFdlYktpdCBjb25maWd1cmF0aW9uCisKKyAgICAg ICAgVHVybiBvZmYgRGF0YWJhc2UsIERPTSBzdG9yYWdlLCBpY29uIGRhdGFiYXNlIGFuZCBXZWIg V29ya2VycyBzdXBwb3J0CisgICAgICAgIHdoZW4gRU5BQkxFX1NJTkdMRV9USFJFQURFRCBpcyB0 dXJuZWQgb24uCisKKyAgICAgICAgU2V0IFNRTElURV9USFJFQURTQUZFIHRvIGZhbHNlIHRvIHR1 cm4gb2ZmIFNRTGl0ZSBtdXRleGVzCisgICAgICAgIHdoZW4gRU5BQkxFX1NJTkdMRV9USFJFQURF RCBpcyB0dXJuZWQgb24uCisKKyAgICAgICAgKiBXZWJDb3JlLnBybzoKKwogMjAwOS0wNi0wMSAg RHJldyBXaWxzb24gIDxhdHdpbHNvbkBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IERhcmluIEFkbGVyLiAgTGFuZGVkIChhbmQgdHdlYWtlZCkgYnkgQWRhbSBCYXJ0aC4KSW5kZXg6 IFdlYkNvcmUvV2ViQ29yZS5wcm8KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9XZWJDb3JlLnBybwko cmV2aXNpb24gNDQzMjEpCisrKyBXZWJDb3JlL1dlYkNvcmUucHJvCSh3b3JraW5nIGNvcHkpCkBA IC04NSw2ICs4NSwxMCBAQCBDT05GSUcoUVRESVJfYnVpbGQpIHsKIAogIyBPcHRpb25hbCBjb21w b25lbnRzIChsb29rIGZvciBkZWZzIGluIGNvbmZpZy5oIGFuZCBpbmNsdWRlZCBmaWxlcyEpCiAK K2NvbnRhaW5zKERFRklORVMsIEVOQUJMRV9TSU5HTEVfVEhSRUFERUQ9MSkgeworICAgIERFRklO RVMrPUVOQUJMRV9EQVRBQkFTRT0wIEVOQUJMRV9ET01fU1RPUkFHRT0wIEVOQUJMRV9JQ09OREFU QUJBU0U9MCBFTkFCTEVfV09SS0VSUz0wCit9CisKICMgdHVybiBvZmYgU1FMSVRFIHN1cHBvcnQg aWYgd2UgZG8gbm90IGhhdmUgc3FsaXRlMyBhdmFpbGFibGUKICFDT05GSUcoUVRESVJfYnVpbGQp OndpbjMyLSo6IWV4aXN0cyggJCR7U1FMSVRFM1NSQ0RJUn0vc3FsaXRlMy5jICk6IERFRklORVMg Kz0gRU5BQkxFX1NRTElURT0wIEVOQUJMRV9EQVRBQkFTRT0wIEVOQUJMRV9JQ09OREFUQUJBU0U9 MCBFTkFCTEVfT0ZGTElORV9XRUJfQVBQTElDQVRJT05TPTAgRU5BQkxFX0RPTV9TVE9SQUdFPTAK IApAQCAtMTI3Miw2ICsxMjc2LDkgQEAgY29udGFpbnMoREVGSU5FUywgRU5BQkxFX1NRTElURT0x KSB7CiAgICAgICAgICAgICAjIHdlIGhhdmUgc291cmNlIC0gdXNlIGl0CiAgICAgICAgICAgICBD T05GSUcocmVsZWFzZSwgZGVidWd8cmVsZWFzZSk6REVGSU5FUyAqPSBOREVCVUcKICAgICAgICAg ICAgIERFRklORVMgKz0gU1FMSVRFX0NPUkUgU1FMSVRFX09NSVRfTE9BRF9FWFRFTlNJT04gU1FM SVRFX09NSVRfQ09NUExFVEUgCisgICAgICAgICAgICBjb250YWlucyhERUZJTkVTLCBFTkFCTEVf U0lOR0xFX1RIUkVBREVEPTEpIHsKKyAgICAgICAgICAgICAgICBERUZJTkVTKz1TUUxJVEVfVEhS RUFEU0FGRT0wCisgICAgICAgICAgICB9CiAgICAgICAgICAgICBJTkNMVURFUEFUSCArPSAkJHtT UUxJVEUzU1JDRElSfQogICAgICAgICAgICAgU09VUkNFUyArPSAkJHtTUUxJVEUzU1JDRElSfS9z cWxpdGUzLmMKICAgICAgICAgfSBlbHNlIHsK 31026 2009-06-05 20:23:32 -0700 2009-06-09 10:29:30 -0700 Fix compilation warnings in ThreadingNone.cpp patch_26015_3.txt text/plain 1313 laszlo.gombos SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ0NDc4KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDYtMDUgIExhc3psbyBH b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBjb21waWxhdGlvbiB3YXJuaW5ncworICAg ICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI2MDE1PgorCisg ICAgICAgICogd3RmL1RocmVhZGluZ05vbmUuY3BwOgorICAgICAgICAoV1RGOjpUaHJlYWRDb25k aXRpb246OndhaXQpOiBGaXggY29tcGlsYXRpb24gd2FybmluZy4KKyAgICAgICAgKFdURjo6VGhy ZWFkQ29uZGl0aW9uOjp0aW1lZFdhaXQpOiBEaXR0by4KKwogMjAwOS0wNi0wNSAgR2F2aW4gQmFy cmFjbG91Z2ggIDxiYXJyYWNsb3VnaEBhcHBsZS5jb20+CiAKICAgICAgICAgUnVkZGVyIHN0YW1w ZWQgYnkgU2FtIFdlaW5pZy4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRpbmdOb25l LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93dGYvVGhyZWFkaW5nTm9uZS5jcHAJ KHJldmlzaW9uIDQ0NDc2KQorKysgSmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZGluZ05vbmUuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC00OCw4ICs0OCw4IEBAIHZvaWQgTXV0ZXg6OnVubG9jaygpIHsg fQogCiBUaHJlYWRDb25kaXRpb246OlRocmVhZENvbmRpdGlvbigpIHsgfQogVGhyZWFkQ29uZGl0 aW9uOjp+VGhyZWFkQ29uZGl0aW9uKCkgeyB9Ci12b2lkIFRocmVhZENvbmRpdGlvbjo6d2FpdChN dXRleCYgbXV0ZXgpIHsgfQotYm9vbCBUaHJlYWRDb25kaXRpb246OnRpbWVkV2FpdChNdXRleCYg bXV0ZXgsIGRvdWJsZSBhYnNvbHV0ZVRpbWUpIHsgcmV0dXJuIGZhbHNlOyB9Cit2b2lkIFRocmVh ZENvbmRpdGlvbjo6d2FpdChNdXRleCYpIHsgfQorYm9vbCBUaHJlYWRDb25kaXRpb246OnRpbWVk V2FpdChNdXRleCYsIGRvdWJsZSkgeyByZXR1cm4gZmFsc2U7IH0KIHZvaWQgVGhyZWFkQ29uZGl0 aW9uOjpzaWduYWwoKSB7IH0KIHZvaWQgVGhyZWFkQ29uZGl0aW9uOjpicm9hZGNhc3QoKSB7IH0K IAo= 31062 2009-06-08 14:15:11 -0700 2009-06-09 10:34:16 -0700 Use UNUSED_PARAM macro for unused arguments as Ariya suggested. patch_26015_4.txt text/plain 1574 laszlo.gombos SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ0NTA0KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDYtMDggIExhc3psbyBH b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBjb21waWxhdGlvbiB3YXJuaW5ncworICAg ICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI2MDE1PgorCisg ICAgICAgICogd3RmL1RocmVhZGluZ05vbmUuY3BwOgorICAgICAgICAoV1RGOjpUaHJlYWRDb25k aXRpb246OndhaXQpOiBGaXggY29tcGlsYXRpb24gd2FybmluZy4KKyAgICAgICAgKFdURjo6VGhy ZWFkQ29uZGl0aW9uOjp0aW1lZFdhaXQpOiBEaXR0by4KKwogMjAwOS0wNi0wNyAgRGF2aWQgS2ls emVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgSmF2YVNjcmlwdENvcmUg Y29tcGlsZSBmb3IgaVBob25lIGFuZCBpUGhvbmUgU2ltdWxhdG9yCkluZGV4OiBKYXZhU2NyaXB0 Q29yZS93dGYvVGhyZWFkaW5nTm9uZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUv d3RmL1RocmVhZGluZ05vbmUuY3BwCShyZXZpc2lvbiA0NDUwMykKKysrIEphdmFTY3JpcHRDb3Jl L3d0Zi9UaHJlYWRpbmdOb25lLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzAsNiArMzAsOCBAQAog I2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIlRocmVhZGluZy5oIgogCisjaW5jbHVkZSAi VW51c2VkUGFyYW0uaCIKKwogbmFtZXNwYWNlIFdURiB7CiAKIHZvaWQgaW5pdGlhbGl6ZVRocmVh ZGluZygpIHsgfQpAQCAtNDgsOCArNTAsOCBAQCB2b2lkIE11dGV4Ojp1bmxvY2soKSB7IH0KIAog VGhyZWFkQ29uZGl0aW9uOjpUaHJlYWRDb25kaXRpb24oKSB7IH0KIFRocmVhZENvbmRpdGlvbjo6 flRocmVhZENvbmRpdGlvbigpIHsgfQotdm9pZCBUaHJlYWRDb25kaXRpb246OndhaXQoTXV0ZXgm IG11dGV4KSB7IH0KLWJvb2wgVGhyZWFkQ29uZGl0aW9uOjp0aW1lZFdhaXQoTXV0ZXgmIG11dGV4 LCBkb3VibGUgYWJzb2x1dGVUaW1lKSB7IHJldHVybiBmYWxzZTsgfQordm9pZCBUaHJlYWRDb25k aXRpb246OndhaXQoTXV0ZXgmIG11dGV4KSB7IFVOVVNFRF9QQVJBTShtdXRleCk7IH0KK2Jvb2wg VGhyZWFkQ29uZGl0aW9uOjp0aW1lZFdhaXQoTXV0ZXgmIG11dGV4LCBkb3VibGUgYWJzb2x1dGVU aW1lKSB7IFVOVVNFRF9QQVJBTShtdXRleCk7IFVOVVNFRF9QQVJBTShhYnNvbHV0ZVRpbWUpOyBy ZXR1cm4gZmFsc2U7IH0KIHZvaWQgVGhyZWFkQ29uZGl0aW9uOjpzaWduYWwoKSB7IH0KIHZvaWQg VGhyZWFkQ29uZGl0aW9uOjpicm9hZGNhc3QoKSB7IH0KIAo=