260142 2023-08-14 07:13:45 -0700 [LFC] Remove unsupported (and broken) LayoutContext::layout codepath 2023-08-14 21:10:14 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1971032 0 zalan 2023-08-14 07:13:45 -0700 ssia 1971033 1 467266 zalan 2023-08-14 07:16:42 -0700 Created attachment 467266 Patch 1971222 2 ews-feeder 2023-08-14 21:09:13 -0700 Committed 266895@main (f8811c92d7bb): <https://commits.webkit.org/266895@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 467266. 1971223 3 webkit-bug-importer 2023-08-14 21:10:14 -0700 <rdar://problem/113888398> 467266 2023-08-14 07:16:42 -0700 2023-08-14 21:09:14 -0700 Patch bug-260142-20230814071641.patch text/plain 3929 zalan RnJvbSA5MTAxODRjYzk0NmE2ZTdhMzQzMDMwMDczYzVjYTExZDRmZTFmNmY1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJhcmFkbGF5IDx6YWxhbkBhcHBsZS5jb20+CkRhdGU6 IE1vbiwgMTQgQXVnIDIwMjMgMDc6MTQ6NDEgLTA3MDAKU3ViamVjdDogW1BBVENIXSBbTEZDXSBS ZW1vdmUgdW5zdXBwb3J0ZWQgKGFuZCBicm9rZW4pIExheW91dENvbnRleHQ6OmxheW91dAogY29k ZXBhdGggaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI2MDE0MgoKUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpGdWxsIExGQyBjb2RlcGF0aCBoYXMgbm90IGJlZW4g bWFpbnRhaW5lZCBmb3IgYSB3aGlsZSBub3cgKGludGVncmF0aW9uIGNvZGVwYXRoIGlzIHNsb3ds eSB0YWtpbmcgb3ZlcikuCgoqIFNvdXJjZS9XZWJDb3JlL3BhZ2UvTG9jYWxGcmFtZVZpZXdMYXlv dXRDb250ZXh0LmNwcDoKKFdlYkNvcmU6OkxvY2FsRnJhbWVWaWV3TGF5b3V0Q29udGV4dDo6cGVy Zm9ybUxheW91dCk6CihXZWJDb3JlOjpMb2NhbEZyYW1lVmlld0xheW91dENvbnRleHQ6OmxheW91 dFVzaW5nRm9ybWF0dGluZ0NvbnRleHQpOiBEZWxldGVkLgoqIFNvdXJjZS9XZWJDb3JlL3BhZ2Uv TG9jYWxGcmFtZVZpZXdMYXlvdXRDb250ZXh0Lmg6CihXZWJDb3JlOjpMb2NhbEZyYW1lVmlld0xh eW91dENvbnRleHQ6OmVuYWJsZVBhaW50T2Zmc2V0Q2FjaGUpOgotLS0KIC4uLi9wYWdlL0xvY2Fs RnJhbWVWaWV3TGF5b3V0Q29udGV4dC5jcHAgICAgICB8IDMzIC0tLS0tLS0tLS0tLS0tLS0tLS0K IC4uLi9wYWdlL0xvY2FsRnJhbWVWaWV3TGF5b3V0Q29udGV4dC5oICAgICAgICB8ICAxIC0KIDIg ZmlsZXMgY2hhbmdlZCwgMzQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGFnZS9Mb2NhbEZyYW1lVmlld0xheW91dENvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUv cGFnZS9Mb2NhbEZyYW1lVmlld0xheW91dENvbnRleHQuY3BwCmluZGV4IGQyMjhlZWFiYjdjMC4u YjU1ZDVjMTM1ZjNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0xvY2FsRnJhbWVW aWV3TGF5b3V0Q29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9Mb2NhbEZyYW1l Vmlld0xheW91dENvbnRleHQuY3BwCkBAIC01NSwzOCArNTUsNiBAQCBuYW1lc3BhY2UgV2ViQ29y ZSB7CiBVcGRhdGVTY3JvbGxJbmZvQWZ0ZXJMYXlvdXRUcmFuc2FjdGlvbjo6VXBkYXRlU2Nyb2xs SW5mb0FmdGVyTGF5b3V0VHJhbnNhY3Rpb24oKSA9IGRlZmF1bHQ7CiBVcGRhdGVTY3JvbGxJbmZv QWZ0ZXJMYXlvdXRUcmFuc2FjdGlvbjo6flVwZGF0ZVNjcm9sbEluZm9BZnRlckxheW91dFRyYW5z YWN0aW9uKCkgPSBkZWZhdWx0OwogCi12b2lkIExvY2FsRnJhbWVWaWV3TGF5b3V0Q29udGV4dDo6 bGF5b3V0VXNpbmdGb3JtYXR0aW5nQ29udGV4dCgpCi17Ci0gICAgaWYgKCFmcmFtZSgpLnNldHRp bmdzKCkubGF5b3V0Rm9ybWF0dGluZ0NvbnRleHRFbmFibGVkKCkpCi0gICAgICAgIHJldHVybjsK LSAgICAvLyBMb2NhbEZyYW1lVmlldzo6c2V0Q29udGVudHNTaXplIHRlbXBvcmFyeSBkaXNhYmxl cyBsYXlvdXQuCi0gICAgaWYgKG1fZGlzYWJsZVNldE5lZWRzTGF5b3V0Q291bnQpCi0gICAgICAg IHJldHVybjsKLQotICAgIG1fbGF5b3V0U3RhdGUgPSBudWxscHRyOwotICAgIG1fbGF5b3V0VHJl ZSA9IG51bGxwdHI7Ci0KLSAgICBhdXRvJiByZW5kZXJWaWV3ID0gKnRoaXMtPnJlbmRlclZpZXco KTsKLSAgICBtX2xheW91dFRyZWUgPSBMYXlvdXQ6OlRyZWVCdWlsZGVyOjpidWlsZExheW91dFRy ZWUocmVuZGVyVmlldyk7Ci0gICAgbV9sYXlvdXRTdGF0ZSA9IG1ha2VVbmlxdWU8TGF5b3V0OjpM YXlvdXRTdGF0ZT4oKmRvY3VtZW50KCksIG1fbGF5b3V0VHJlZS0+cm9vdCgpKTsKLSAgICBhdXRv IGxheW91dENvbnRleHQgPSBMYXlvdXQ6OkxheW91dENvbnRleHQgeyAqbV9sYXlvdXRTdGF0ZSB9 OwotICAgIGxheW91dENvbnRleHQubGF5b3V0KHZpZXcoKS5sYXlvdXRTaXplKCkpOwotCi0gICAg Ly8gQ2xlYW4gdXAgdGhlIHJlbmRlciB0cmVlIHN0YXRlIHdoZW4gd2UgZG9uJ3QgcnVuIFJlbmRl clZpZXc6OmxheW91dC4KLSAgICBpZiAocmVuZGVyVmlldy5uZWVkc0xheW91dCgpKSB7Ci0gICAg ICAgIGF1dG8gY29udGVudFNpemUgPSBMYXlvdXQ6OkJveEdlb21ldHJ5OjptYXJnaW5Cb3hSZWN0 KG1fbGF5b3V0U3RhdGUtPmdlb21ldHJ5Rm9yQm94KCptX2xheW91dFN0YXRlLT5yb290KCkuZmly c3RDaGlsZCgpKSkuc2l6ZSgpOwotICAgICAgICByZW5kZXJWaWV3LnNldFNpemUoY29udGVudFNp emUpOwotICAgICAgICByZW5kZXJWaWV3LnJlcGFpbnRWaWV3UmVjdGFuZ2xlKHsgMCwgMCwgY29u dGVudFNpemUud2lkdGgoKSwgY29udGVudFNpemUuaGVpZ2h0KCkgfSk7Ci0KLSAgICAgICAgZm9y IChhdXRvJiBkZXNjZW5kYW50IDogZGVzY2VuZGFudHNPZlR5cGU8UmVuZGVyT2JqZWN0PihyZW5k ZXJWaWV3KSkKLSAgICAgICAgICAgIGRlc2NlbmRhbnQuY2xlYXJOZWVkc0xheW91dCgpOwotICAg ICAgICByZW5kZXJWaWV3LmNsZWFyTmVlZHNMYXlvdXQoKTsKLSAgICB9Ci0jaWYgQVNTRVJUX0VO QUJMRUQKLSAgICBMYXlvdXQ6OkxheW91dENvbnRleHQ6OnZlcmlmeUFuZE91dHB1dE1pc21hdGNo aW5nTGF5b3V0VHJlZSgqbV9sYXlvdXRTdGF0ZSwgcmVuZGVyVmlldyk7Ci0jZW5kaWYKLX0KLQog c3RhdGljIGJvb2wgaXNPYmplY3RBbmNlc3RvckNvbnRhaW5lck9mKFJlbmRlckVsZW1lbnQmIGFu Y2VzdG9yLCBSZW5kZXJFbGVtZW50JiBkZXNjZW5kYW50KQogewogICAgIGZvciAoYXV0byogcmVu ZGVyZXIgPSAmZGVzY2VuZGFudDsgcmVuZGVyZXI7IHJlbmRlcmVyID0gcmVuZGVyZXItPmNvbnRh aW5lcigpKSB7CkBAIC0yNjYsNyArMjM0LDYgQEAgdm9pZCBMb2NhbEZyYW1lVmlld0xheW91dENv bnRleHQ6OnBlcmZvcm1MYXlvdXQoKQogICAgICAgICBSZW5kZXJUcmVlTmVlZHNMYXlvdXRDaGVj a2VyIGNoZWNrZXIoKnJlbmRlclZpZXcoKSk7CiAjZW5kaWYKICAgICAgICAgbGF5b3V0Um9vdC0+ bGF5b3V0KCk7Ci0gICAgICAgIGxheW91dFVzaW5nRm9ybWF0dGluZ0NvbnRleHQoKTsKICAgICAg ICAgKyttX2xheW91dENvdW50OwogI2lmIEVOQUJMRShURVhUX0FVVE9TSVpJTkcpCiAgICAgICAg IGFwcGx5VGV4dFNpemluZ0lmTmVlZGVkKCpsYXlvdXRSb290LmdldCgpKTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BhZ2UvTG9jYWxGcmFtZVZpZXdMYXlvdXRDb250ZXh0LmggYi9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0xvY2FsRnJhbWVWaWV3TGF5b3V0Q29udGV4dC5oCmluZGV4IDRjZWRl Yzg1MTMzMi4uNWNiZWQzZGIyZmM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0xv Y2FsRnJhbWVWaWV3TGF5b3V0Q29udGV4dC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvTG9j YWxGcmFtZVZpZXdMYXlvdXRDb250ZXh0LmgKQEAgLTE2NSw3ICsxNjUsNiBAQCBwcml2YXRlOgog ICAgIC8vIFRoZXNlIGZ1bmN0aW9ucyBtYXkgb25seSBiZSBhY2Nlc3NlZCBieSBMYXlvdXRTdGF0 ZU1haW50YWluZXIgb3IgTGF5b3V0U3RhdGVEaXNhYmxlci4KICAgICB2b2lkIGRpc2FibGVQYWlu dE9mZnNldENhY2hlKCkgeyBtX3BhaW50T2Zmc2V0Q2FjaGVEaXNhYmxlQ291bnQrKzsgfQogICAg IHZvaWQgZW5hYmxlUGFpbnRPZmZzZXRDYWNoZSgpIHsgQVNTRVJUKG1fcGFpbnRPZmZzZXRDYWNo ZURpc2FibGVDb3VudCA+IDApOyBtX3BhaW50T2Zmc2V0Q2FjaGVEaXNhYmxlQ291bnQtLTsgfQot ICAgIHZvaWQgbGF5b3V0VXNpbmdGb3JtYXR0aW5nQ29udGV4dCgpOwogCiAgICAgTG9jYWxGcmFt ZSYgZnJhbWUoKSBjb25zdDsKICAgICBMb2NhbEZyYW1lVmlldyYgdmlldygpIGNvbnN0Owo=