26012 2009-05-25 12:16:55 -0700 Chromium doesn't handle -webkit-border-image correctly. 2009-05-26 09:00:56 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 0 senorblanco webkit-unassigned senorblanco oldest_to_newest 123068 0 senorblanco 2009-05-25 12:16:55 -0700 Chromium (skia) doesn't do -webkit-border-image correctly when the border image is 1 pixel wide or high, since it doesn't like negative width/height source rects in Image::drawPattern(). CoreGraphics will happily draw it in this case. See bug http://crbug.com/6167. 123069 1 30658 senorblanco 2009-05-25 12:20:29 -0700 Created attachment 30658 Fix for Chromium Image::drawPattern() issue. 123078 2 mrowe 2009-05-25 14:37:22 -0700 Putting Brett as the reviewer doesn't make much sense as Brett is not a WebKit reviewer. We don't typically nominate a specific reviewer anyway. 123128 3 senorblanco 2009-05-26 07:42:02 -0700 (In reply to comment #2) > Putting Brett as the reviewer doesn't make much sense as Brett is not a WebKit > reviewer. Whoops, will fix. > We don't typically nominate a specific reviewer anyway. In my experience, patches tend to get ignored if you don't. 123129 4 30658 dglazkov 2009-05-26 08:01:59 -0700 Comment on attachment 30658 Fix for Chromium Image::drawPattern() issue. Thanks for fixing this! Don't forget a bug URL in the ChangeLog. 123132 5 30669 senorblanco 2009-05-26 08:15:30 -0700 Created attachment 30669 Fix ChangeLog 123136 6 dglazkov 2009-05-26 09:00:56 -0700 Landed as http://trac.webkit.org/changeset/44150. 30658 2009-05-25 12:20:29 -0700 2009-05-26 08:15:30 -0700 Fix for Chromium Image::drawPattern() issue. webkit_border_image_skia.patch text/plain 2553 senorblanco SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NDEzMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMDUtMjUgIFN0ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0Bj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRml4IHRoZSBTa2lhIHBhdGggdG8gbm9ybWFsaXplIHRoZSBnaXZlbiBzb3VyY2UgcmVj dCB3aGVuCisgICAgICAgIGRyYXdpbmcgcGF0dGVybnMsIHNvIGl0IGFjY2VwdHMgbmVnYXRpdmUg d2lkdGgvaGVpZ2h0IChhcyBDRyBkb2VzKS4KKyAgICAgICAgRml4ZXMgQ2hyb21pdW0gYnVnIGh0 dHA6Ly93d3cuY3JidWcuY29tLzYxNjcuCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tp YS9JbWFnZVNraWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2U6OmRyYXdQYXR0ZXJuKToK KwogMjAwOS0wNS0yNSAgRnJpZHJpY2ggU3RyYmEgIDxmcmlkcmljaC5zdHJiYUBibHVld2luLmNo PgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hY2llaiBTdGFjaG93aWFrLgpJbmRleDogV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlU2tpYS5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlU2tpYS5jcHAJKHJldmlzaW9uIDQ0MTMy KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlU2tpYS5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTMwNCw3ICszMDQsOCBAQCB2b2lkIEltYWdlOjpkcmF3UGF0dGVybihHcmFw aGljc0NvbnRleHQqCiAgICAgICAgICAgICAgICAgICAgICAgICBDb21wb3NpdGVPcGVyYXRvciBj b21wb3NpdGVPcCwKICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IEZsb2F0UmVjdCYgZGVz dFJlY3QpCiB7Ci0gICAgaWYgKGRlc3RSZWN0LmlzRW1wdHkoKSB8fCBmbG9hdFNyY1JlY3QuaXNF bXB0eSgpKQorICAgIEZsb2F0UmVjdCBub3JtU3JjUmVjdCA9IG5vcm1hbGl6ZVJlY3QoZmxvYXRT cmNSZWN0KTsKKyAgICBpZiAoZGVzdFJlY3QuaXNFbXB0eSgpIHx8IG5vcm1TcmNSZWN0LmlzRW1w dHkoKSkKICAgICAgICAgcmV0dXJuOyAgLy8gbm90aGluZyB0byBkcmF3CiAKICAgICBOYXRpdmVJ bWFnZVNraWEqIGJpdG1hcCA9IG5hdGl2ZUltYWdlRm9yQ3VycmVudEZyYW1lKCk7CkBAIC0zMTUs NyArMzE2LDcgQEAgdm9pZCBJbWFnZTo6ZHJhd1BhdHRlcm4oR3JhcGhpY3NDb250ZXh0KgogICAg IC8vIGl0IHdpbGwgaW50ZXJuYWxseSByZWZlcmVuY2UgdGhlIG9sZCBiaXRtYXAncyBwaXhlbHMs IGFkanVzdGluZyB0aGUgcm93CiAgICAgLy8gc3RyaWRlIHNvIHRoZSBleHRyYSBwaXhlbHMgYXBw ZWFyIGFzIHBhZGRpbmcgdG8gdGhlIHN1YnNldHRlZCBiaXRtYXAuCiAgICAgU2tCaXRtYXAgc3Jj U3Vic2V0OwotICAgIFNrSVJlY3Qgc3JjUmVjdCA9IGVuY2xvc2luZ0ludFJlY3QoZmxvYXRTcmNS ZWN0KTsKKyAgICBTa0lSZWN0IHNyY1JlY3QgPSBlbmNsb3NpbmdJbnRSZWN0KG5vcm1TcmNSZWN0 KTsKICAgICBiaXRtYXAtPmV4dHJhY3RTdWJzZXQoJnNyY1N1YnNldCwgc3JjUmVjdCk7CiAKICAg ICBTa0JpdG1hcCByZXNhbXBsZWQ7CkBAIC0zNjIsOSArMzYzLDkgQEAgdm9pZCBJbWFnZTo6ZHJh d1BhdHRlcm4oR3JhcGhpY3NDb250ZXh0KgogICAgIC8vIG9yaWdpbiBvZiB0aGUgZGVzdGluYXRp b24gcmVjdCwgd2hpY2ggaXMgd2hhdCBXZWJLaXQgZXhwZWN0cy4gU2tpYSB1c2VzCiAgICAgLy8g dGhlIGNvb3JkaW5hdGUgc3lzdGVtIG9yaWdpbiBhcyB0aGUgYmFzZSBmb3IgdGhlIHBhdHRlci4g SWYgV2ViS2l0IHdhbnRzCiAgICAgLy8gYSBzaGlmdGVkIGltYWdlLCBpdCB3aWxsIHNoaWZ0IGl0 IGZyb20gdGhlcmUgdXNpbmcgdGhlIHBhdHRlcm5UcmFuc2Zvcm0uCi0gICAgZmxvYXQgYWRqdXN0 ZWRYID0gcGhhc2UueCgpICsgZmxvYXRTcmNSZWN0LngoKSAqCisgICAgZmxvYXQgYWRqdXN0ZWRY ID0gcGhhc2UueCgpICsgbm9ybVNyY1JlY3QueCgpICoKICAgICAgICAgICAgICAgICAgICAgICBu YXJyb3dQcmVjaXNpb25Ub0Zsb2F0KHBhdHRlcm5UcmFuc2Zvcm0uYSgpKTsKLSAgICBmbG9hdCBh ZGp1c3RlZFkgPSBwaGFzZS55KCkgKyBmbG9hdFNyY1JlY3QueSgpICoKKyAgICBmbG9hdCBhZGp1 c3RlZFkgPSBwaGFzZS55KCkgKyBub3JtU3JjUmVjdC55KCkgKgogICAgICAgICAgICAgICAgICAg ICAgIG5hcnJvd1ByZWNpc2lvblRvRmxvYXQocGF0dGVyblRyYW5zZm9ybS5kKCkpOwogICAgIG1h dHJpeC5wb3N0VHJhbnNsYXRlKFNrRmxvYXRUb1NjYWxhcihhZGp1c3RlZFgpLAogICAgICAgICAg ICAgICAgICAgICAgICAgIFNrRmxvYXRUb1NjYWxhcihhZGp1c3RlZFkpKTsK 30669 2009-05-26 08:15:30 -0700 2009-05-26 08:41:48 -0700 Fix ChangeLog webkit_border_image_skia_2.patch text/plain 2603 senorblanco SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NDE0OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMDUtMjUgIFN0ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0Bj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI2MDEyCisKKyAg ICAgICAgRml4IHRoZSBTa2lhIHBhdGggdG8gbm9ybWFsaXplIHRoZSBnaXZlbiBzb3VyY2UgcmVj dCB3aGVuCisgICAgICAgIGRyYXdpbmcgcGF0dGVybnMsIHNvIGl0IGFjY2VwdHMgbmVnYXRpdmUg d2lkdGgvaGVpZ2h0IChhcyBDRyBkb2VzKS4KKyAgICAgICAgRml4ZXMgQ2hyb21pdW0gYnVnIGh0 dHA6Ly93d3cuY3JidWcuY29tLzYxNjcuCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tp YS9JbWFnZVNraWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2U6OmRyYXdQYXR0ZXJuKToK KwogMjAwOS0wNS0yNiAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNoZXIuCkluZGV4OiBXZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VTa2lhLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VTa2lhLmNwcAkocmV2aXNpb24gNDQxNDkpCisrKyBX ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VTa2lhLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMzA0LDcgKzMwNCw4IEBAIHZvaWQgSW1hZ2U6OmRyYXdQYXR0ZXJuKEdyYXBoaWNzQ29u dGV4dCoKICAgICAgICAgICAgICAgICAgICAgICAgIENvbXBvc2l0ZU9wZXJhdG9yIGNvbXBvc2l0 ZU9wLAogICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgRmxvYXRSZWN0JiBkZXN0UmVjdCkK IHsKLSAgICBpZiAoZGVzdFJlY3QuaXNFbXB0eSgpIHx8IGZsb2F0U3JjUmVjdC5pc0VtcHR5KCkp CisgICAgRmxvYXRSZWN0IG5vcm1TcmNSZWN0ID0gbm9ybWFsaXplUmVjdChmbG9hdFNyY1JlY3Qp OworICAgIGlmIChkZXN0UmVjdC5pc0VtcHR5KCkgfHwgbm9ybVNyY1JlY3QuaXNFbXB0eSgpKQog ICAgICAgICByZXR1cm47ICAvLyBub3RoaW5nIHRvIGRyYXcKIAogICAgIE5hdGl2ZUltYWdlU2tp YSogYml0bWFwID0gbmF0aXZlSW1hZ2VGb3JDdXJyZW50RnJhbWUoKTsKQEAgLTMxNSw3ICszMTYs NyBAQCB2b2lkIEltYWdlOjpkcmF3UGF0dGVybihHcmFwaGljc0NvbnRleHQqCiAgICAgLy8gaXQg d2lsbCBpbnRlcm5hbGx5IHJlZmVyZW5jZSB0aGUgb2xkIGJpdG1hcCdzIHBpeGVscywgYWRqdXN0 aW5nIHRoZSByb3cKICAgICAvLyBzdHJpZGUgc28gdGhlIGV4dHJhIHBpeGVscyBhcHBlYXIgYXMg cGFkZGluZyB0byB0aGUgc3Vic2V0dGVkIGJpdG1hcC4KICAgICBTa0JpdG1hcCBzcmNTdWJzZXQ7 Ci0gICAgU2tJUmVjdCBzcmNSZWN0ID0gZW5jbG9zaW5nSW50UmVjdChmbG9hdFNyY1JlY3QpOwor ICAgIFNrSVJlY3Qgc3JjUmVjdCA9IGVuY2xvc2luZ0ludFJlY3Qobm9ybVNyY1JlY3QpOwogICAg IGJpdG1hcC0+ZXh0cmFjdFN1YnNldCgmc3JjU3Vic2V0LCBzcmNSZWN0KTsKIAogICAgIFNrQml0 bWFwIHJlc2FtcGxlZDsKQEAgLTM2Miw5ICszNjMsOSBAQCB2b2lkIEltYWdlOjpkcmF3UGF0dGVy bihHcmFwaGljc0NvbnRleHQqCiAgICAgLy8gb3JpZ2luIG9mIHRoZSBkZXN0aW5hdGlvbiByZWN0 LCB3aGljaCBpcyB3aGF0IFdlYktpdCBleHBlY3RzLiBTa2lhIHVzZXMKICAgICAvLyB0aGUgY29v cmRpbmF0ZSBzeXN0ZW0gb3JpZ2luIGFzIHRoZSBiYXNlIGZvciB0aGUgcGF0dGVyLiBJZiBXZWJL aXQgd2FudHMKICAgICAvLyBhIHNoaWZ0ZWQgaW1hZ2UsIGl0IHdpbGwgc2hpZnQgaXQgZnJvbSB0 aGVyZSB1c2luZyB0aGUgcGF0dGVyblRyYW5zZm9ybS4KLSAgICBmbG9hdCBhZGp1c3RlZFggPSBw aGFzZS54KCkgKyBmbG9hdFNyY1JlY3QueCgpICoKKyAgICBmbG9hdCBhZGp1c3RlZFggPSBwaGFz ZS54KCkgKyBub3JtU3JjUmVjdC54KCkgKgogICAgICAgICAgICAgICAgICAgICAgIG5hcnJvd1By ZWNpc2lvblRvRmxvYXQocGF0dGVyblRyYW5zZm9ybS5hKCkpOwotICAgIGZsb2F0IGFkanVzdGVk WSA9IHBoYXNlLnkoKSArIGZsb2F0U3JjUmVjdC55KCkgKgorICAgIGZsb2F0IGFkanVzdGVkWSA9 IHBoYXNlLnkoKSArIG5vcm1TcmNSZWN0LnkoKSAqCiAgICAgICAgICAgICAgICAgICAgICAgbmFy cm93UHJlY2lzaW9uVG9GbG9hdChwYXR0ZXJuVHJhbnNmb3JtLmQoKSk7CiAgICAgbWF0cml4LnBv c3RUcmFuc2xhdGUoU2tGbG9hdFRvU2NhbGFyKGFkanVzdGVkWCksCiAgICAgICAgICAgICAgICAg ICAgICAgICAgU2tGbG9hdFRvU2NhbGFyKGFkanVzdGVkWSkpOwo=