26011 2009-05-25 11:35:16 -0700 Fix flaky origin-follows-lexical-scope test 2010-06-10 17:28:24 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All NEW P2 Normal --- 1 abarth webkit-unassigned abarth mjs sam oldest_to_newest 123061 0 abarth 2009-05-25 11:35:16 -0700 I added a test last night that appears to be flaky. I don't really understand why it's flaky, but here's an attempt to fix it. 123062 1 30655 abarth 2009-05-25 11:39:18 -0700 Created attachment 30655 patch 123081 2 30655 abarth 2009-05-25 14:56:04 -0700 Comment on attachment 30655 patch This patch didn't seem to fix the problem... :( 123127 3 abarth 2009-05-26 07:37:29 -0700 I'm not sure what to do about this test. I can't reproduce the issue locally, which makes it hard to debug. Options in include: 1) Disabling / deleting the test and losing its coverage. 2) Debugging it by checking in diagnostics / attempted fixes late at night. 123162 4 mrowe 2009-05-26 11:41:18 -0700 We need to do something about it. We can't leave it failing on the buildbot for days at a time. 123181 5 sam 2009-05-26 13:51:16 -0700 Please disable it for now. It is much more helpful for the bot to be green. 123191 6 abarth 2009-05-26 14:19:42 -0700 (In reply to comment #5) > Please disable it for now. It is much more helpful for the bot to be green. Disabled in r44159. 30655 2009-05-25 11:39:18 -0700 2010-06-10 17:28:24 -0700 patch flaky-test.patch text/plain 4280 abarth SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQ0MTMxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDUtMjUgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjYwMTEKKwor ICAgICAgICBUcnkgdG8gbWFrZSB0ZXN0IGxlc3MgZmxha3kuCisKKyAgICAgICAgKiBodHRwL3Rl c3RzL3NlY3VyaXR5L3Bvc3RNZXNzYWdlL29yaWdpbi1mb2xsb3dzLWxleGljYWwtc2NvcGUtZXhw ZWN0ZWQudHh0OgorICAgICAgICAqIGh0dHAvdGVzdHMvc2VjdXJpdHkvcG9zdE1lc3NhZ2Uvb3Jp Z2luLWZvbGxvd3MtbGV4aWNhbC1zY29wZS5odG1sOgorICAgICAgICAqIGh0dHAvdGVzdHMvc2Vj dXJpdHkvcG9zdE1lc3NhZ2UvcmVzb3VyY2VzL21pZGRsZS1mcmFtZS1mb3ItbGV4aWNhbC5odG1s OgorICAgICAgICAqIGh0dHAvdGVzdHMvc2VjdXJpdHkvcG9zdE1lc3NhZ2UvcmVzb3VyY2VzL3Bv c3QtbWVzc2FnZS1saXN0ZW5lci13aXRoLXJlYWR5Lmh0bWw6IEFkZGVkLgorCiAyMDA5LTA1LTI1 ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg TWFjaWVqIFN0YWNob3dpYWsuCkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5 L3Bvc3RNZXNzYWdlL29yaWdpbi1mb2xsb3dzLWxleGljYWwtc2NvcGUtZXhwZWN0ZWQudHh0Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkvcG9zdE1lc3NhZ2Uv b3JpZ2luLWZvbGxvd3MtbGV4aWNhbC1zY29wZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDQ0MTI0 KQorKysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zZWN1cml0eS9wb3N0TWVzc2FnZS9vcmlnaW4t Zm9sbG93cy1sZXhpY2FsLXNjb3BlLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMiw1 ICsyLDYgQEAgd2luZG93LmxvY2F0aW9uLmhyZWYgPSBodHRwOi8vMTI3LjAuMC4xOgogZG9jdW1l bnQuZG9tYWluID0gMC4wLjEKIAogd2FpdGluZy4uLgotUmVjZWl2ZWQgbWVzc2FnZTogZGF0YT0i UmVjZWl2ZWQgbWVzc2FnZTogZGF0YT0icmVhZHkiIG9yaWdpbj0iaHR0cDovLzEyNy4wLjAuMTo4 MDgwIiIgb3JpZ2luPSJodHRwOi8vMTI3LjAuMC4xOjgwODAiCitSZWNlaXZlZCBtZXNzYWdlOiBk YXRhPSJyZWFkeSIgb3JpZ2luPSJodHRwOi8vMTI3LjAuMC4xOjgwODAiCityZWFkeQogUmVjZWl2 ZWQgbWVzc2FnZTogZGF0YT0iUmVjZWl2ZWQgbWVzc2FnZTogZGF0YT0iZG9uZSIgb3JpZ2luPSJo dHRwOi8vMTI3LjAuMC4xOjgwODAiIiBvcmlnaW49Imh0dHA6Ly8xMjcuMC4wLjE6ODA4MCIKSW5k ZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkvcG9zdE1lc3NhZ2Uvb3JpZ2luLWZv bGxvd3MtbGV4aWNhbC1zY29wZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0dHAv dGVzdHMvc2VjdXJpdHkvcG9zdE1lc3NhZ2Uvb3JpZ2luLWZvbGxvd3MtbGV4aWNhbC1zY29wZS5o dG1sCShyZXZpc2lvbiA0NDEyNCkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkv cG9zdE1lc3NhZ2Uvb3JpZ2luLWZvbGxvd3MtbGV4aWNhbC1zY29wZS5odG1sCSh3b3JraW5nIGNv cHkpCkBAIC0xMyw4ICsxMywxMCBAQCBmdW5jdGlvbiBsaXN0ZW5lcihlKSB7CiAKICAgICBsb2co bXNnKTsKIAotICAgIGlmIChlLmRhdGEubWF0Y2goL2RhdGE9InJlYWR5Ii8pKQorICAgIGlmIChl LmRhdGEubWF0Y2goL3JlYWR5LykpIHsKKyAgICAgICAgbG9nKCJyZWFkeSIpOwogICAgICAgICBm cmFtZXNbMF0uZ28oKTsKKyAgICB9CiAKICAgICBpZiAoZS5kYXRhLm1hdGNoKC9kYXRhPSJkb25l Ii8pICYmIHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKICAgICAgICAgbGF5b3V0VGVzdENv bnRyb2xsZXIubm90aWZ5RG9uZSgpOwpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zZWN1 cml0eS9wb3N0TWVzc2FnZS9yZXNvdXJjZXMvbWlkZGxlLWZyYW1lLWZvci1sZXhpY2FsLmh0bWwK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zZWN1cml0eS9wb3N0TWVzc2Fn ZS9yZXNvdXJjZXMvbWlkZGxlLWZyYW1lLWZvci1sZXhpY2FsLmh0bWwJKHJldmlzaW9uIDQ0MTI0 KQorKysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zZWN1cml0eS9wb3N0TWVzc2FnZS9yZXNvdXJj ZXMvbWlkZGxlLWZyYW1lLWZvci1sZXhpY2FsLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTgsMTkg KzgsMTMgQEAgZnVuY3Rpb24gZ28oKSB7CiAgICAgd2luLnBvc3RNZXNzYWdlKCdkb25lJywgJyon KTsKIH0KIAotZnVuY3Rpb24gdGVzdCgpIHsKLSAgICB2YXIgaWZyYW1lID0gZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoJ2NoaWxkJyk7Ci0gICAgdmFyIHdpbiA9IGlmcmFtZS5jb250ZW50V2luZG93 OwotICAgIHdpbi5wb3N0TWVzc2FnZSgncmVhZHknLCAnKicpOwotfQotCiBkb2N1bWVudC5kb21h aW4gPSAiMC4wLjEiOwogPC9zY3JpcHQ+CiA8Ym9keT4KIDxkaXY+d2luZG93LmxvY2F0aW9uLmhy ZWYgPSA8c2NyaXB0PmRvY3VtZW50LndyaXRlKHdpbmRvdy5sb2NhdGlvbi5ocmVmKTs8L3Njcmlw dD48L2Rpdj4KIDxkaXY+ZG9jdW1lbnQuZG9tYWluID0gPHNjcmlwdD5kb2N1bWVudC53cml0ZShk b2N1bWVudC5kb21haW4pOzwvc2NyaXB0PjwvZGl2PgotPGRpdj48aWZyYW1lIHNyYz0iaHR0cDov LzEyNy4wLjAuMTo4MDgwL3NlY3VyaXR5L3Bvc3RNZXNzYWdlL3Jlc291cmNlcy9wb3N0LW1lc3Nh Z2UtbGlzdGVuZXIuaHRtbCIgaWQ9ImNoaWxkIiB3aWR0aD0iODAwIiBoZWlnaHQ9IjMwMCIKLSAg c3R5bGU9ImJvcmRlcjogMXB4IHNvbGlkIGJsYWNrOyIgb25sb2FkPSJ0ZXN0KCkiPgorPGRpdj48 aWZyYW1lIHNyYz0iaHR0cDovLzEyNy4wLjAuMTo4MDgwL3NlY3VyaXR5L3Bvc3RNZXNzYWdlL3Jl c291cmNlcy9wb3N0LW1lc3NhZ2UtbGlzdGVuZXItd2l0aC1yZWFkeS5odG1sIiBpZD0iY2hpbGQi IHdpZHRoPSI4MDAiIGhlaWdodD0iMzAwIgorICBzdHlsZT0iYm9yZGVyOiAxcHggc29saWQgYmxh Y2s7Ij4KIDwvaWZyYW1lPjwvZGl2PgogPC9ib2R5PgogPC9odG1sPgpJbmRleDogTGF5b3V0VGVz dHMvaHR0cC90ZXN0cy9zZWN1cml0eS9wb3N0TWVzc2FnZS9yZXNvdXJjZXMvcG9zdC1tZXNzYWdl LWxpc3RlbmVyLXdpdGgtcmVhZHkuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRw L3Rlc3RzL3NlY3VyaXR5L3Bvc3RNZXNzYWdlL3Jlc291cmNlcy9wb3N0LW1lc3NhZ2UtbGlzdGVu ZXItd2l0aC1yZWFkeS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0 cy9zZWN1cml0eS9wb3N0TWVzc2FnZS9yZXNvdXJjZXMvcG9zdC1tZXNzYWdlLWxpc3RlbmVyLXdp dGgtcmVhZHkuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxOCBAQAorPCFET0NUWVBFIGh0 bWw+Cis8aHRtbD4KKzxib2R5PgorPGRpdj53aW5kb3cubG9jYXRpb24uaHJlZiA9IDxzY3JpcHQ+ ZG9jdW1lbnQud3JpdGUod2luZG93LmxvY2F0aW9uLmhyZWYpOzwvc2NyaXB0PjwvZGl2PgorPHNj cmlwdD4KK2Z1bmN0aW9uIHJlY3YoZSkgeworICAgIHZhciBtc2cgPSAnUmVjZWl2ZWQgbWVzc2Fn ZTogZGF0YT0iJyArIGUuZGF0YSArICciIG9yaWdpbj0iJyArIGUub3JpZ2luICsgJyInOworICAg IHRvcC5wb3N0TWVzc2FnZShtc2csICcqJyk7Cit9CisKK2FkZEV2ZW50TGlzdGVuZXIoIm1lc3Nh Z2UiLCByZWN2LCBmYWxzZSk7CisKK3dpbmRvdy5vbmxvYWQgPSBmdW5jdGlvbigpIHsKKyAgICB0 b3AucG9zdE1lc3NhZ2UoInJlYWR5IiwgIioiKTsKK30KKzwvc2NyaXB0PgorPC9ib2R5PgorPC9o dG1sPgo=