260074 2023-08-11 10:12:26 -0700 Updates special case for flex-box emulating webkit-box 2026-04-22 10:38:40 -0700 1 1 1 Unclassified WebKit Layout and Rendering Safari Technology Preview Unspecified Unspecified RESOLVED FIXED BrowserCompat, InRadar, WPTImpact P2 Normal --- 1 ahmad.saleem792 ahmad.saleem792 bfulgham karlcow sgill26 simon.fraser webkit-bug-importer zalan oldest_to_newest 1970732 0 ahmad.saleem792 2023-08-11 10:12:26 -0700 Hi Team, Came across another potential merge: Blink Commit: https://chromium-review.googlesource.com/c/chromium/src/+/1874250 Failing Test Case: https://wpt.fyi/results/compat/webkit-box-fieldset.html?label=experimental&label=master&aligned WPT Live Link: http://wpt.live/compat/webkit-box-fieldset.html In local build, doing following change leads to test progressing. So I think it is good win. Thanks! 1970736 1 ahmad.saleem792 2023-08-11 10:29:13 -0700 Expected to fail, but passed: (2) imported/w3c/web-platform-tests/compat/webkit-box-fieldset.html imported/w3c/web-platform-tests/compat/webkit-box-rtl-flex.html Regressions: Unexpected text-only failures (1) imported/w3c/web-platform-tests/compat/webkit-box-vertically-centered.html [ Failure ] ____ While running it on 'Compat' directory of WPT test cases. 1972075 2 webkit-bug-importer 2023-08-18 10:13:14 -0700 <rdar://problem/114094538> 1973811 3 ahmad.saleem792 2023-08-27 03:14:27 -0700 Tried this but didn't work: if ((parent()->isDeprecatedFlexibleBox() || (parent()->isFlexibleBox() && (parent()->style().display() == DisplayType::Box || parent()->style().display() == DisplayType::InlineBox))) && (parent()->style().boxOrient() == BoxOrient::Horizontal || parent()->style().boxAlign() != BoxAlignment::Stretch)) 2060050 4 karlcow 2024-09-13 10:31:28 -0700 What is happening here Safari FIELDSET: 966 x 10 (px) DIV: 0 x 10 (px) Firefox, Chrome FIELDSET: 966 x 10 (px) DIV: 966 x 10 (px) I wonder if it's partly related to https://github.com/WebKit/WebKit/blob/509e7900b3d9d995f089ad54ee3e813d0f1086ef/Source/WebCore/rendering/RenderBlock.cpp#L3194 void RenderBlock::layoutExcludedChildren(bool relayoutChildren) {} which has a lot of rules for Fieldset 2060255 5 ahmad.saleem792 2024-09-14 14:59:54 -0700 (In reply to Ahmad Saleem from comment #1) > Expected to fail, but passed: (2) > imported/w3c/web-platform-tests/compat/webkit-box-fieldset.html > imported/w3c/web-platform-tests/compat/webkit-box-rtl-flex.html > > > Regressions: Unexpected text-only failures (1) > imported/w3c/web-platform-tests/compat/webkit-box-vertically-centered.html > [ Failure ] > > ____ > > While running it on 'Compat' directory of WPT test cases. Just to flag, this is because of following: if (parent()->isRenderFlexibleBox() && (parent()->style().boxOrient() == BoxOrient::Horizontal || parent()->style().boxAlign() != BoxAlignment::Stretch)) 2060259 6 karlcow 2024-09-14 17:11:47 -0700 yes I tried to play with it a bit yesterday without success. 2203067 7 ahmad.saleem792 2026-04-22 00:06:04 -0700 Pull request: https://github.com/WebKit/WebKit/pull/63305 2203219 8 ews-feeder 2026-04-22 10:38:37 -0700 Committed 311784@main (cebb536ebef4): <https://commits.webkit.org/311784@main> Reviewed commits have been landed. Closing PR #63305 and removing active labels.