25999 2009-05-24 23:16:09 -0700 Chromium build bustage related to PassOwnPtr 2009-05-25 02:21:29 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fishd fishd ddkilzer oldest_to_newest 123002 0 fishd 2009-05-24 23:16:09 -0700 Chromium build bustage related to PassOwnPtr Changes: http://trac.webkit.org/changeset/44098 http://trac.webkit.org/changeset/44099 Build bustage observed here: http://build.chromium.org/buildbot/waterfall.fyi/builders/Webkit%20(webkit.org)/builds/4277/steps/compile/logs/stdio 123003 1 30641 fishd 2009-05-24 23:22:00 -0700 Created attachment 30641 v1 patch 123004 2 30641 mrowe 2009-05-24 23:25:53 -0700 Comment on attachment 30641 v1 patch Build fixes typically don't need review. 123006 3 fishd 2009-05-24 23:29:15 -0700 Landed as: http://trac.webkit.org/changeset/44123 123025 4 mjs 2009-05-25 02:21:29 -0700 Although review is not mandatory for build fixes, there's nothing wrong with getting review, especially if there are people around to look at the fix. 30641 2009-05-24 23:22:00 -0700 2009-05-24 23:25:53 -0700 v1 patch fix_1.txt text/plain 1185 fishd SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQ0MTIy KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDUt MjQgIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKQorCisgICAgICAgIEZpeCBidWlsZCBidXN0YWdlIHJlbGF0ZWQg dG8gUGFzc093blB0ciBjaGFuZ2VzLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yNTk5OQorCisgICAgICAgICogcGxhdGZvcm1cZ3JhcGhpY3NcY2hy b21pdW1cVHJhbnNwYXJlbmN5V2luLmNwcDoKKwogMjAwOS0wNS0yNCAgSG9sZ2VyIEhhbnMgUGV0 ZXIgRnJleXRoZXIgIDx6ZWNrZUBzZWxmaXNoLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBN YWNpZWogU3RhY2hvd2lhay4KSW5kZXg6IHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1RyYW5z cGFyZW5jeVdpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0v VHJhbnNwYXJlbmN5V2luLmNwcAkocmV2aXNpb24gNDQxMjIpCisrKyBwbGF0Zm9ybS9ncmFwaGlj cy9jaHJvbWl1bS9UcmFuc3BhcmVuY3lXaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDksNyAr MTA5LDcgQEAgY2xhc3MgVHJhbnNwYXJlbmN5V2luOjpPd25lZEJ1ZmZlcnMgewogcHVibGljOgog ICAgIE93bmVkQnVmZmVycyhjb25zdCBJbnRTaXplJiBzaXplLCBib29sIG5lZWRSZWZlcmVuY2VC dWZmZXIpCiAgICAgewotICAgICAgICBtX2Rlc3RCaXRtYXAuYWRvcHQoSW1hZ2VCdWZmZXI6OmNy ZWF0ZShzaXplLCBmYWxzZSkpOworICAgICAgICBtX2Rlc3RCaXRtYXAgPSBJbWFnZUJ1ZmZlcjo6 Y3JlYXRlKHNpemUsIGZhbHNlKTsKIAogICAgICAgICBpZiAobmVlZFJlZmVyZW5jZUJ1ZmZlcikg ewogICAgICAgICAgICAgbV9yZWZlcmVuY2VCaXRtYXAuc2V0Q29uZmlnKFNrQml0bWFwOjprQVJH Ql84ODg4X0NvbmZpZywgc2l6ZS53aWR0aCgpLCBzaXplLmhlaWdodCgpKTsK