25987 2009-05-24 00:34:08 -0700 [GTK] Clarify WebKitWebView::download-requested documentation 2009-05-24 00:49:57 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 xan.lopez webkit-unassigned oldest_to_newest 122918 0 xan.lopez 2009-05-24 00:34:08 -0700 I've been already asked a couple of times about WebKitWebView::download-requested being never emitted, so I think it's worth clarifying what's going on in the signal's documentation. Patch attached. 122919 1 30625 xan.lopez 2009-05-24 00:37:02 -0700 Created attachment 30625 downloadrequesteddoc.patch Improve documentation. 122921 2 30625 mrowe 2009-05-24 00:46:32 -0700 Comment on attachment 30625 downloadrequesteddoc.patch r=me 122922 3 xan.lopez 2009-05-24 00:49:57 -0700 Landed in r44113. 30625 2009-05-24 00:37:02 -0700 2009-05-24 00:46:32 -0700 downloadrequesteddoc.patch downloadrequesteddoc.patch text/plain 2630 xan.lopez RnJvbSBiYjJhZWU4MTUxZDM5YmY1NzA2OTk0MTc5YmM4NmRhMWQ5Yjk0MDJlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhsb3BlekBpZ2FsaWEuY29tPgpEYXRlOiBT dW4sIDI0IE1heSAyMDA5IDEwOjM1OjMzICswMzAwClN1YmplY3Q6IFtQQVRDSF0gMjAwOS0wNS0y NCAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CgogICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgoKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjU5ODcKICAgICAgICBbR1RLXSBDbGFyaWZ5IFdlYktpdFdlYlZpZXc6OmRvd25sb2Fk LXJlcXVlc3RlZCBkb2N1bWVudGF0aW9uCgogICAgICAgIEV4cGxhaW4gYSBiaXQgd2h5IHRoaXMg c2lnbmFsIGlzIG5vdCBlbWl0dGVkIGJ5IGRlZmF1bHQgYW5kIG9mZmVyCiAgICAgICAgYSBjb21t b24gc29sdXRpb24vc2V0dXAgZm9yIHRoYXQgaXNzdWUuCgogICAgICAgICogd2Via2l0L3dlYmtp dHdlYnZpZXcuY3BwOgogICAgICAgICh3ZWJraXRfd2ViX3ZpZXdfY2xhc3NfaW5pdCk6Ci0tLQog V2ViS2l0L2d0ay9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgfCAgIDEzICsrKysrKysrKysrKysK IFdlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwIHwgICAxMSArKysrKysrKysrKwog MiBmaWxlcyBjaGFuZ2VkLCAyNCBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXgg NGY0ZDU4YS4uMWFkMTZiZCAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIv V2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wNS0yNCAgWGFuIExv cGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTI1OTg3CisgICAgICAgIFtHVEtdIENsYXJpZnkgV2ViS2l0V2ViVmlldzo6ZG93bmxvYWQtcmVx dWVzdGVkIGRvY3VtZW50YXRpb24KKworICAgICAgICBFeHBsYWluIGEgYml0IHdoeSB0aGlzIHNp Z25hbCBpcyBub3QgZW1pdHRlZCBieSBkZWZhdWx0IGFuZCBvZmZlcgorICAgICAgICBhIGNvbW1v biBzb2x1dGlvbi9zZXR1cCBmb3IgdGhhdCBpc3N1ZS4KKworICAgICAgICAqIHdlYmtpdC93ZWJr aXR3ZWJ2aWV3LmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfdmlld19jbGFzc19pbml0KToKKwog MjAwOS0wNS0yMyAgSmFuIE1pY2hhZWwgQWxvbnpvICA8am1hbG9uem9Ad2Via2l0Lm9yZz4KIAog ICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBHdXN0YXZvIE5vcm9uaGEuCmRpZmYgLS1naXQgYS9X ZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcCBiL1dlYktpdC9ndGsvd2Via2l0L3dl YmtpdHdlYnZpZXcuY3BwCmluZGV4IGJkZTM3NzcuLjVjNmE3OGQgMTAwNjQ0Ci0tLSBhL1dlYktp dC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCisrKyBiL1dlYktpdC9ndGsvd2Via2l0L3dl YmtpdHdlYnZpZXcuY3BwCkBAIC0xMjYyLDYgKzEyNjIsMTcgQEAgc3RhdGljIHZvaWQgd2Via2l0 X3dlYl92aWV3X2NsYXNzX2luaXQoV2ViS2l0V2ViVmlld0NsYXNzKiB3ZWJWaWV3Q2xhc3MpCiAg ICAgICogdGhlICNXZWJLaXREb3dubG9hZCBoZWxwZXIgb2JqZWN0IHlvdSBtdXN0IGhhbmRsZSB0 aGlzIHNpZ25hbCwKICAgICAgKiBhbmQgcmV0dXJuICVGQUxTRS4KICAgICAgKgorICAgICAqIEFs c28sIGtlZXAgaW4gbWluZCB0aGF0IHRoZSBkZWZhdWx0IHBvbGljeSBmb3IgV2ViS2l0R1RLKyBp cyB0bworICAgICAqIGlnbm9yZSBmaWxlcyB3aXRoIGEgTUlNRSB0eXBlIHRoYXQgaXQgZG9lcyBu b3Qga25vdyBob3cgdG8KKyAgICAgKiBoYW5kbGUsIHdoaWNoIHRoaXMgbWVhbnMgdGhpcyBzaWdu YWwgd29uJ3QgYmUgZW1pdHRlZCBpbiB0aGUKKyAgICAgKiBkZWZhdWx0IHNldHVwLiBPbmUgd2F5 IHRvIHRyaWdnZXIgZG93bmxvYWRzIGlzIHRvIGNvbm5lY3QgdG8KKyAgICAgKiBXZWJLaXRXZWJW aWV3OjptaW1lLXR5cGUtcG9saWN5LWRlY2lzaW9uLXJlcXVlc3RlZCBhbmQgY2FsbAorICAgICAq IHdlYmtpdF93ZWJfcG9saWN5X2RlY2lzaW9uX2Rvd25sb2FkKCkgb24gdGhlCisgICAgICogI1dl YktpdFdlYlBvbGljeURlY2lzaW9uIGluIHRoZSBwYXJhbWV0ZXIgbGlzdCBmb3IgdGhlIGtpbmQg b2YKKyAgICAgKiBmaWxlcyB5b3Ugd2FudCB5b3VyIGFwcGxpY2F0aW9uIHRvIGRvd25sb2FkIChh IGNvbW1vbiBzb2x1dGlvbgorICAgICAqIGlzIHRvIGRvd25sb2FkIGFueXRoaW5nIHRoYXQgV2Vi S2l0IGNhbid0IGhhbmRsZSwgd2hpY2ggeW91IGNhbgorICAgICAqIGZpZ3VyZSBvdXQgYnkgdXNp bmcgd2Via2l0X3dlYl92aWV3X2Nhbl9zaG93X21pbWVfdHlwZSgpKS4KKyAgICAgKgogICAgICAq IFNpbmNlOiAxLjEuMgogICAgICAqLwogICAgIHdlYmtpdF93ZWJfdmlld19zaWduYWxzW0RPV05M T0FEX1JFUVVFU1RFRF0gPSBnX3NpZ25hbF9uZXcoImRvd25sb2FkLXJlcXVlc3RlZCIsCi0tIAox LjYuMi4yCgo=