259729 2023-08-02 03:46:01 -0700 Fails to build with GCC 13 due to overloaded-virtual error in FilterEffect 2023-08-03 04:17:17 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cgarcia cgarcia sabouhallawa simon.fraser webkit-bug-importer oldest_to_newest 1969225 0 cgarcia 2023-08-02 03:46:01 -0700 In file included from WebKit/Source/WebCore/platform/graphics/filters/FilterResults.h:28, from WebKit/Source/WebCore/rendering/svg/RenderSVGResourceFilter.h:26, from WebKit/Source/WebCore/svg/SVGFilterPrimitiveStandardAttributes.h:25, from WebKit/Source/WebCore/svg/SVGFEBlendElement.h:26, from WebKit/WebKitBuild/Release/WebCore/DerivedSources/SVGElementFactory.cpp:49, from WebKit/WebKitBuild/Release/WebCore/DerivedSources/unified-sources/UnifiedSource-3a52ce78-171.cpp:5: WebKit/Source/WebCore/platform/graphics/filters/FilterEffect.h:44:18: error: ‘virtual bool WebCore::FilterEffect::operator==(const WebCore::FilterEffect&) const’ was hidden [-Werror=overloaded-virtual=] 44 | virtual bool operator==(const FilterEffect&) const; | ^~~~~~~~ In file included from WebKit/Source/WebCore/platform/graphics/filters/FESpecularLighting.h:25, from WebKit/Source/WebCore/platform/graphics/filters/FESpecularLighting.h:25, from WebKit/Source/WebCore/svg/SVGFESpecularLightingElement.h:25, from WebKit/WebKitBuild/Release/WebCore/DerivedSources/SVGElementFactory.cpp:70: WebKit/Source/WebCore/platform/graphics/filters/FELighting.h:42:10: note: by ‘bool WebCore::FELighting::operator==(const WebCore::FELighting&) const’ 42 | bool operator==(const FELighting&) const; | ^~~~~~~~ 1969226 1 cgarcia 2023-08-02 03:50:55 -0700 I fixed it by overriding operator== in FELighting.h and just returning false, since it shouldn't be called, if I understood it correctly, because FELighting is abstract. I don't know if that's the right fix, though. 1969229 2 cgarcia 2023-08-02 04:02:38 -0700 Pull request: https://github.com/WebKit/WebKit/pull/16310 1969427 3 ews-feeder 2023-08-03 04:16:15 -0700 Committed 266539@main (c85962a5c0e9): <https://commits.webkit.org/266539@main> Reviewed commits have been landed. Closing PR #16310 and removing active labels. 1969428 4 webkit-bug-importer 2023-08-03 04:17:17 -0700 <rdar://problem/113326293>