259620 2023-07-28 18:24:07 -0700 'hr' with width as 0 or 0px get 1px leading to WPT failure 2023-07-29 16:05:17 -0700 1 1 1 Unclassified WebKit DOM Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar, WPTImpact P2 Normal --- 1 ahmad.saleem792 webkit-unassigned akeerthi karlcow ntim rniwa webkit-bug-importer oldest_to_newest 1968721 0 ahmad.saleem792 2023-07-28 18:24:07 -0700 Hi Team, While trying to investigate our WPT failures in HTML/Rendering for 'dimension-attributes.html', I came across following: Test Case: http://wpt.live/html/rendering/dimension-attributes.html For following two cases: 1) <hr width="0"> mapping to <hr> width property 2) <hr width="0px"> mapping to <hr> width property We get 1px due to following: https://github.com/WebKit/WebKit/blob/088b5a6b92a887bbf29d18135987d5c2c6392d20/Source/WebCore/html/HTMLHRElement.cpp#L89 Where we are forcing 1px: addPropertyToPresentationalHintStyle(style, CSSPropertyWidth, 1, CSSUnitType::CSS_PX); Changing it to '0' leads to two progressions. Only Firefox passes these tests and Chrome Canary 117 also fail them. ______ I just wanted to raise and get input whether it is good to go so I can do PR or there are other consequences of this change. Thanks! 1968732 1 ntim 2023-07-28 23:08:05 -0700 > Changing it to '0' leads to two progressions. Seems fine, visually it doesn't seem to make a huge difference. 1968780 2 ews-feeder 2023-07-29 16:04:29 -0700 Committed 266418@main (57717fd0d5ab): <https://commits.webkit.org/266418@main> Reviewed commits have been landed. Closing PR #16216 and removing active labels. 1968781 3 webkit-bug-importer 2023-07-29 16:05:17 -0700 <rdar://problem/113087533>