25962 2009-05-22 07:17:15 -0700 wx port lacks triple click selection 2009-06-01 23:53:12 -0700 1 1 1 Unclassified WebKit WebKit wx 528+ (Nightly build) PC All RESOLVED FIXED P2 Minor --- 1 kevinwatters abarth oldest_to_newest 122654 0 kevinwatters 2009-05-22 07:17:15 -0700 The wx port is not creating PlatformMouseEvents with click counts of 3, so it lacks triple click paragraph selection. 122655 1 30580 kevinwatters 2009-05-22 07:17:47 -0700 Created attachment 30580 use a timer to catch triple clicks and create PlatformMouseEvents accordingly 122657 2 30580 eric 2009-05-22 07:25:31 -0700 Comment on attachment 30580 use a timer to catch triple clicks and create PlatformMouseEvents accordingly Looks sane enough. Where is the test case? I assume Wx doesn't support DRT eventSender yet? Otherwise you should be able to easily write a test which tests this. r- for the lack of test case (or lack of ChangeLog explanation for why there isn't one). If it's not possible to test this yet, please file a bug about adding support to Wx's DumpRenderTree. Otherwise the patch looks fine and I would r+ it (or anyone else should feel free to) with the updated ChangeLog or test case. 122727 3 kevino 2009-05-22 13:20:17 -0700 r+ from me. I've filed a meta bug on wx's DRT (https://bugs.webkit.org/show_bug.cgi?id=25967), and I really think that's all that's needed for now. 123943 4 abarth 2009-06-01 23:49:58 -0700 Will land. 123945 5 abarth 2009-06-01 23:53:12 -0700 This appears to already have been committed. 30580 2009-05-22 07:17:47 -0700 2009-05-22 13:15:45 -0700 use a timer to catch triple clicks and create PlatformMouseEvents accordingly triple_click.patch text/plain 6458 kevinwatters SW5kZXg6IFdlYktpdC93eC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3d4L0NoYW5n ZUxvZwkocmV2aXNpb24gNDQwMzMpCisrKyBXZWJLaXQvd3gvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDktMDUtMjEgIEtldmluIFdhdHRlcnMgIDxrZXZpbndh dHRlcnNAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor ICAgICAgICAKKyAgICAgICAgVHJpcGxlLWNsaWNrIHN1cHBvcnQgZm9yIHd4IHBvcnQuIEFsc28s IHN3aXRjaCB0byBhbGxvY2F0aW5nIEdyYXBoaWNzQ29udGV4dAorICAgICAgICBvbiB0aGUgc3Rh Y2sgaW4gT25QYWludCBzaW5jZSB3ZSBvbmx5IG5lZWQgaXQgd2l0aGluIHRoYXQgZnVuY3Rpb24u CisKKyAgICAgICAgKiBXZWJWaWV3LmNwcDoKKyAgICAgICAgKHd4V2ViVmlldzo6T25QYWludCk6 CisgICAgICAgIChnZXREb3VibGVDbGlja1RpbWUpOgorICAgICAgICAod3hXZWJWaWV3OjpPbk1v dXNlRXZlbnRzKToKKyAgICAgICAgKHd4V2ViVmlldzo6T25Db250ZXh0TWVudUV2ZW50cyk6Cisg ICAgICAgICogV2ViVmlldy5oOgorICAgICAgICAqIFdlYlZpZXdQcml2YXRlLmg6CisKIDIwMDkt MDUtMjEgIEtldmluIE9sbGl2aWVyICA8a2V2aW5vQHRoZW9sbGl2aWVycy5jb20+CiAKICAgICAg ICAgd3ggYnVpbGQgZml4IGFmdGVyIG1ldGhvZCBhZGRlZCB0byBFZGl0b3JDbGllbnQuCkluZGV4 OiBXZWJLaXQvd3gvV2ViVmlldy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3d4L1dlYlZpZXcu Y3BwCShyZXZpc2lvbiA0NDAxNikKKysrIFdlYktpdC93eC9XZWJWaWV3LmNwcAkod29ya2luZyBj b3B5KQpAQCAtNTEwLDE3ICs1MTAsMTYgQEAKICAgICAgICAgICAgIHBhaW50UmVjdC5PZmZzZXQo b2Zmc2V0LndpZHRoKCksIG9mZnNldC5oZWlnaHQoKSk7CiAKICNpZiBVU0UoV1hHQykKLSAgICAg ICAgICAgIFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dCogZ2MgPSBuZXcgV2ViQ29yZTo6R3JhcGhp Y3NDb250ZXh0KCZnY2RjKTsKKyAgICAgICAgICAgIFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dCBn YygmZ2NkYyk7CiAjZWxzZQotICAgICAgICAgICAgV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0KiBn YyA9IG5ldyBXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQoKHd4V2luZG93REMqKSZkYyk7CisgICAg ICAgICAgICBXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQgZ2MoJmRjKTsKICNlbmRpZgotICAgICAg ICAgICAgaWYgKGdjICYmIGZyYW1lLT5jb250ZW50UmVuZGVyZXIoKSkgeworICAgICAgICAgICAg aWYgKGZyYW1lLT5jb250ZW50UmVuZGVyZXIoKSkgewogICAgICAgICAgICAgICAgIGlmIChmcmFt ZS0+dmlldygpLT5uZWVkc0xheW91dCgpKQogICAgICAgICAgICAgICAgICAgICBmcmFtZS0+dmll dygpLT5sYXlvdXQoKTsKIAotICAgICAgICAgICAgICAgIGZyYW1lLT52aWV3KCktPnBhaW50Q29u dGVudHMoZ2MsIHBhaW50UmVjdCk7CisgICAgICAgICAgICAgICAgZnJhbWUtPnZpZXcoKS0+cGFp bnRDb250ZW50cygmZ2MsIHBhaW50UmVjdCk7CiAgICAgICAgICAgICB9Ci0gICAgICAgICAgICBk ZWxldGUgZ2M7CiAgICAgICAgIH0KICAgICB9CiB9CkBAIC01NDUsMTAgKzU0NCwyMiBAQAogICAg IGV2ZW50LlNraXAoKTsKIH0KIAorc3RhdGljIGludCBnZXREb3VibGVDbGlja1RpbWUoKQorewor I2lmIF9fV1hNU1dfXworICAgIHJldHVybiA6OkdldERvdWJsZUNsaWNrVGltZSgpOworI2Vsc2UK KyAgICByZXR1cm4gNTAwOworI2VuZGlmCit9CisKIHZvaWQgd3hXZWJWaWV3OjpPbk1vdXNlRXZl bnRzKHd4TW91c2VFdmVudCYgZXZlbnQpCiB7CiAgICAgZXZlbnQuU2tpcCgpOwogICAgIAorICAg IGlmIChtX2JlaW5nRGVzdHJveWVkKQorICAgICAgICByZXR1cm47CisgICAgCiAgICAgaWYgKCFt X21haW5GcmFtZSkKICAgICAgICAgcmV0dXJuOyAKICAgICAgICAgCkBAIC01NjYsOCArNTc3LDIx IEBACiAgICAgICAgIHJldHVybjsKICAgICB9CiAgICAgCi0gICAgV2ViQ29yZTo6UGxhdGZvcm1N b3VzZUV2ZW50IHdrRXZlbnQoZXZlbnQsIGdsb2JhbFBvaW50KTsKKyAgICBpbnQgY2xpY2tDb3Vu dCA9IGV2ZW50LkJ1dHRvbkRDbGljaygpID8gMiA6IDE7CiAKKyAgICBpZiAoY2xpY2tDb3VudCA9 PSAxICYmIG1faW1wbC0+dHJpcGxlQ2xpY2tUaW1lci5Jc1J1bm5pbmcoKSkgeworICAgICAgICB3 eFBvaW50IGRpZmYoZXZlbnQuR2V0UG9zaXRpb24oKSAtIG1faW1wbC0+dHJpcGxlQ2xpY2tQb3Mp OworICAgICAgICBpZiAoYWJzKGRpZmYueCkgPD0gd3hTeXN0ZW1TZXR0aW5nczo6R2V0TWV0cmlj KHd4U1lTX0RDTElDS19YKSAmJgorICAgICAgICAgICAgYWJzKGRpZmYueSkgPD0gd3hTeXN0ZW1T ZXR0aW5nczo6R2V0TWV0cmljKHd4U1lTX0RDTElDS19ZKSkgeworICAgICAgICAgICAgY2xpY2tD b3VudCA9IDM7CisgICAgICAgIH0KKyAgICB9IGVsc2UgaWYgKGNsaWNrQ291bnQgPT0gMikgewor ICAgICAgICBtX2ltcGwtPnRyaXBsZUNsaWNrVGltZXIuU3RhcnQoZ2V0RG91YmxlQ2xpY2tUaW1l KCksIGZhbHNlKTsKKyAgICAgICAgbV9pbXBsLT50cmlwbGVDbGlja1BvcyA9IGV2ZW50LkdldFBv c2l0aW9uKCk7CisgICAgfQorICAgIAorICAgIFdlYkNvcmU6OlBsYXRmb3JtTW91c2VFdmVudCB3 a0V2ZW50KGV2ZW50LCBnbG9iYWxQb2ludCwgY2xpY2tDb3VudCk7CisKICAgICBpZiAodHlwZSA9 PSB3eEVWVF9MRUZUX0RPV04gfHwgdHlwZSA9PSB3eEVWVF9NSURETEVfRE9XTiB8fCB0eXBlID09 IHd4RVZUX1JJR0hUX0RPV04gfHwgCiAgICAgICAgICAgICAgICAgdHlwZSA9PSB3eEVWVF9MRUZU X0RDTElDSyB8fCB0eXBlID09IHd4RVZUX01JRERMRV9EQ0xJQ0sgfHwgdHlwZSA9PSB3eEVWVF9S SUdIVF9EQ0xJQ0spCiAgICAgICAgIGZyYW1lLT5ldmVudEhhbmRsZXIoKS0+aGFuZGxlTW91c2VQ cmVzc0V2ZW50KHdrRXZlbnQpOwpAQCAtNTk1LDcgKzYxOSw3IEBACiAgICAgd3hNb3VzZUV2ZW50 IG1vdXNlRXZlbnQod3hFVlRfUklHSFRfRE9XTik7CiAgICAgbW91c2VFdmVudC5tX3ggPSBsb2Nh bEV2ZW50UG9pbnQueDsKICAgICBtb3VzZUV2ZW50Lm1feSA9IGxvY2FsRXZlbnRQb2ludC55Owot ICAgIFdlYkNvcmU6OlBsYXRmb3JtTW91c2VFdmVudCB3a0V2ZW50KG1vdXNlRXZlbnQsIGV2ZW50 LkdldFBvc2l0aW9uKCkpOworICAgIFdlYkNvcmU6OlBsYXRmb3JtTW91c2VFdmVudCB3a0V2ZW50 KG1vdXNlRXZlbnQsIGV2ZW50LkdldFBvc2l0aW9uKCksIDEpOwogCiAgICAgYm9vbCBoYW5kbGVk RXZlbnQgPSBmb2N1c2VkRnJhbWUtPmV2ZW50SGFuZGxlcigpLT5zZW5kQ29udGV4dE1lbnVFdmVu dCh3a0V2ZW50KTsKICAgICBpZiAoIWhhbmRsZWRFdmVudCkKSW5kZXg6IFdlYktpdC93eC9XZWJW aWV3UHJpdmF0ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93eC9XZWJWaWV3UHJpdmF0ZS5oCShy ZXZpc2lvbiA0NDAxNikKKysrIFdlYktpdC93eC9XZWJWaWV3UHJpdmF0ZS5oCSh3b3JraW5nIGNv cHkpCkBAIC0zNSw2ICszNSw4IEBACiAjaW5jbHVkZSAid3RmL1JlZlB0ci5oIgogI2luY2x1ZGUg IktVUkwuaCIKIAorI2luY2x1ZGUgPHd4L3RpbWVyLmg+CisKIGNsYXNzIFdlYlZpZXdQcml2YXRl IAogewogcHVibGljOgpAQCAtNDMsNiArNDUsOSBAQAogICAgIHt9CiAgICAgCiAgICAgV2ViQ29y ZTo6UGFnZSogcGFnZTsKKworICAgIHd4VGltZXIgdHJpcGxlQ2xpY2tUaW1lcjsKKyAgICB3eFBv aW50IHRyaXBsZUNsaWNrUG9zOwogfTsKIAogY2xhc3MgV2ViVmlld0ZyYW1lRGF0YQpJbmRleDog V2ViS2l0L3d4L1dlYlZpZXcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvd3gvV2ViVmlldy5oCShy ZXZpc2lvbiA0NDAxNikKKysrIFdlYktpdC93eC9XZWJWaWV3LmgJKHdvcmtpbmcgY29weSkKQEAg LTEwOCw3ICsxMDgsNyBAQAogICAgICAgICAgICAgICAgIGNvbnN0IHd4U3RyaW5nJiBuYW1lID0g d3hXZWJWaWV3TmFtZVN0cik7IC8vIEZvciB3eFdlYlZpZXcgaW50ZXJuYWwgZGF0YSBwYXNzaW5n CiAgICAgCiAjaWZuZGVmIFNXSUcKLSAgICB+d3hXZWJWaWV3KCk7CisgICAgdmlydHVhbCB+d3hX ZWJWaWV3KCk7CiAjZW5kaWYKICAgICAKICAgICB2b2lkIExvYWRVUkwoY29uc3Qgd3hTdHJpbmcm IHVybCk7CkBAIC0xNTgsNyArMTU4LDcgQEAKICAgICAKICAgICB3eFdlYkZyYW1lKiBHZXRNYWlu RnJhbWUoKSB7IHJldHVybiBtX21haW5GcmFtZTsgfQogCi0gICAgd3hXZWJWaWV3RE9NRWxlbWVu dEluZm8gSGl0VGVzdChjb25zdCB3eFBvaW50JiBwb3N0KSBjb25zdDsKKyAgICB3eFdlYlZpZXdE T01FbGVtZW50SW5mbyBIaXRUZXN0KGNvbnN0IHd4UG9pbnQmIHBvcykgY29uc3Q7CiAKIHByb3Rl Y3RlZDoKIApJbmRleDogV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9D aGFuZ2VMb2cJKHJldmlzaW9uIDQ0MDMzKQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcg Y29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0wNS0yMSAgS2V2aW4gV2F0dGVycyAgPGtldmlu d2F0dGVyc0BnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVHJpcGxlLWNsaWNrIHN1cHBvcnQgZm9yIHd4V2ViS2l0LgorCisgICAgICAg ICogcGxhdGZvcm0vUGxhdGZvcm1Nb3VzZUV2ZW50Lmg6CisgICAgICAgICogcGxhdGZvcm0vd3gv TW91c2VFdmVudFd4LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBsYXRmb3JtTW91c2VFdmVudDo6 UGxhdGZvcm1Nb3VzZUV2ZW50KToKKwogMjAwOS0wNS0yMSAgU3RlcGhhbmllIExld2lzICA8c2xl d2lzQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYXJrIFJvd2UuCkluZGV4OiBX ZWJDb3JlL3BsYXRmb3JtL3d4L01vdXNlRXZlbnRXeC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9wbGF0Zm9ybS93eC9Nb3VzZUV2ZW50V3guY3BwCShyZXZpc2lvbiA0NDAxNikKKysrIFdlYkNv cmUvcGxhdGZvcm0vd3gvTW91c2VFdmVudFd4LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzMsNyAr MzMsNyBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLVBsYXRmb3JtTW91c2VFdmVudDo6UGxh dGZvcm1Nb3VzZUV2ZW50KGNvbnN0IHd4TW91c2VFdmVudCYgZXZlbnQsIGNvbnN0IHd4UG9pbnQm IGdsb2JhbFBvaW50KQorUGxhdGZvcm1Nb3VzZUV2ZW50OjpQbGF0Zm9ybU1vdXNlRXZlbnQoY29u c3Qgd3hNb3VzZUV2ZW50JiBldmVudCwgY29uc3Qgd3hQb2ludCYgZ2xvYmFsUG9pbnQsIGludCBj bGlja0NvdW50KQogICAgIDogbV9wb3NpdGlvbihldmVudC5HZXRQb3NpdGlvbigpKQogICAgICwg bV9nbG9iYWxQb3NpdGlvbihnbG9iYWxQb2ludCkKICAgICAsIG1fc2hpZnRLZXkoZXZlbnQuU2hp ZnREb3duKCkpCkBAIC02Nyw3ICs2Nyw3IEBACiAgICAgaWYgKG1fZXZlbnRUeXBlID09IE1vdXNl RXZlbnRNb3ZlZCkKICAgICAgICAgbV9jbGlja0NvdW50ID0gMDsKICAgICBlbHNlCi0gICAgICAg IG1fY2xpY2tDb3VudCA9IGV2ZW50LkJ1dHRvbkRDbGljaygpID8gMiA6IDE7CisgICAgICAgIG1f Y2xpY2tDb3VudCA9IGNsaWNrQ291bnQ7CiAKICAgICBtX3RpbWVzdGFtcCA9IFdURjo6Y3VycmVu dFRpbWUoKTsKIH0KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vUGxhdGZvcm1Nb3VzZUV2ZW50LmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9QbGF0Zm9ybU1vdXNlRXZlbnQuaAkocmV2 aXNpb24gNDQwMTYpCisrKyBXZWJDb3JlL3BsYXRmb3JtL1BsYXRmb3JtTW91c2VFdmVudC5oCSh3 b3JraW5nIGNvcHkpCkBAIC0xMzMsNyArMTMzLDcgQEAKICNlbmRpZgogCiAjaWYgUExBVEZPUk0o V1gpCi0gICAgICAgIFBsYXRmb3JtTW91c2VFdmVudChjb25zdCB3eE1vdXNlRXZlbnQmLCBjb25z dCB3eFBvaW50JiBnbG9iYWxQb2ludCk7CisgICAgICAgIFBsYXRmb3JtTW91c2VFdmVudChjb25z dCB3eE1vdXNlRXZlbnQmLCBjb25zdCB3eFBvaW50JiBnbG9iYWxQb2ludCwgaW50IGNsaWNrQ291 bnQpOwogI2VuZGlmCiAKIAo=