25946 2009-05-21 13:40:21 -0700 Chromium needs MIMETypeRegistry::getMediaMIMETypeForExtension implementation. 2009-05-21 14:20:46 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 levin levin fishd oldest_to_newest 122410 0 levin 2009-05-21 13:40:21 -0700 See summary. 122414 1 30554 levin 2009-05-21 13:43:28 -0700 Created attachment 30554 Proposed fix. 122419 2 30555 levin 2009-05-21 14:06:43 -0700 Created attachment 30555 Proposed fix. 122422 3 30555 fishd 2009-05-21 14:11:38 -0700 Comment on attachment 30555 Proposed fix. Looking at MediaPlayer.cpp, it really doesn't matter what we do here. In fact, the cost of getMIMETypeForExtension might not even be worth it. MediaPlayer only calls this function to take a guess at the mime type, which it then uses to help select the media player engine. Chromium only has one engine, so the guessed mime type is not interesting to us. R=me with either the current solution or just returning String() <-- i'd probably just return String(). 122423 4 levin 2009-05-21 14:20:46 -0700 http://trac.webkit.org/changeset/43981 30554 2009-05-21 13:43:28 -0700 2009-05-21 14:06:43 -0700 Proposed fix. bug25946.txt text/plain 4950 levin ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjNlZmIyNy4uZjEwYjlmNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0wNS0yMSAgRGF2aWQgTGV2aW4g IDxsZXZpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQnVnIDI1OTQ2OiBDaHJvbWl1bSBuZWVkcyBNSU1FVHlwZVJlZ2lzdHJ5 OjpnZXRNZWRpYU1JTUVUeXBlRm9yRXh0ZW5zaW9uIGltcGxlbWVudGF0aW9uLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjU5NDYKKworICAgICAgICBN aXJyb3JzIGZ1bmN0aW9uYWxpdHkgZG9uZSBpbiByNDM5NzIgZm9yIE1JTUVUeXBlUmVnaXN0cnku Y3BwLgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vTWltZVR5cGVSZWdpc3RyeUNocm9t aXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmluaXRpYWxpemVNZWRpYVR5cGVNYXBzKToKKyAg ICAgICAgKFdlYkNvcmU6OlR5cGVFeHRlbnNpb25QYWlyOjopOgorICAgICAgICAoV2ViQ29yZTo6 TUlNRVR5cGVSZWdpc3RyeTo6Z2V0TWVkaWFNSU1FVHlwZUZvckV4dGVuc2lvbik6CisKIDIwMDkt MDUtMjEgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IERhdmlkIEtpbHplci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vY2hy b21pdW0vTWltZVR5cGVSZWdpc3RyeUNocm9taXVtLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vY2hy b21pdW0vTWltZVR5cGVSZWdpc3RyeUNocm9taXVtLmNwcAppbmRleCAxYWFjNWVjLi40OGYzZjVm IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL01pbWVUeXBlUmVnaXN0cnlD aHJvbWl1bS5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9NaW1lVHlwZVJlZ2lz dHJ5Q2hyb21pdW0uY3BwCkBAIC0xLDUgKzEsNiBAQAogLyoKICAqIENvcHlyaWdodCAoYykgMjAw OCwgMjAwOSwgR29vZ2xlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAo QykgMjAwOSBBcHBsZSBJbmMuICBBbGwgcmlnaHRzIHJlc2VydmVkLgogICogCiAgKiBSZWRpc3Ry aWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhv dXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xs b3dpbmcgY29uZGl0aW9ucyBhcmUKQEAgLTM1LDYgKzM2LDggQEAKICNpbmNsdWRlICJDU3RyaW5n LmgiCiAjaW5jbHVkZSAiTWVkaWFQbGF5ZXIuaCIKIAorI2luY2x1ZGUgPHd0Zi9IYXNoTWFwLmg+ CisKIC8vIE5PVEU6IFVubGlrZSBvdGhlciBwb3J0cywgd2UgZG9uJ3QgdXNlIHRoZSBzaGFyZWQg aW1wbGVtZW50YXRpb24gYml0cyBpbgogLy8gTUlNRVR5cGVSZWdpc3RyeS5jcHAuICBJbnN0ZWFk LCB3ZSBuZWVkIHRvIHJvdXRlIG1vc3QgZnVuY3Rpb25zIHZpYSB0aGUKIC8vIENocm9taXVtQnJp ZGdlIHRvIHRoZSBlbWJlZGRlci4KQEAgLTEyNyw2ICsxMzAsMTAzIEBAIGJvb2wgTUlNRVR5cGVS ZWdpc3RyeTo6aXNKYXZhQXBwbGV0TUlNRVR5cGUoY29uc3QgU3RyaW5nJiBtaW1lVHlwZSkKICAg ICAgICAgfHwgbWltZVR5cGUuc3RhcnRzV2l0aCgiYXBwbGljYXRpb24veC1qYXZhLXZtIiwgZmFs c2UpOwogfQogCitzdGF0aWMgdm9pZCBpbml0aWFsaXplTWVkaWFUeXBlTWFwcygpCit7CisgICAg c3RydWN0IFR5cGVFeHRlbnNpb25QYWlyIHsKKyAgICAgICAgY29uc3QgY2hhciogdHlwZTsKKyAg ICAgICAgY29uc3QgY2hhciogZXh0ZW5zaW9uOworICAgIH07CisKKyAgICAvLyBBIHRhYmxlIG9m IGNvbW1vbiBtZWRpYSBNSU1FIHR5cGVzIGFuZCBmaWxlIGV4dGVuc3Rpb25zIHVzZWQgd2hlbiBh IHBsYXRmb3JtJ3MKKyAgICAvLyBzcGVjaWZpYyBNSU1FIHR5cGUgbG9va3VwIGRvZW5zJ3QgaGF2 ZSBhIG1hdGNoIGZvciBhIG1lZGlhIGZpbGUgZXh0ZW5zaW9uLiBXaGlsZSBzb21lCisgICAgLy8g ZmlsZSBleHRlbnNpb25zIGFyZSBjbGFpbWVkIGJ5IG11bHRpcGxlIE1JTUUgdHlwZXMsIHRoaXMg dGFibGUgb25seSBpbmNsdWRlcyBvbmUgCisgICAgLy8gZm9yIGVhY2ggYmVjYXVzZSBpdCBpcyBj dXJyZW50bHkgb25seSB1c2VkIGJ5IGdldE1lZGlhTUlNRVR5cGVGb3JFeHRlbnNpb24uIElmIHdl CisgICAgLy8gZXZlciBhZGQgYSBNSU1FIHR5cGUgLT4gZmlsZSBleHRlbnNpb24gbWFwcGluZywg dGhlIGFsdGVybmF0ZSBNSU1FIHR5cGVzIHdpbGwgbmVlZAorICAgIC8vIHRvIGJlIGFkZGVkLgor ICAgIHN0YXRpYyBjb25zdCBUeXBlRXh0ZW5zaW9uUGFpciBwYWlyc1tdID0geworICAgIAorICAg ICAgICAvLyBPZ2cKKyAgICAgICAgeyAiYXBwbGljYXRpb24vb2dnIiwgIm9nZyIgfSwKKyAgICAg ICAgeyAiYXBwbGljYXRpb24vb2dnIiwgIm9neCIgfSwKKyAgICAgICAgeyAiYXVkaW8vb2dnIiwg Im9nYSIgfSwKKyAgICAgICAgeyAidmlkZW8vb2dnIiwgIm9ndiIgfSwKKworICAgICAgICAvLyBB bm5vZGV4CisgICAgICAgIHsgImFwcGxpY2F0aW9uL2Fubm9kZXgiLCAiYW54IiB9LAorICAgICAg ICB7ICJhdWRpby9hbm5vZGV4IiwgImF4YSIgfSwKKyAgICAgICAgeyAidmlkZW8vYW5ub2RleCIs ICJheHYiIH0sCisgICAgICAgIHsgImF1ZGlvL3NwZWV4IiwgInNweCIgfSwKKworICAgICAgICAv LyBNUEVHCisgICAgICAgIHsgImF1ZGlvL21wZWciLCAibTFhIiB9LAorICAgICAgICB7ICJhdWRp by9tcGVnIiwgIm0yYSIgfSwKKyAgICAgICAgeyAiYXVkaW8vbXBlZyIsICJtMXMiIH0sCisgICAg ICAgIHsgImF1ZGlvL21wZWciLCAibXBhIiB9LAorICAgICAgICB7ICJ2aWRlby9tcGVnIiwgIm1w ZyIgfSwKKyAgICAgICAgeyAidmlkZW8vbXBlZyIsICJtMTUiIH0sCisgICAgICAgIHsgInZpZGVv L21wZWciLCAibTFzIiB9LAorICAgICAgICB7ICJ2aWRlby9tcGVnIiwgIm0xdiIgfSwKKyAgICAg ICAgeyAidmlkZW8vbXBlZyIsICJtNzUiIH0sCisgICAgICAgIHsgInZpZGVvL21wZWciLCAibXBh IiB9LAorICAgICAgICB7ICJ2aWRlby9tcGVnIiwgIm1wZWciIH0sCisgICAgICAgIHsgInZpZGVv L21wZWciLCAibXBtIiB9LAorICAgICAgICB7ICJ2aWRlby9tcGVnIiwgIm1wdiIgfSwKKworICAg ICAgICAvLyBNUEVHIHBsYXlsaXN0CisgICAgICAgIHsgImF1ZGlvL3gtbXBlZ3VybCIsICJtM3Vy bCIgfSwKKyAgICAgICAgeyAiYXBwbGljYXRpb24veC1tcGVndXJsIiwgIm0zdTgiIH0sCisKKyAg ICAgICAgLy8gTVBFRy00CisgICAgICAgIHsgInZpZGVvL3gtbTR2IiwgIm00diIgfSwKKyAgICAg ICAgeyAiYXVkaW8veC1tNGEiLCAibTRhIiB9LAorICAgICAgICB7ICJhdWRpby94LW00YiIsICJt NGIiIH0sCisgICAgICAgIHsgImF1ZGlvL3gtbTRwIiwgIm00cCIgfSwKKyAKKyAgICAgICAgLy8g TVAzCisgICAgICAgIHsgImF1ZGlvL21wMyIsICJtcDMiIH0sCisKKyAgICAgICAgLy8gTVBFRy0y CisgICAgICAgIHsgInZpZGVvL3gtbXBlZzIiLCAibXAyIiB9LAorICAgICAgICB7ICJ2aWRlby9t cGVnMiIsICJ2b2IiIH0sCisgICAgICAgIHsgInZpZGVvL21wZWcyIiwgIm1vZCIgfSwKKyAgICAg ICAgeyAidmlkZW8vbTJ0cyIsICJtMnRzIiB9LAorICAgICAgICB7ICJ2aWRlby94LW0ydHMiLCAi bTJ0IiB9LAorICAgICAgICB7ICJ2aWRlby94LW0ydHMiLCAidHMiIH0sCisKKyAgICAgICAgLy8g M0dQLzNHUDIKKyAgICAgICAgeyAiYXVkaW8vM2dwcCIsICIzZ3BwIiB9LCAKKyAgICAgICAgeyAi YXVkaW8vM2dwcDIiLCAiM2cyIiB9LCAKKyAgICAgICAgeyAiYXBwbGljYXRpb24veC1tcGVnIiwg ImFtYyIgfSwKKworICAgICAgICAvLyBBQUMKKyAgICAgICAgeyAiYXVkaW8vYWFjIiwgImFhYyIg fSwKKyAgICAgICAgeyAiYXVkaW8vYWFjIiwgImFkdHMiIH0sCisgICAgICAgIHsgImF1ZGlvL3gt YWFjIiwgIm00ciIgfSwKKworICAgICAgICAvLyBDb3JlQXVkaW8gRmlsZQorICAgICAgICB7ICJh dWRpby94LWNhZiIsICJjYWYiIH0sCisgICAgICAgIHsgImF1ZGlvL3gtZ3NtIiwgImdzbSIgfQor ICAgIH07CisKKyAgICBtZWRpYU1JTUVUeXBlRm9yRXh0ZW5zaW9uTWFwID0gbmV3IEhhc2hNYXA8 U3RyaW5nLCBTdHJpbmcsIENhc2VGb2xkaW5nSGFzaD47CisgICAgY29uc3QgdW5zaWduZWQgbnVt UGFpcnMgPSBzaXplb2YocGFpcnMpIC8gc2l6ZW9mKHBhaXJzWzBdKTsKKyAgICBmb3IgKHVuc2ln bmVkIG5keCA9IDA7IG5keCA8IG51bVBhaXJzOyArK25keCkKKyAgICAgICAgbWVkaWFNSU1FVHlw ZUZvckV4dGVuc2lvbk1hcC0+c2V0KHBhaXJzW25keF0uZXh0ZW5zaW9uLCBwYWlyc1tuZHhdLnR5 cGUpOworfQorCitTdHJpbmcgTUlNRVR5cGVSZWdpc3RyeTo6Z2V0TWVkaWFNSU1FVHlwZUZvckV4 dGVuc2lvbihjb25zdCBTdHJpbmcmIGV4dCkKK3sKKyAgICAvLyBDaGVjayB3aXRoIHN5c3RlbSBz cGVjaWZpYyBpbXBsZW1lbnRhdGlvbiBmaXJzdC4KKyAgICBTdHJpbmcgbWltZVR5cGUgPSBnZXRN SU1FVHlwZUZvckV4dGVuc2lvbihleHQpOworICAgIGlmICghbWltZVR5cGUuaXNFbXB0eSgpKQor ICAgICAgICByZXR1cm4gbWltZVR5cGU7CisKKyAgICAvLyBObyBtYXRjaCwgbG9vayBpbiB0aGUg c3RhdGljIG1hcHBpbmcuCisgICAgaWYgKCFtZWRpYU1JTUVUeXBlRm9yRXh0ZW5zaW9uTWFwKQor ICAgICAgICBpbml0aWFsaXplTWVkaWFUeXBlTWFwcygpOworICAgIHJldHVybiBtZWRpYU1JTUVU eXBlRm9yRXh0ZW5zaW9uTWFwLT5nZXQoZXh0KTsKK30KKwogc3RhdGljIEhhc2hTZXQ8U3RyaW5n PiYgZHVtbXlIYXNoU2V0KCkKIHsKICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsK 30555 2009-05-21 14:06:43 -0700 2009-05-21 14:11:38 -0700 Proposed fix. bug25946.txt text/plain 1459 levin ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjNlZmIyNy4uNGQ4MTU0NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0wNS0yMSAgRGF2aWQgTGV2aW4g IDxsZXZpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQnVnIDI1OTQ2OiBDaHJvbWl1bSBuZWVkcyBNSU1FVHlwZVJlZ2lzdHJ5 OjpnZXRNZWRpYU1JTUVUeXBlRm9yRXh0ZW5zaW9uIGltcGxlbWVudGF0aW9uLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjU5NDYKKworICAgICAgICBB IHZlcnkgc2ltcGxlIGltcGxlbWVudGF0aW9uIHRvIGtlZXAgaXQgd29ya2luZy4gIEEgYnVnIGhh cyBiZWVuIGZpbGVkIGluIHRoZSBjaHJvbWl1bSBkYgorICAgICAgICAoaHR0cDovL2NvZGUuZ29v Z2xlLmNvbS9wL2Nocm9taXVtL2lzc3Vlcy9kZXRhaWw/aWQ9MTI0NDEpIHRvIGludmVzdGlnYXRl IGRvaW5nIHNvbWV0aGluZyBtb3JlCisgICAgICAgIGNvbXBsZXRlLgorCisgICAgICAgICogcGxh dGZvcm0vY2hyb21pdW0vTWltZVR5cGVSZWdpc3RyeUNocm9taXVtLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6Ok1JTUVUeXBlUmVnaXN0cnk6OmdldE1lZGlhTUlNRVR5cGVGb3JFeHRlbnNpb24pOgor CiAyMDA5LTA1LTIxICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAd2Via2l0Lm9yZz4KIAogICAg ICAgICBSZXZpZXdlZCBieSBEYXZpZCBLaWx6ZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRm b3JtL2Nocm9taXVtL01pbWVUeXBlUmVnaXN0cnlDaHJvbWl1bS5jcHAgYi9XZWJDb3JlL3BsYXRm b3JtL2Nocm9taXVtL01pbWVUeXBlUmVnaXN0cnlDaHJvbWl1bS5jcHAKaW5kZXggMWFhYzVlYy4u MTk4MWVkNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9NaW1lVHlwZVJl Z2lzdHJ5Q2hyb21pdW0uY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vTWltZVR5 cGVSZWdpc3RyeUNocm9taXVtLmNwcApAQCAtMTI3LDYgKzEyNywxMSBAQCBib29sIE1JTUVUeXBl UmVnaXN0cnk6OmlzSmF2YUFwcGxldE1JTUVUeXBlKGNvbnN0IFN0cmluZyYgbWltZVR5cGUpCiAg ICAgICAgIHx8IG1pbWVUeXBlLnN0YXJ0c1dpdGgoImFwcGxpY2F0aW9uL3gtamF2YS12bSIsIGZh bHNlKTsKIH0KIAorU3RyaW5nIE1JTUVUeXBlUmVnaXN0cnk6OmdldE1lZGlhTUlNRVR5cGVGb3JF eHRlbnNpb24oY29uc3QgU3RyaW5nJiBleHQpCit7CisgICAgcmV0dXJuIGdldE1JTUVUeXBlRm9y RXh0ZW5zaW9uKGV4dCk7Cit9CisKIHN0YXRpYyBIYXNoU2V0PFN0cmluZz4mIGR1bW15SGFzaFNl dCgpCiB7CiAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Cg==