25945 2009-05-21 13:24:24 -0700 Add support for MADV_FREE to TCMalloc 2009-05-21 15:13:25 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 zwarich zwarich oldest_to_newest 122402 0 zwarich 2009-05-21 13:24:24 -0700 We should do this. 122403 1 zwarich 2009-05-21 13:25:24 -0700 <rdar://problem/6910754> 122407 2 30552 zwarich 2009-05-21 13:36:40 -0700 Created attachment 30552 Proposed patch 122408 3 30552 mrowe 2009-05-21 13:39:52 -0700 Comment on attachment 30552 Proposed patch r=me. A comment on why we prefer MADV_FREE over MADV_DONTNEED could be make the subtleties in this code a little less confusing. 122436 4 zwarich 2009-05-21 15:13:25 -0700 Landed in r43988 with a comment explaining the change as per your suggestion. 30552 2009-05-21 13:36:40 -0700 2009-05-21 13:39:52 -0700 Proposed patch madv_free.diff text/plain 2525 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQzOTc2 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjMgQEAKKzIwMDktMDUt MjEgIENhbWVyb24gWndhcmljaCAgPHp3YXJpY2hAYXBwbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAyNTk0NTogQWRkIHN1cHBvcnQg Zm9yIE1BRFZfRlJFRSB0byBUQ01hbGxvYworICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTI1OTQ1PgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjkxMDc1 ND4KKworICAgICAgICBBZGQgc3VwcG9ydCBmb3IgTUFEVl9GUkVFIHRvIFRDTWFsbG9jX1N5c3Rl bVJlbGVhc2UgZm9yIHBsYXRmb3JtcyB0aGF0CisgICAgICAgIGRvbid0IGFsc28gc3VwcG9ydCBN QURWX0ZSRUVfUkVVU0UuIFRoZSBjb2RlIGlzIGlkZW50aWNhbCB0byB0aGUgTUFEVl9ET05UTkVF RAorICAgICAgICBjYXNlIGV4Y2VwdCBmb3IgdGhlIGFkdmljZSBwYXNzZWQgdG8gbWFkdmlzZSgp LCBzbyBjb21iaW5pbmcgdGhlIHR3byBjYXNlcworICAgICAgICBtYWtlcyB0aGUgbW9zdCBzZW5z ZS4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOiBPbmx5IGRlZmluZSBIQVZFX01BRFZfRlJF RSB3aGVuIG5vdCBidWlsZGluZyBvbiBUaWdlciBvcgorICAgICAgICBMZW9wYXJkLCBiZWNhdXNl IHdoaWxlIGl0IGlzIGRlZmluZWQgb24gdGhlc2UgcGxhdGZvcm1zIGl0IGFjdHVhbGx5IGRvZXMK KyAgICAgICAgbm90aGluZy4KKyAgICAgICAgKiB3dGYvVENTeXN0ZW1BbGxvYy5jcHA6CisgICAg ICAgIChUQ01hbGxvY19TeXN0ZW1SZWxlYXNlKTogdXNlIE1BRFZfRlJFRSBpZiBpdCBpcyBhdmFp bGFibGU7IG90aGVyd2lzZSB1c2UKKyAgICAgICAgTUFEVl9ET05UTkVFRC4KKwogMjAwOS0wNS0y MSAgTWFyayBSb3dlICA8bXJvd2VAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9s aXZlciBIdW50LgpJbmRleDogd3RmL1BsYXRmb3JtLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gd3RmL1BsYXRm b3JtLmgJKHJldmlzaW9uIDQzOTY0KQorKysgd3RmL1BsYXRmb3JtLmgJKHdvcmtpbmcgY29weSkK QEAgLTM2NSw5ICszNjUsOCBAQAogCiAjaWYgIWRlZmluZWQoQlVJTERJTkdfT05fVElHRVIpICYm ICFkZWZpbmVkKEJVSUxESU5HX09OX0xFT1BBUkQpCiAjZGVmaW5lIEhBVkVfTUFEVl9GUkVFX1JF VVNFIDEKLSNlbmRpZgotCiAjZGVmaW5lIEhBVkVfTUFEVl9GUkVFIDEKKyNlbmRpZgogCiAjZWxp ZiBQTEFURk9STShXSU5fT1MpCiAKSW5kZXg6IHd0Zi9UQ1N5c3RlbUFsbG9jLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSB3dGYvVENTeXN0ZW1BbGxvYy5jcHAJKHJldmlzaW9uIDQzOTY0KQorKysgd3RmL1RD U3lzdGVtQWxsb2MuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zODgsMTAgKzM4OCwxNSBAQCB2b2lk IFRDTWFsbG9jX1N5c3RlbVJlbGVhc2Uodm9pZCogc3RhcnQsCiAgICAgd2hpbGUgKG1hZHZpc2Uo c3RhcnQsIGxlbmd0aCwgTUFEVl9GUkVFX1JFVVNBQkxFKSA9PSAtMSAmJiBlcnJubyA9PSBFQUdB SU4pIHsgfQogfQogCi0jZWxpZiBIQVZFKE1BRFZfRE9OVE5FRUQpCisjZWxpZiBIQVZFKE1BRFZf RlJFRSkgfHwgSEFWRShNQURWX0RPTlRORUVEKQogCiB2b2lkIFRDTWFsbG9jX1N5c3RlbVJlbGVh c2Uodm9pZCogc3RhcnQsIHNpemVfdCBsZW5ndGgpCiB7CisjaWYgSEFWRShNQURWX0ZSRUUpCisg ICAgY29uc3QgaW50IGFkdmljZSA9IE1BRFZfRlJFRTsKKyNlbHNlCisgICAgY29uc3QgaW50IGFk dmljZSA9IE1BRFZfRE9OVE5FRUQ7CisjZW5kaWYKICAgaWYgKEZMQUdTX21hbGxvY19kZXZtZW1f c3RhcnQpIHsKICAgICAvLyBJdCdzIG5vdCBzYWZlIHRvIHVzZSBNQURWX0RPTlRORUVEIGlmIHdl J3ZlIGJlZW4gbWFwcGluZwogICAgIC8vIC9kZXYvbWVtIGZvciBoZWFwIG1lbW9yeQpAQCAtNDE4 LDcgKzQyMyw3IEBAIHZvaWQgVENNYWxsb2NfU3lzdGVtUmVsZWFzZSh2b2lkKiBzdGFydCwKICAg ICAvLyBOb3RlIC0tIGlnbm9yaW5nIG1vc3QgcmV0dXJuIGNvZGVzLCBiZWNhdXNlIGlmIHRoaXMg ZmFpbHMgaXQKICAgICAvLyBkb2Vzbid0IG1hdHRlci4uLgogICAgIHdoaWxlIChtYWR2aXNlKHJl aW50ZXJwcmV0X2Nhc3Q8Y2hhcio+KG5ld19zdGFydCksIG5ld19lbmQgLSBuZXdfc3RhcnQsCi0g ICAgICAgICAgICAgICAgICAgTUFEVl9ET05UTkVFRCkgPT0gLTEgJiYKKyAgICAgICAgICAgICAg ICAgICBhZHZpY2UpID09IC0xICYmCiAgICAgICAgICAgIGVycm5vID09IEVBR0FJTikgewogICAg ICAgLy8gTk9QCiAgICAgfQo=