25936 2009-05-21 09:46:34 -0700 wxWebKit lacks a way to control logging 2009-05-21 17:26:54 -0700 1 1 1 Unclassified WebKit WebKit wx 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 kevinwatters webkit-unassigned oldest_to_newest 122367 0 kevinwatters 2009-05-21 09:46:34 -0700 Controlling logging via an environment variable would be useful. 122371 1 30546 kevinwatters 2009-05-21 09:48:01 -0700 Created attachment 30546 implement InitializeLoggingChannelsIfNecessary Parses environment variable WX_WEBKIT_LOG to determine which logs are enabled. 122477 2 kevino 2009-05-21 17:26:54 -0700 Landed in r43990, thanks! 30546 2009-05-21 09:48:01 -0700 2009-05-21 10:28:23 -0700 implement InitializeLoggingChannelsIfNecessary logging.patch text/plain 4473 kevinwatters ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTk0ZDBjYy4uY2Q1NDNlMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wNS0yMSAgS2V2aW4gV2F0dGVy cyAgPGtldmlud2F0dGVyc0BnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVXNlIGFuIGVudmlyb25tZW50IHZhcmlhYmxlIHRvIGNvbnRy b2wgd2hpY2ggbG9ncyBhcmUgb24gYW5kIG9mZi4KKyAgICAgICAgQWxzbywgbWFrZSBhIGdlbmVy aWMgZnVuY3Rpb24gZm9yIHRyYW5zbGF0aW5nIGNoYW5uZWwgbmFtZSB0byBpdHMgbG9nLgorCisg ICAgICAgICogcGxhdGZvcm0vTG9nZ2luZy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpnZXRDaGFu bmVsRnJvbU5hbWUpOgorICAgICAgICAqIHBsYXRmb3JtL0xvZ2dpbmcuaDoKKyAgICAgICAgKiBw bGF0Zm9ybS93eC9Mb2dnaW5nV3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5pdGlhbGl6ZUxv Z2dpbmdDaGFubmVsc0lmTmVjZXNzYXJ5KToKKwogMjAwOS0wNS0yMCAgSG9sZ2VyIEhhbnMgUGV0 ZXIgRnJleXRoZXIgIDx6ZWNrZUBzZWxmaXNoLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBE YXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vTG9nZ2luZy5jcHAgYi9X ZWJDb3JlL3BsYXRmb3JtL0xvZ2dpbmcuY3BwCmluZGV4IGExYWEzZDYuLjJkMThmMTQgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vTG9nZ2luZy5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9y bS9Mb2dnaW5nLmNwcApAQCAtMjUsNiArMjUsNyBAQAogCiAjaW5jbHVkZSAiY29uZmlnLmgiCiAj aW5jbHVkZSAiTG9nZ2luZy5oIgorI2luY2x1ZGUgIlBsYXRmb3JtU3RyaW5nLmgiCiAKIG5hbWVz cGFjZSBXZWJDb3JlIHsKIApAQCAtNTksNCArNjAsMzMgQEAgV1RGTG9nQ2hhbm5lbCBMb2dNZWRp YSA9ICAgICAgICAgICAgIHsgMHgwMTAwMDAwMCwgIldlYkNvcmVMb2dMZXZlbCIsIFdURkxvZ0No YW4KIFdURkxvZ0NoYW5uZWwgTG9nUGx1Z2luID0gICAgICAgICAgICB7IDB4MDIwMDAwMDAsICJX ZWJDb3JlTG9nTGV2ZWwiLCBXVEZMb2dDaGFubmVsT2ZmIH07CiBXVEZMb2dDaGFubmVsIExvZ0Fy Y2hpdmVzID0gICAgICAgICAgeyAweDA0MDAwMDAwLCAiV2ViQ29yZUxvZ0xldmVsIiwgV1RGTG9n Q2hhbm5lbE9mZiB9OwogCitXVEZMb2dDaGFubmVsKiBnZXRDaGFubmVsRnJvbU5hbWUoY29uc3Qg U3RyaW5nJiBjaGFubmVsTmFtZSkKK3sKKyAgICBpZiAoIWNoYW5uZWxOYW1lLmxlbmd0aCgpID49 IDIpCisgICAgICAgIHJldHVybiAwOworCisgICAgaWYgKGNoYW5uZWxOYW1lID09IFN0cmluZygi QmFja0ZvcndhcmQiKSkgcmV0dXJuICZMb2dCYWNrRm9yd2FyZDsKKyAgICBpZiAoY2hhbm5lbE5h bWUgPT0gU3RyaW5nKCJFZGl0aW5nIikpIHJldHVybiAmTG9nRWRpdGluZzsKKyAgICBpZiAoY2hh bm5lbE5hbWUgPT0gU3RyaW5nKCJFdmVudHMiKSkgcmV0dXJuICZMb2dFdmVudHM7CisgICAgaWYg KGNoYW5uZWxOYW1lID09IFN0cmluZygiRnJhbWVzIikpIHJldHVybiAmTG9nRnJhbWVzOworICAg IGlmIChjaGFubmVsTmFtZSA9PSBTdHJpbmcoIkZUUCIpKSByZXR1cm4gJkxvZ0ZUUDsKKyAgICBp ZiAoY2hhbm5lbE5hbWUgPT0gU3RyaW5nKCJIaXN0b3J5IikpIHJldHVybiAmTG9nSGlzdG9yeTsK KyAgICBpZiAoY2hhbm5lbE5hbWUgPT0gU3RyaW5nKCJJY29uRGF0YWJhc2UiKSkgcmV0dXJuICZM b2dJY29uRGF0YWJhc2U7CisgICAgaWYgKGNoYW5uZWxOYW1lID09IFN0cmluZygiTG9hZGluZyIp KSByZXR1cm4gJkxvZ0xvYWRpbmc7CisgICAgaWYgKGNoYW5uZWxOYW1lID09IFN0cmluZygiTWVk aWEiKSkgcmV0dXJuICZMb2dNZWRpYTsKKyAgICBpZiAoY2hhbm5lbE5hbWUgPT0gU3RyaW5nKCJO ZXR3b3JrIikpIHJldHVybiAmTG9nTmV0d29yazsKKyAgICBpZiAoY2hhbm5lbE5hbWUgPT0gU3Ry aW5nKCJOb3RZZXRJbXBsZW1lbnRlZCIpKSByZXR1cm4gJkxvZ05vdFlldEltcGxlbWVudGVkOwor ICAgIGlmIChjaGFubmVsTmFtZSA9PSBTdHJpbmcoIlBhZ2VDYWNoZSIpKSByZXR1cm4gJkxvZ1Bh Z2VDYWNoZTsKKyAgICBpZiAoY2hhbm5lbE5hbWUgPT0gU3RyaW5nKCJQbGF0Zm9ybUxlYWtzIikp IHJldHVybiAmTG9nUGxhdGZvcm1MZWFrczsKKyAgICBpZiAoY2hhbm5lbE5hbWUgPT0gU3RyaW5n KCJQbHVnaW4iKSkgcmV0dXJuICZMb2dQbHVnaW47CisgICAgaWYgKGNoYW5uZWxOYW1lID09IFN0 cmluZygiUG9wdXBCbG9ja2luZyIpKSByZXR1cm4gJkxvZ1BvcHVwQmxvY2tpbmc7CisgICAgaWYg KGNoYW5uZWxOYW1lID09IFN0cmluZygiU3BlbGxpbmdBbmRHcmFtbWFyIikpIHJldHVybiAmTG9n U3BlbGxpbmdBbmRHcmFtbWFyOworICAgIGlmIChjaGFubmVsTmFtZSA9PSBTdHJpbmcoIlNRTERh dGFiYXNlIikpIHJldHVybiAmTG9nU1FMRGF0YWJhc2U7CisgICAgaWYgKGNoYW5uZWxOYW1lID09 IFN0cmluZygiU3RvcmFnZUFQSSIpKSByZXR1cm4gJkxvZ1N0b3JhZ2VBUEk7CisgICAgaWYgKGNo YW5uZWxOYW1lID09IFN0cmluZygiVGV4dENvbnZlcnNpb24iKSkgcmV0dXJuICZMb2dUZXh0Q29u dmVyc2lvbjsKKyAgICBpZiAoY2hhbm5lbE5hbWUgPT0gU3RyaW5nKCJUaHJlYWRpbmciKSkgcmV0 dXJuICZMb2dUaHJlYWRpbmc7CisKKyAgICByZXR1cm4gMDsKK30KKwogfQpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9wbGF0Zm9ybS9Mb2dnaW5nLmggYi9XZWJDb3JlL3BsYXRmb3JtL0xvZ2dpbmcuaApp bmRleCA4NDRhYzNhLi5jMTQ2MWU3IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL0xvZ2dp bmcuaAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL0xvZ2dpbmcuaApAQCAtMzQsNiArMzQsOCBAQAog CiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKKyAgICBjbGFzcyBTdHJpbmc7CisKICAgICBleHRlcm4g V1RGTG9nQ2hhbm5lbCBMb2dOb3RZZXRJbXBsZW1lbnRlZDsKICAgICBleHRlcm4gV1RGTG9nQ2hh bm5lbCBMb2dGcmFtZXM7CiAgICAgZXh0ZXJuIFdURkxvZ0NoYW5uZWwgTG9nTG9hZGluZzsKQEAg LTU3LDYgKzU5LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgIGV4dGVybiBXVEZMb2dDaGFu bmVsIExvZ0FyY2hpdmVzOwogCiAgICAgdm9pZCBJbml0aWFsaXplTG9nZ2luZ0NoYW5uZWxzSWZO ZWNlc3NhcnkoKTsKKyAgICBXVEZMb2dDaGFubmVsKiBnZXRDaGFubmVsRnJvbU5hbWUoY29uc3Qg U3RyaW5nJiBjaGFubmVsTmFtZSk7CiB9CiAKICNlbmRpZiAvLyBMb2dnaW5nX2gKZGlmZiAtLWdp dCBhL1dlYkNvcmUvcGxhdGZvcm0vd3gvTG9nZ2luZ1d4LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0v d3gvTG9nZ2luZ1d4LmNwcAppbmRleCAwMDY3MTJjLi40ZDhhNDM3IDEwMDY0NAotLS0gYS9XZWJD b3JlL3BsYXRmb3JtL3d4L0xvZ2dpbmdXeC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS93eC9M b2dnaW5nV3guY3BwCkBAIC0yNiwxMSArMjYsMzkgQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNp bmNsdWRlICJMb2dnaW5nLmgiCiAKKyNpbmNsdWRlICJDU3RyaW5nLmgiCisjaW5jbHVkZSAiUGxh dGZvcm1TdHJpbmcuaCIKKyNpbmNsdWRlIDx3dGYvVmVjdG9yLmg+CisKKyNpbmNsdWRlIDx3eC9k ZWZzLmg+CisjaW5jbHVkZSA8d3gvdXRpbHMuaD4KKwogbmFtZXNwYWNlIFdlYkNvcmUgewogCiB2 b2lkIEluaXRpYWxpemVMb2dnaW5nQ2hhbm5lbHNJZk5lY2Vzc2FyeSgpCiB7Ci0gICAgTG9nTm90 WWV0SW1wbGVtZW50ZWQuc3RhdGUgPSBXVEZMb2dDaGFubmVsT247CisgICAgc3RhdGljIGJvb2wg aGF2ZUluaXRpYWxpemVkTG9nZ2luZ0NoYW5uZWxzID0gZmFsc2U7CisgICAgaWYgKGhhdmVJbml0 aWFsaXplZExvZ2dpbmdDaGFubmVscykKKyAgICAgICAgcmV0dXJuOworCisgICAgaGF2ZUluaXRp YWxpemVkTG9nZ2luZ0NoYW5uZWxzID0gdHJ1ZTsKKworICAgIHd4U3RyaW5nIGxvZ2dpbmdFbnY7 CisgICAgd3hHZXRFbnYod3hUKCJXWF9XRUJLSVRfTE9HIiksICZsb2dnaW5nRW52KTsKKyAgICBp ZiAobG9nZ2luZ0VudiA9PSB3eEVtcHR5U3RyaW5nKQorICAgICAgICByZXR1cm47CisKKyAgICBT dHJpbmcgd2tMb2dnaW5nRW52ID0gbG9nZ2luZ0VudjsKKyAgICBWZWN0b3I8U3RyaW5nPiBsb2dz OworICAgIAorICAgIHdrTG9nZ2luZ0Vudi5zcGxpdCgiLCIsIGxvZ3MpOworICAgIAorICAgIGZv ciAoc2l6ZV90IGkgPSAwOyBpIDwgbG9ncy5zaXplKCk7ICsraSkgeworICAgICAgICBXVEZMb2dD aGFubmVsKiBjaGFubmVsID0gZ2V0Q2hhbm5lbEZyb21OYW1lKGxvZ3NbaV0pOworICAgICAgICAK KyAgICAgICAgaWYgKGNoYW5uZWwpCisgICAgICAgICAgICBjaGFubmVsLT5zdGF0ZSA9IFdURkxv Z0NoYW5uZWxPbjsKKyAgICB9CiB9CiAKIH0K