259286 2023-07-17 12:11:00 -0700 REGRESSION(265525@main): wpt /svg/text/scripted/getstartpositionofchar-dominant-baseline.html 2023-07-19 07:07:16 -0700 1 1 1 Unclassified WebKit SVG WebKit Nightly Build Unspecified Unspecified RESOLVED CONFIGURATION CHANGED https://bugs.webkit.org/show_bug.cgi?id=139258 InRadar P2 Normal --- 1 gsnedders webkit-unassigned ahmad.saleem792 heycam ntim sabouhallawa webkit-bug-importer zimmermann oldest_to_newest 1967085 0 gsnedders 2023-07-17 12:11:00 -0700 c.f. https://wpt.fyi/results/svg/text/scripted/getstartpositionofchar-dominant-baseline.html?run_id=5186421294366720&run_id=5159272738979840&run_id=5100859438923776&run_id=5131751863615488&run_id=5163365977030656 which regressed in STP 174 bisecting this points at 265525@main, from bug 139258 The test seems to be specifically testing that certain things don't depend on dominant-baseline; it may just be that this a bad test (previously bogusly passing because it relied on dominant-baseline being inherited), but it is nevertheless a test regression. 1967086 1 webkit-bug-importer 2023-07-17 12:11:11 -0700 <rdar://problem/112420119> 1967116 2 ahmad.saleem792 2023-07-17 14:32:47 -0700 Thanks @Sam, let me explore what is causing this failure, might not be immediate solution from my side but still will look into it. 1967309 3 heycam 2023-07-18 21:28:15 -0700 So while this is indeed a test new failure due to making dominant-baseline inherited, it doesn’t reveal a new bug in our SVG text layout code. Manually inheriting the property shows the same issue. 1967310 4 467071 heycam 2023-07-18 21:28:28 -0700 Created attachment 467071 test 1967311 5 heycam 2023-07-18 21:31:00 -0700 Using these baseline properties with SVG text isn't super common, but I have seen people use it. There is a small risk of breaking content, without fixing the underlying SVG text layout problem. I think we should revert bug 139258 until we can fix the SVG text issue. 1967335 6 ahmad.saleem792 2023-07-19 03:31:47 -0700 I am OK to revert this but at the same time, this change progressed two WPT tests (if I am not wrong) and helped us close three ancient bugs, we had. 1967350 7 ntim 2023-07-19 07:07:16 -0700 Fixed by revert: https://webkit.org/b/259335 > I am OK to revert this but at the same time, this change progressed two WPT tests (if I am not wrong) and helped us close three ancient bugs, we had. I think we do want to try to fix this test if we were to reland this. 467071 2023-07-18 21:28:28 -0700 2023-07-18 21:28:28 -0700 test dominant-baseline.svg image/svg+xml 399 heycam PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHN0eWxlPSJmb250OiA2MHB4 IEFyaWFsOyI+CiAgPHBhdGggaWQ9InBhdGgiIHN0cm9rZT0icmVkIiBzdHJva2Utd2lkdGg9IjEi IGQ9Ik0wIDEwMGg1MDAiLz4KICA8dGV4dCB4PSIwIiB5PSIxMDAiIGRvbWluYW50LWJhc2VsaW5l PSJtaWRkbGUiPlRlc3Q8L3RleHQ+CiAgPHRleHQgZG9taW5hbnQtYmFzZWxpbmU9Im1pZGRsZSI+ CiAgICA8dHNwYW4geD0iMTUwIiB5PSIxMDAiPlRlc3Q8L3RzcGFuPgogIDwvdGV4dD4KICA8dGV4 dCB4PSIzMDAiIHk9IjEwMCIgZG9taW5hbnQtYmFzZWxpbmU9Im1pZGRsZSI+CiAgICA8dHNwYW4g ZG9taW5hbnQtYmFzZWxpbmU9Im1pZGRsZSI+VGVzdDwvdHNwYW4+CiAgPC90ZXh0Pgo8L3N2Zz4K