<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>259284</bug_id>
          
          <creation_ts>2023-07-17 11:37:12 -0700</creation_ts>
          <short_desc>SQLiteDatabase::turnOnIncrementalAutoVacuum() is broken</short_desc>
          <delta_ts>2023-07-18 14:28:18 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=229886</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=249598</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Adrien Destugues">pulkomandy</reporter>
          <assigned_to name="Ben Nham">nham</assigned_to>
          <cc>beidson</cc>
    
    <cc>nham</cc>
    
    <cc>sihui_liu</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1967076</commentid>
    <comment_count>0</comment_count>
    <who name="Adrien Destugues">pulkomandy</who>
    <bug_when>2023-07-17 11:37:12 -0700</bug_when>
    <thetext>See the patch here: https://github.com/haiku/haikuwebkit/commit/c8f63951a5f3d5acfd7c40d1606f830272ad791b

This problem already existed a long time ago and was fixed in https://bugs.webkit.org/show_bug.cgi?id=229886

But then it was broken again in https://bugs.webkit.org/show_bug.cgi?id=249598 which results in accessing lastError after the statement is destroyed, instead of before.

As a sidenote I think https://bugs.webkit.org/show_bug.cgi?id=68465 was also fixed by the second of these changes, and can be closed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1967199</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2023-07-18 09:41:07 -0700</bug_when>
    <thetext>&lt;rdar://problem/112475480&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1967215</commentid>
    <comment_count>2</comment_count>
    <who name="Ben Nham">nham</who>
    <bug_when>2023-07-18 11:15:31 -0700</bug_when>
    <thetext>*** Bug 259312 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1967216</commentid>
    <comment_count>3</comment_count>
    <who name="Ben Nham">nham</who>
    <bug_when>2023-07-18 11:18:22 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/15908</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1967217</commentid>
    <comment_count>4</comment_count>
    <who name="Ben Nham">nham</who>
    <bug_when>2023-07-18 11:21:16 -0700</bug_when>
    <thetext>Thanks for spotting this regression, we will try to apply the fix.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1967242</commentid>
    <comment_count>5</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-07-18 14:28:15 -0700</bug_when>
    <thetext>Committed 266139@main (a4485084ec04): &lt;https://commits.webkit.org/266139@main&gt;

Reviewed commits have been landed. Closing PR #15908 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>