25928 2009-05-21 06:47:31 -0700 [Gtk] Several errors detected by cppcheck 2010-03-17 07:08:04 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 webkit webkit-unassigned gustavo jesus kling tonikitoo oldest_to_newest 122343 0 webkit 2009-05-21 06:47:31 -0700 cppcheck (http://cppcheck.wiki.sourceforge.net/) is greater for checking c++ code! [./accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:63]: (all) Memory leak: fallbackCache [./css/CSSParser.cpp:370]: (all) Memory leak: prop [./css/CSSPrimitiveValue.cpp:79]: (all) Memory leak: colorValueCache [./page/DOMWindow.cpp:610]: (all) Memory leak: timer [./platform/graphics/chromium/FontCacheChromiumWin.cpp:231]: (all) Memory leak: fontNameMap [./platform/graphics/chromium/FontCacheChromiumWin.cpp:294]: (all) Memory leak: fontCmapCache [./platform/graphics/opentype/OpenTypeUtilities.cpp:375]: (all) Buffer overrun [./platform/graphics/opentype/OpenTypeUtilities.cpp:384]: (all) Array index out of bounds [./platform/graphics/opentype/OpenTypeUtilities.cpp:385]: (all) Array index out of bounds [./platform/graphics/opentype/OpenTypeUtilities.cpp:386]: (all) Array index out of bounds [./platform/graphics/opentype/OpenTypeUtilities.cpp:387]: (all) Array index out of bounds [./platform/qt/FileSystemQt.cpp:126]: (all) Memory leak: temp [./platform/qt/PasteboardQt.cpp:77]: (all) Memory leak: md [./rendering/style/SVGRenderStyle.cpp:55]: (all) Memory leak: defaultStyle 122659 1 ap 2009-05-22 07:31:58 -0700 Some of these warnings are false alarms, but some are real. 122664 2 30581 ap 2009-05-22 07:47:07 -0700 Created attachment 30581 Fix for cross-platform This patch fixes all issues affecting cross-platform code (there was only one). Some platform issues look real, too, but I didn't feel qualified to fix them. > [./css/CSSParser.cpp:370]: (all) Memory leak: prop Fixed. > [./css/CSSPrimitiveValue.cpp:79]: (all) Memory leak: colorValueCache > [./page/DOMWindow.cpp:610]: (all) Memory leak: timer > [./rendering/style/SVGRenderStyle.cpp:55]: (all) Memory leak: defaultStyle These are false alarms. 122665 3 30581 eric 2009-05-22 07:57:27 -0700 Comment on attachment 30581 Fix for cross-platform I think the ChangeLog could be slightly clearer. To state that specifically we would leak if we ever parsed UINT_MAX / sizeof(CSSProperty*) properties (aka ~ 1billion). Looks great though. 122667 4 30581 ap 2009-05-22 08:06:23 -0700 Comment on attachment 30581 Fix for cross-platform Committed r44044, clearing review flag. 122668 5 ap 2009-05-22 08:08:03 -0700 FontCacheChromiumWin.cpp ones are also false alarms, so these are ones to be investigated by port maintainers: [./accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:63]: (all) Memory leak: fallbackCache [./platform/graphics/opentype/OpenTypeUtilities.cpp:375]: (all) Buffer overrun [./platform/graphics/opentype/OpenTypeUtilities.cpp:384]: (all) Array index out of bounds [./platform/graphics/opentype/OpenTypeUtilities.cpp:385]: (all) Array index out of bounds [./platform/graphics/opentype/OpenTypeUtilities.cpp:386]: (all) Array index out of bounds [./platform/graphics/opentype/OpenTypeUtilities.cpp:387]: (all) Array index out of bounds [./platform/qt/FileSystemQt.cpp:126]: (all) Memory leak: temp [./platform/qt/PasteboardQt.cpp:77]: (all) Memory leak: md 126322 6 gustavo 2009-06-16 15:21:48 -0700 (In reply to comment #0) > [./accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:63]: (all) Memory leak: > fallbackCache My reading of the code indicates this is a false-positive. fallbackCache is meant to be alive from the first call onwards (it's static). 200143 7 kling 2010-03-16 05:18:58 -0700 (In reply to comment #5) > [./platform/qt/PasteboardQt.cpp:77]: (all) Memory leak: md False positive - ownership is transferred in QClipboard::setMimeData() 200661 8 kling 2010-03-17 04:03:11 -0700 Actually, this is also a false positive: [./platform/qt/FileSystemQt.cpp:126]: (all) Memory leak: temp Removing Qt keyword. 200748 9 gustavo 2010-03-17 07:08:04 -0700 I think we can close this bug, then, since the only GTK+ one was also a false-positive. Thanks! 30581 2009-05-22 07:47:07 -0700 2009-05-22 08:06:23 -0700 Fix for cross-platform UnlikelyLeak.txt text/plain 1926 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NDA0MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDUtMjIgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTkyOAorICAgICAgICBT ZXZlcmFsIGVycm9ycyBkZXRlY3RlZCBieSBjcHBjaGVjaworCisgICAgICAgIEZpeCBhbGwgKHRo ZSBvbmx5IG9uZSkgcHJvYmxlbSBpbiBjcm9zcy1wbGF0Zm9ybSBjb2RlIGZvdW5kIGJ5IHRoZSB0 b29sLiBQb3J0IG1haW50YWluZXJzCisgICAgICAgIHNob3VsZCB0YWtlIGEgbG9vayBhdCBvdGhl ciByZXBvcnRzLgorCisgICAgICAgICogY3NzL0NTU1BhcnNlci5jcHA6IChXZWJDb3JlOjpDU1NQ YXJzZXI6OmFkZFByb3BlcnR5KTogRG9udCBsZWFrIHRoZSBwcm9wZXJ0eSBldmVuIGlmIHRoZXJl CisgICAgICAgIGFyZSBiaWxsaW9ucyBvZiB0aG9zZS4KKwogMjAwOS0wNS0yMiAgU2hpbmljaGly byBIYW1hamkgIDxoYW1hamlAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBPbGl2 ZXIgSHVudC4KSW5kZXg6IFdlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAkocmV2aXNpb24gNDM5NzMpCisrKyBXZWJDb3JlL2Nz cy9DU1NQYXJzZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNjMsNyArMzYzLDcgQEAgYm9vbCBD U1NQYXJzZXI6OnBhcnNlTWVkaWFRdWVyeShNZWRpYUxpcwogCiB2b2lkIENTU1BhcnNlcjo6YWRk UHJvcGVydHkoaW50IHByb3BJZCwgUGFzc1JlZlB0cjxDU1NWYWx1ZT4gdmFsdWUsIGJvb2wgaW1w b3J0YW50KQogewotICAgIENTU1Byb3BlcnR5KiBwcm9wID0gbmV3IENTU1Byb3BlcnR5KHByb3BJ ZCwgdmFsdWUsIGltcG9ydGFudCwgbV9jdXJyZW50U2hvcnRoYW5kLCBtX2ltcGxpY2l0U2hvcnRo YW5kKTsKKyAgICBhdXRvX3B0cjxDU1NQcm9wZXJ0eT4gcHJvcChuZXcgQ1NTUHJvcGVydHkocHJv cElkLCB2YWx1ZSwgaW1wb3J0YW50LCBtX2N1cnJlbnRTaG9ydGhhbmQsIG1faW1wbGljaXRTaG9y dGhhbmQpKTsKICAgICBpZiAobV9udW1QYXJzZWRQcm9wZXJ0aWVzID49IG1fbWF4UGFyc2VkUHJv cGVydGllcykgewogICAgICAgICBtX21heFBhcnNlZFByb3BlcnRpZXMgKz0gMzI7CiAgICAgICAg IGlmIChtX21heFBhcnNlZFByb3BlcnRpZXMgPiBVSU5UX01BWCAvIHNpemVvZihDU1NQcm9wZXJ0 eSopKQpAQCAtMzcxLDcgKzM3MSw3IEBAIHZvaWQgQ1NTUGFyc2VyOjphZGRQcm9wZXJ0eShpbnQg cHJvcElkLCAKICAgICAgICAgbV9wYXJzZWRQcm9wZXJ0aWVzID0gc3RhdGljX2Nhc3Q8Q1NTUHJv cGVydHkqKj4oZmFzdFJlYWxsb2MobV9wYXJzZWRQcm9wZXJ0aWVzLAogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1fbWF4UGFyc2VkUHJvcGVy dGllcyAqIHNpemVvZihDU1NQcm9wZXJ0eSopKSk7CiAgICAgfQotICAgIG1fcGFyc2VkUHJvcGVy dGllc1ttX251bVBhcnNlZFByb3BlcnRpZXMrK10gPSBwcm9wOworICAgIG1fcGFyc2VkUHJvcGVy dGllc1ttX251bVBhcnNlZFByb3BlcnRpZXMrK10gPSBwcm9wLnJlbGVhc2UoKTsKIH0KIAogdm9p ZCBDU1NQYXJzZXI6OnJvbGxiYWNrTGFzdFByb3BlcnRpZXMoaW50IG51bSkK