259260 2023-07-16 03:45:08 -0700 Remove 'didChangeScrollOffset' from RenderLayerScrollableArea::scrollTo() 2023-07-20 15:23:13 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID https://bugs.webkit.org/show_bug.cgi?id=110673 P2 Normal --- 1 ahmad.saleem792 webkit-unassigned bfulgham simon.fraser zalan oldest_to_newest 1966964 0 ahmad.saleem792 2023-07-16 03:45:08 -0700 Hi Team, While going through Blink's commit, I came across one revert change of bug 110673. ^ @Simon's reviewed patch landed in above as following: http://trac.webkit.org/changeset/146260 Blink Commit: https://src.chromium.org/viewvc/blink?view=revision&revision=148242 WebKit's Source https://github.com/WebKit/WebKit/blob/638ac8184b3860aafc3d68fec13300730af06a6d/Source/WebCore/rendering/RenderLayerScrollableArea.cpp#L424 _______ It was revert because of following: "This is simply wrong. Something scrolled != the frame scrolled. Actually RenderLayer can be anything but the frame." _______ I reverted it locally and it compiles. (Not run 'run-webkit-tests' because I have other scrolling patches as well). _________ So I just wanted to raise and get input, whether we can remove it as well. Thanks! 1967079 1 simon.fraser 2023-07-17 11:53:38 -0700 We can't just remove this. It's a signal that's propagated out to the UI process in WebKit2 (thought I'm not sure what responds to it). 1967518 2 ahmad.saleem792 2023-07-20 15:23:13 -0700 Marking Invalid based on Simon's comment.