25925 2009-05-21 04:07:20 -0700 WebKit should show no-drop cursor on dropEffect = "none" 2009-05-21 05:21:02 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Mac OS X 10.5 NEW P2 Normal --- 25907 1 eric webkit-unassigned oldest_to_newest 122321 0 eric 2009-05-21 04:07:20 -0700 WebKit should show noDrag cursor on dropEffect = "none" See test case. 122322 1 30540 eric 2009-05-21 04:10:45 -0700 Created attachment 30540 test case (including image of cursor taken from WebCore/resources/noDropCursor.png) 122328 2 eric 2009-05-21 05:20:27 -0700 I believe this is caused by the fact that we create a new Clipboard on every drag event: DragOperation DragController::tryDHTMLDrag(DragData* dragData) RefPtr<Clipboard> clipboard = dragData->createClipboard(policy); We need to keep a Clipboard around for the entire drag, but to do that would require some review of how we handle Clipboard security as discussed in bug 25907. 122329 3 eric 2009-05-21 05:21:02 -0700 Rather, we need to at least keep around the m_dropEffect string which is currently stored on the Clipboard object. 30540 2009-05-21 04:10:45 -0700 2009-05-21 04:10:45 -0700 test case (including image of cursor taken from WebCore/resources/noDropCursor.png) protect.html text/html 4735 eric PGRpdj5XZWJLaXQgc2hvdWxkIHNob3cgbm9Ecm9wQ3Vyc29yIDxpbWcgc3JjPSJkYXRhOmltYWdl L3BuZywlODlQTkclMEQlMEElMUElMEElMDAlMDAlMDAlMERJSERSJTAwJTAwJTAwJTE5JTAwJTAw JTAwJTI0JTA4JTA2JTAwJTAwJTAwJTdDJTBEJTkxJTEwJTAwJTAwJTAwJTA0Z0FNQSUwMCUwMCVE OSUwM0IlRDZPJUExJTAwJTAwJTAwJTA5cEhZcyUwMCUwMCUwQiUxMyUwMCUwMCUwQiUxMyUwMSUw MCU5QSU5QyUxOCUwMCUwMCUwMCF0RVh0U29mdHdhcmUlMDBRdWlja1RpbWUlMjA1LjAuNiUyMChN YWNPUyklMDAlQkElOEFFJTFDJTAwJTAwJTAwJTA3dElNRSUwNyVEMiUwMyUwQyUxMiUwOSUwRSVC NyU4QzMlQkMlMDAlMDAlMDQlQTVJREFUeCU5QyVCNVdNTGNVJTE0fiU3RC12JUNBTGUlMTglMkMl QTUlQTIlQzElNDBMJTBDQXAlODJDJTk0JTA1JTkwJTQwZCFhJUUzJUM2JUNDaiU4QyU4QllpJUQ4 SmJiWCU5MCUxMDclMDQnYiU4QyUwOUFkYSUwOCUwOSUxMCUwOCVBNCU4MCUwQiUwNCUwMigtJTk1 QiVCNSUyMyVBNVMlOTElOTIpJTdGJTExJUVBJTQwaV8lRkQlMEUlM0R3JUU2JUI1JUI0JTg1JUM0 JUNFSU4lREVPJUVGJUZEJUJFJTdCJUNFJUY5JUVFJUI5JUFGJTFBJUU5JTk5JUM5cCUwRCUzQyVB QSVGMiU4QyUxQSUxMSVFOCVBMyVCMCU0MCUyMHAlMTclRjdZJUZDLiVBMyVBNiU4MyVFNyU5QyU5 QyU5QyUxME8lRDQlRTVyNSVFMSVGOSU4NUwlMTJRJThBaCVFNSUyNiUyMigtLSVBNSU4QiU5Mmkl MjIlMEQlODMlMTUlMTAlM0ElQUUlQ0YlODUlRTglMDIlQzklRjMlMjBKSiU5MmklQTIlOTQlMjQl OTklMjRKSyU5MiklQTJLSTJBdCUyNSUxMjUlOTElREIlRUR+XyU4QSVDOSU1RSVGMyVCRkglMDgl QjAlQUQlQUQlQ0R1dHQlQjQlQUIoSiVGOCUxQyU1RFElQTIlOTFIJTI0JTdDdnYlRTYlQzclOTgl RUJXJThERiU5NyVFQyUyNSUwOCVBNCVCOSVCOSVCOUclQjglOEQlMTglOEQlQzYlMjYlMjYlMTYl N0QlRUQlODklNUUlQUYlM0YlRTYlODUlODUlRDklMTUpTSVBRiVCQiVCMCUxMiUyMlglNUIlNUIl OTMlMEUlMEUlMEUlRjZyc3MlM0YhJTIyVSVCNDclRTAlQTYlRDMlRDMlRDMlOTdxJTdEJTE1JUZF JTBBJUZDJTI1JThFKm0lOUQlRDQlRTlSJUQwJTIwJUVEJTdCJTdCJTdCa3glQUUlODdXVVZWJUJF NyUzQSUzQSVGQS0lMEFuJURCJURGJURGJTBGJTIwVSFyJTJDJTIyJTgwJURBJUZDaiVCNVolQkYl QUUlQUIlQUIlN0IlMTdjJUNETCU5NiU5NSU4QUQlRjQuJTI1JTE4JTBDbiVFMyVGRTYlQkMlQTYl QUYlQUYlRUYlQ0IlQ0QlQ0QlQ0QlODclRDFLJUNDJUVCJUY1JUJBJTA3JTA2JTA2JURBMSVBNyUx OCVGRWIqJTIyJUFBJUNETSUxQWQ2JTlCJUNCcCU3RHNoaCVBOCUxNyVBQiUzRCVCQyU4QyU0MCUx OCU4RCUxRCUxRiUxRiVGRiUwRXNLOCVBRFolMDEubjQlN0MlOUYlODVIbiVGNCVGNCVGNCU3QyVE NCVEOCVEOCVGOCFqJTkyQyUzRiU5MiVBQSUxNiUxNyUxNyUwMyVDMyVDMyVDMyVFRSVDRSVDRSVD RSVDNSVDMSVDMSVDMSVERiU5MSVENmMlNjAlQ0IlRjklRjklRjklMDYlQURWJTJCXyU4MyVFNSVF NSVFNSU5NVRUVEglRjglRkQ3TCUzQiU5NSUxMiUwNCFzJTVEJUNDVCU4MyUzRmElODklMkIlOUQl OTglOTglRjAlRTAlRjclMkYlRTAlMUYlQzMlRUYlRjIlRjUlQjMlRjYlRjYlRjYlOUYlRDYlRDcl RDd3JUM1OCU5QSU1QlVVRSVGNSVDQ1VHJTIzJThDSCU1RSVDMyp6JUM0JTA0JUVDJTA5RU0lODRo JTFDJTE4QyUxQiVGMS1KKSVCQyU4RSVDOCUzQSUzQSUzQSVBQyVBMVAoJTJDJUM2JTExJTA2YTEl RTZTJTkzOSU4RiVCN1dWVlYlQzUlRTAlRjklRjklRjklQzclMjMlMjMlMjMlM0U1JTkxJUMzJUUx JUY4JTg1VCclQzUlRTRLUiVBRSU4NCVERiVCNyVEOWwlNUJiJTBDYSVCMHglMDhTJTE2JUJBJTE2 JTBBJUNCKSgoKCUxNCVDQyUxOCVFQ2tubiUxRSU4NEw3JUM0JUJCJUYyJUYyJUYyJUI3V1dXJTFG SDElQzklRDIlMUV6JTBDJTdGJUU0dCUzQSU5RiU4RWElOEMlMUMlQzYlRDQlQTg3JTBGJUU1JUNG JTgwYiUxQiVDNSU4QiVFNSVFNWUlREElMkZOJTg4JUUwJTlCJUU5JUU5JUU5JTg3JUUyJTdEWVkl RDklMUQlMTB1czQlODRxJUI4JUIwJUIwJUUwJTEyJUJGMyU4NkElRDRETUIlRDElQzQlQjUlOTkl RUMlRUNsaiUxRiVCNEIlN0JDQyVDMyU4MyUxNEQlOTQyJUFETiVBNyUwQkslRjElQTZjJUNDJTBC bSUyMCU4MiVERCUxRSUxNCUwRiVCNSVCNSVCNSVBNHl6JUY2UiVGNiU5MiUxMSVEOSVFRCVGNiVB RiglQTIlRUElRUElRUE3JUM0JTdCJUM2JTg4JTI0JTYwJTlGJTkzJUREJTgyJUQ3JTIzJUVDJTNG RCUwMSFNJTkybSUzRCVBRiU5NlJTJTAzJUZGdGpqJUNBJUFEJTE2JUMzJUVDJUVDJUFDJTEzJUY1 JUZCSyUzQyUxMyUwNiVDRiVCQiVBNSUwRUQlQTglRUJOd3clRjclOTAlMTglOEMlMUUlMTUlRUUl RUYlRUYlRkYlNUUlOEElQzklOTUlMEElNUQlMjQlQzVkJURCMjk5JTE5JUQ3biVENCUxMiUyNiUw QyVDMmIlQ0M4JTkyayVGMCVENyU4QiU4QiU4QiVFRmNVJTdGJThCJTA5JUU4SyVEQiVEMCUzRCVC NSUwQiU5MmolMDklMTM2JUMzJTNGRyUxQiVGMSUyNG5aJTlBSyUxOCU4NCVDNSU5OCVCMiglQjQl QzI5JTNDJUY0eCUzQy4lQjQlOEYlOUYhJUMzJTI2JUY0JUIxJUVCRUVFJTk2JUMyJUMyJUMyJTdC JTFCJTFCJTFCNSUzRSU5RiVDRiVCMSVCNCVCNCVCNCU4MiVENmMlQzAlOTElRjAlOEUlQzlkJUQy UyVDQiU5MWUlRjklQkMlQzAlM0IlM0IlM0JBJTlBSyUxOCU4NCVDNSU5OEpiJTVEJTBDJUJDJURB JTBGJUJBJUJBJUJBJUFDJTk4dCU5QyVCOCVEMlQlRTYlRjclRkIlOEZpJTBFJUNEZSUwQyU4M0gl OTUlQkElQjclODglQTMlOTclQTQlMThCKiVCNiVEMSVGMyVGNCVEMCVGQ00lOEIlQzViJTk0JUQy JTE4diVGQk5vbyVFRkxrayVFQiUwRnglNUMlQTclQTAlRTBPRCUxNCU4OSUwREwlQzMhJTg2JUUw JUZGJUNFJUNDJUNDbCVFMSVDMCVGMlJKUFglMTklRERWJTBCYi0lRjU0JUFDJTNDJTA4JUY5JUZB cSU4RSVEOFpaWn4lMUMlMUIlMUIlOUIlQzQlMUNKJTEzJTlEJUZGQUklRDUlODElOTMlN0RtJUM4 TE4lRTElOTIlMDQtJUQyJUIzYyU5NiUwRSUyNCUzRCU4RiVBM1YlRkUlMEYlN0MlMTclQkUlQzUl RTAlRkIlMUNBJTVDLVIlN0QlRDIlODglM0ZEJUQ0JTdCJUIyJUUxRiUyNiUyMCVCNSUwOCVCMVBa TyU5OCVFOCU4OCUyMiU4NyU5RiVGMSVFQSVFMyU4QSU3RCVEOXclOTMlMjAlRDMlQjIlQUIlQkYl QjUlQTIlMEMlMUFhJUJGJTAwflUlMTI1WSUzQUslMEEuJUVDJTNGJTAxMyU5NkQqJUNGU3klMDAl MDAlMDAlMDBJRU5EJUFFQiU2MCU4MiUwMCUwMSUwMCUwMCUwMCUwMiUwMDIlMDAyJTAwJTAwJTAw JTAwJTAwJTAwJTAwJTAwJTAwJTAwJTAwJTAwJTAwJTAwJTAwJTAwJTAwJTAwJTAwJTAwJTAwJTAw JTAwJTAwJTAwJTAwJTAwJTAwJTAwJTAwJTAwJTAwJTAwJTAwJTAwJTAwJTAwJTAwJTAwJTAwJTAw WCUwMCUwMCUwMCUwMCUwMCUwMCUwMCUwMCUwMCUwMCUwMCUwMCUwMCUwMCUwMCUwMCUwMCUwMCUw MCUwMCUwMCUwMCUwMCUwMCUwMCUwMCUwMCUwMCUwMCUwMCUwMCUwMCUwMCUwMCUwMCUwMCUwMDIl MDAyJTAwJTEwJTAwJTBBJTAwJTBGJTAwJTAwJTAwJTAwJTAwJTAwJTAwJTAwUiVBQiI+IHdoZW4g ZHJhZ2dpbmcgYSBmaWxlIG92ZXIgdGhpcyBwYWdlPC9kaXY+Cjx0YWJsZSBpZD0iZXZlbnRMb2ci IHN0eWxlPSJmb250OiBtb25vc3BhY2UgMTBweCI+PC90YWJsZT4KCjxzY3JpcHQ+CnZhciBsYXN0 RXZlbnRSb3c7CmZ1bmN0aW9uIGxvZyhzKSB7CiAgICAvLyBJbXBsZW1lbnQgcmVwZWF0aW5nIGV2 ZW50IGNvdW50cyB0byBtYWtlIHRoZSBsb2cgbW9yZSByZWFkYWJsZS4KICAgIGlmIChsYXN0RXZl bnRSb3cgJiYgbGFzdEV2ZW50Um93LmZpcnN0Q2hpbGQuaW5uZXJIVE1MID09IHMpIHsKICAgICAg ICB2YXIgbGFzdEV2ZW50Q291bnQgPSBwYXJzZUludChsYXN0RXZlbnRSb3cubGFzdENoaWxkLmlu bmVySFRNTCwgMTApOwogICAgICAgIGxhc3RFdmVudFJvdy5sYXN0Q2hpbGQuaW5uZXJIVE1MID0g bGFzdEV2ZW50Q291bnQgPyBsYXN0RXZlbnRDb3VudCArIDEgOiAxOwogICAgICAgIHJldHVybjsK ICAgIH0KICAgIHZhciBldmVudFJvdyA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInRyIik7CiAg ICBldmVudFJvdy5pbm5lckhUTUwgPSAiPHRkPjwvdGQ+PHRkPjwvdGQ+IjsKICAgIGV2ZW50Um93 LmZpcnN0Q2hpbGQuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUocykpOwogICAg ZXZlbnRMb2cuYXBwZW5kQ2hpbGQoZXZlbnRSb3cpOwogICAgbGFzdEV2ZW50Um93ID0gZXZlbnRS b3c7Cn0KCmZ1bmN0aW9uIGxvZ0V2ZW50KCkgewogICAgbG9nKGV2ZW50LnR5cGUpOwp9CgpmdW5j dGlvbiBkcmFnRW50ZXIoKSB7CiAgICBldmVudC5kYXRhVHJhbnNmZXIuZHJvcEVmZmVjdCA9ICJu b25lIjsKICAgIGxvZ0V2ZW50KCk7Cn0KZnVuY3Rpb24gZHJhZ092ZXIoKSB7CiAgICBsb2dFdmVu dCgpOwogICAgZXZlbnQucHJldmVudERlZmF1bHQoKTsKfQpmdW5jdGlvbiBkcm9wKCkgewogICAg bG9nRXZlbnQoKTsKICAgIGV2ZW50LnByZXZlbnREZWZhdWx0KCk7Cn0KCi8vIENhcHR1cmUgYWxs IGRyYWcgZXZlbnRzCndpbmRvdy5hZGRFdmVudExpc3RlbmVyKCJkcmFnZW50ZXIiLCBkcmFnRW50 ZXIsIHRydWUpOwp3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcigiZHJhZ292ZXIiLCBkcmFnT3Zlciwg dHJ1ZSk7CndpbmRvdy5hZGRFdmVudExpc3RlbmVyKCJkcm9wIiwgZHJvcCwgdHJ1ZSk7Cjwvc2Ny aXB0Pg==