<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>259246</bug_id>
          
          <creation_ts>2023-07-15 11:45:19 -0700</creation_ts>
          <short_desc>[contain-intrinsic-size] Use StyleBuilderConverter instead of StyleBuilderCustom</short_desc>
          <delta_ts>2023-07-28 09:48:14 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=259237</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Tim Nguyen (:ntim)">ntim</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>rbuis</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1966905</commentid>
    <comment_count>0</comment_count>
    <who name="Tim Nguyen (:ntim)">ntim</who>
    <bug_when>2023-07-15 11:45:19 -0700</bug_when>
    <thetext>Mistakes like bug 259237 would be avoided if we used StyleBuilderConverter.

We&apos;d need to store contain-intrinsic-size fields into a single struct instead of two separate RenderStyle items.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1967730</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2023-07-22 11:46:16 -0700</bug_when>
    <thetext>&lt;rdar://problem/112713755&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1968628</commentid>
    <comment_count>2</comment_count>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2023-07-28 09:48:14 -0700</bug_when>
    <thetext>Tim, do you think this is still worth doing? I can give it a go, though I don&apos;t know if it would have fixed the inherit problem (I am not too familiar with StyleBuilderConverter)?</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>