25904 2009-05-20 19:10:26 -0700 [Chromium] Mac Chromium HTML selects don't initialize their widths 2009-06-04 16:02:14 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 paul webkit-unassigned dglazkov oldest_to_newest 122236 0 paul 2009-05-20 19:10:26 -0700 Mac Chromium HTML selects don't set their widths properly at creation time, leading to occasional hit testing errors (making items unable to be selected). 122237 1 30519 paul 2009-05-20 19:22:06 -0700 Created attachment 30519 Fix for PopupListBox width initialization 122482 2 30519 eric 2009-05-21 18:05:16 -0700 Comment on attachment 30519 Fix for PopupListBox width initialization No way to test this? We can make hit testing tests from JavaScript quite easily... document.elementAtPoint() will hit test. 122587 3 30519 mjs 2009-05-22 00:36:50 -0700 Comment on attachment 30519 Fix for PopupListBox width initialization Please add a regression test and resubmit. 123488 4 30758 paul 2009-05-28 15:34:55 -0700 Created attachment 30758 Fix for the popup width initialization bug and a manual regression test. 123876 5 30758 eric 2009-06-01 13:51:43 -0700 Comment on attachment 30758 Fix for the popup width initialization bug and a manual regression test. I don't understand what your test is testing. Why does it need 26 options? Ideally the test should have the minimum amount of content to get the point across and no more. Why is document.elementAtPoint() insufficient for this test? I take it the <select> element draws at the right place, but the popup itself (a window over the top of Chromium) does not? In that case, I can see that this would be untestable, but you should explain that in your ChangeLog. 123878 6 30841 paul 2009-06-01 14:40:21 -0700 Created attachment 30841 Updated patch with more description of the problem being solved. Updated the patch as per discussion with Eric. 124395 7 30841 eric 2009-06-04 16:02:05 -0700 Comment on attachment 30841 Updated patch with more description of the problem being solved. Looks good. Thanks. Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog A WebCore/manual-tests/select-narrow-width.html M WebCore/platform/chromium/PopupMenuChromium.cpp Committed r44438 30519 2009-05-20 19:22:06 -0700 2009-05-28 15:34:55 -0700 Fix for PopupListBox width initialization mac_width2 text/plain 1371 paul SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0Mzk0OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDUtMjAgIFBhdWwgR29kYXZhcmkgIDxwYXVsQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJ bml0aWFsaXplIHRoZSB3aWR0aCBvZiBQb3B1cE1lbnVMaXN0Qm94IHByb3Blcmx5IGZvciBNYWMg Q2hyb21pdW0uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yNTkwNAorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0u Y3BwOgorICAgICAgICAoV2ViQ29yZTo6UG9wdXBMaXN0Qm94OjpQb3B1cExpc3RCb3gpOgorICAg ICAgICAoV2ViQ29yZTo6UG9wdXBDb250YWluZXI6OnNob3dFeHRlcm5hbCk6CisKIDIwMDktMDUt MjAgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBH YXZpbiBCYXJyYWNsb3VnaC4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBN ZW51Q2hyb21pdW0uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0v UG9wdXBNZW51Q2hyb21pdW0uY3BwCShyZXZpc2lvbiA0Mzk0NykKKysrIFdlYkNvcmUvcGxhdGZv cm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNTUs NiArMTU1LDcgQEAgcHJpdmF0ZToKICAgICAgICAgLCBtX3NlbGVjdGVkSW5kZXgoMCkKICAgICAg ICAgLCBtX3dpbGxBY2NlcHRPbkFiYW5kb24oZmFsc2UpCiAgICAgICAgICwgbV92aXNpYmxlUm93 cygwKQorICAgICAgICAsIG1fYmFzZVdpZHRoKDApCiAgICAgICAgICwgbV9wb3B1cENsaWVudChj bGllbnQpCiAgICAgICAgICwgbV9yZXBlYXRpbmdDaGFyKDApCiAgICAgICAgICwgbV9sYXN0Q2hh clRpbWUoMCkKQEAgLTM1MCw2ICszNTEsNyBAQCB2b2lkIFBvcHVwQ29udGFpbmVyOjpzaG93RXh0 ZXJuYWwoY29uc3QgCiAgICAgaWYgKCFsaXN0Qm94KCkpCiAgICAgICAgIHJldHVybjsKIAorICAg IGxpc3RCb3goKS0+c2V0QmFzZVdpZHRoKHJlY3Qud2lkdGgoKSk7CiAgICAgbGlzdEJveCgpLT51 cGRhdGVGcm9tRWxlbWVudCgpOwogCiAgICAgaWYgKGxpc3RCb3goKS0+bnVtSXRlbXMoKSA8IDEp IHsK 30758 2009-05-28 15:34:55 -0700 2009-06-01 14:40:21 -0700 Fix for the popup width initialization bug and a manual regression test. mac_width3 text/plain 2550 paul SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NDI1NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDUtMjggIFBhdWwgR29kYXZhcmkgIDxwYXVsQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJ bml0aWFsaXplIHRoZSB3aWR0aCBvZiBQb3B1cE1lbnVMaXN0Qm94IHByb3Blcmx5IGZvciBNYWMg Q2hyb21pdW0uCisgICAgICAgIEFkZGVkIGEgbWFudWFsIHRlc3QgdGhhdCB3b3JrcyBvbmx5IHdp dGggdGhpcyBwYXRjaCBhcHBsaWVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjU5MDQKKworICAgICAgICAqIG1hbnVhbC10ZXN0cy9zZWxlY3QtbmFy cm93LXdpZHRoLmh0bWw6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL1BvcHVw TWVudUNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBvcHVwTGlzdEJveDo6UG9wdXBM aXN0Qm94KToKKyAgICAgICAgKFdlYkNvcmU6OlBvcHVwQ29udGFpbmVyOjpzaG93RXh0ZXJuYWwp OgorCiAyMDA5LTA1LTI4ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0YXZvLm5vcm9uaGFA Y29sbGFib3JhLmNvLnVrPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFhhbiBMb3Blei4KSW5kZXg6 IFdlYkNvcmUvbWFudWFsLXRlc3RzL3NlbGVjdC1uYXJyb3ctd2lkdGguaHRtbAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL21hbnVhbC10ZXN0cy9zZWxlY3QtbmFycm93LXdpZHRoLmh0bWwJKHJldmlz aW9uIDApCisrKyBXZWJDb3JlL21hbnVhbC10ZXN0cy9zZWxlY3QtbmFycm93LXdpZHRoLmh0bWwJ KHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNDAgQEAKKzxodG1sPgorPGhlYWQ+CitTZWxlY3QgbmFy cm93IHdpZHRoIG1hbnVhbCB0ZXN0LgorPC9oZWFkPgorCis8Ym9keT4KK0Nob29zaW5nIGFuIGl0 ZW0gZnJvbSBhIG5hcnJvdyB3aWR0aCBzZWxlY3QgY29udHJvbCB3aWxsIHdvcms6Cis8YnI+CisK KzxzZWxlY3QgaWQ9InNlbGVjdElkIj4KKyAgPG9wdGlvbj5hPC9vcHRpb24+CisgIDxvcHRpb24+ Yjwvb3B0aW9uPgorICA8b3B0aW9uPmM8L29wdGlvbj4KKyAgPG9wdGlvbj5kPC9vcHRpb24+Cisg IDxvcHRpb24+ZTwvb3B0aW9uPgorICA8b3B0aW9uPmY8L29wdGlvbj4KKyAgPG9wdGlvbj5nPC9v cHRpb24+CisgIDxvcHRpb24+aDwvb3B0aW9uPgorICA8b3B0aW9uPmk8L29wdGlvbj4KKyAgPG9w dGlvbj5qPC9vcHRpb24+CisgIDxvcHRpb24+azwvb3B0aW9uPgorICA8b3B0aW9uPmw8L29wdGlv bj4KKyAgPG9wdGlvbj5tPC9vcHRpb24+CisgIDxvcHRpb24+bjwvb3B0aW9uPgorICA8b3B0aW9u Pm88L29wdGlvbj4KKyAgPG9wdGlvbj5wPC9vcHRpb24+CisgIDxvcHRpb24+cTwvb3B0aW9uPgor ICA8b3B0aW9uPnI8L29wdGlvbj4KKyAgPG9wdGlvbj5zPC9vcHRpb24+CisgIDxvcHRpb24+dDwv b3B0aW9uPgorICA8b3B0aW9uPnU8L29wdGlvbj4KKyAgPG9wdGlvbj52PC9vcHRpb24+CisgIDxv cHRpb24+dzwvb3B0aW9uPgorICA8b3B0aW9uPng8L29wdGlvbj4KKyAgPG9wdGlvbj55PC9vcHRp b24+CisgIDxvcHRpb24+ejwvb3B0aW9uPgorPC9zZWxlY3Q+CisKKzwvYm9keT4KKzwvaHRtbD4K SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0u Y3BwCShyZXZpc2lvbiA0NDI1MikKKysrIFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBN ZW51Q2hyb21pdW0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNTUsNiArMTU1LDcgQEAgcHJpdmF0 ZToKICAgICAgICAgLCBtX3NlbGVjdGVkSW5kZXgoMCkKICAgICAgICAgLCBtX3dpbGxBY2NlcHRP bkFiYW5kb24oZmFsc2UpCiAgICAgICAgICwgbV92aXNpYmxlUm93cygwKQorICAgICAgICAsIG1f YmFzZVdpZHRoKDApCiAgICAgICAgICwgbV9wb3B1cENsaWVudChjbGllbnQpCiAgICAgICAgICwg bV9yZXBlYXRpbmdDaGFyKDApCiAgICAgICAgICwgbV9sYXN0Q2hhclRpbWUoMCkKQEAgLTM1MCw2 ICszNTEsNyBAQCB2b2lkIFBvcHVwQ29udGFpbmVyOjpzaG93RXh0ZXJuYWwoY29uc3QgCiAgICAg aWYgKCFsaXN0Qm94KCkpCiAgICAgICAgIHJldHVybjsKIAorICAgIGxpc3RCb3goKS0+c2V0QmFz ZVdpZHRoKHJlY3Qud2lkdGgoKSk7CiAgICAgbGlzdEJveCgpLT51cGRhdGVGcm9tRWxlbWVudCgp OwogCiAgICAgaWYgKGxpc3RCb3goKS0+bnVtSXRlbXMoKSA8IDEpIHsK 30841 2009-06-01 14:40:21 -0700 2009-06-04 16:02:05 -0700 Updated patch with more description of the problem being solved. mac_width4 text/plain 3265 paul SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NDMzMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjMgQEAKKzIwMDktMDYtMDEgIFBhdWwgR29kYXZhcmkgIDxwYXVsQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJ bml0aWFsaXplIHRoZSB3aWR0aCBvZiBQb3B1cE1lbnVMaXN0Qm94IHByb3Blcmx5IGZvciBNYWMg Q2hyb21pdW0uCisKKyAgICAgICAgQWRkZWQgYSB0ZXN0IHRoYXQgd29ya3Mgb25seSB3aXRoIHRo aXMgcGF0Y2ggYXBwbGllZC4gVGhlIHRlc3QgaXMKKyAgICAgICAgYSBtYW51YWwgb25lLCBzaW5j ZSB0aGUgaGl0IHRlc3RpbmcgaW5mcmFzdHJ1Y3R1cmUgaW4gdGhlIGxheW91dAorICAgICAgICB0 ZXN0cyBzZW5kcyBrZXlib2FyZCBhbmQgbW91c2UgZXZlbnRzIHRvIHRoZSBtYWluIHdpbmRvdyBh bmQgbm90CisgICAgICAgIHRoZSBjb2NvYSBjb250cm9sIHRoYXQgaW1wbGVtZW50cyB0aGUgcG9w dXAgdXAsIHdoaWNoIG1lYW5zIHdlIGNhbid0CisgICAgICAgIHNlbGVjdCBpdGVtcyBmcm9tIHRo ZSBwb3B1cCB1cC4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjU5MDQKKworCisgICAgICAgICogbWFudWFsLXRlc3RzL3NlbGVjdC1uYXJyb3ctd2lk dGguaHRtbDogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hy b21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UG9wdXBMaXN0Qm94OjpQb3B1cExpc3RCb3gp OgorICAgICAgICAoV2ViQ29yZTo6UG9wdXBDb250YWluZXI6OnNob3dFeHRlcm5hbCk6CisKIDIw MDktMDYtMDEgIERtaXRyeSBUaXRvdiAgPGRpbWljaEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg Rml4IHRoZSBwcmV2aW91cyBjaGVja2luICh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0 LzQ0MzI3KS4KSW5kZXg6IFdlYkNvcmUvbWFudWFsLXRlc3RzL3NlbGVjdC1uYXJyb3ctd2lkdGgu aHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL21hbnVhbC10ZXN0cy9zZWxlY3QtbmFycm93LXdp ZHRoLmh0bWwJKHJldmlzaW9uIDApCisrKyBXZWJDb3JlL21hbnVhbC10ZXN0cy9zZWxlY3QtbmFy cm93LXdpZHRoLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNDggQEAKKzxodG1sPgorPGhl YWQ+CitTZWxlY3QgbmFycm93IHdpZHRoIG1hbnVhbCB0ZXN0LgorPC9oZWFkPgorCis8Ym9keT4K K1NlZSBidWc6PGEgaHJlZj0iaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTI1OTA0Ij4yNTkwNDwvYT4uCis8cD4KK1RoaXMgdGVzdCBlbnN1cmVzIHRoYXQgaXRlbXMgaW4g YSBzZWxlY3QgY29udHJvbCBjYW4gYmUgc2VsZWN0ZWQuIFRoZXJlCit3YXMgYSBidWcgaW4gTWFj IENocm9taXVtIHdoZXJlIHNlbGVjdCBjb250cm9scyBkaWQgbm90IGluaXRpYWxpemUgdGhlaXIK K3dpZHRocyBwcm9wZXJseSwgYW5kIHdoaWxlIGEgY2xpY2sgb24gdGhlIGNvbnRyb2wgd291bGQg ZGlzcGxheSB0aGUgcG9wdXAsCitzdWJzZXF1ZW50IGNsaWNrcyBvbiBtZW51IGl0ZW1zIHdlcmUg ZGlzcmVnYXJkZWQuCis8cD4KK1RoZSBidWcgd2FzIG1vc3QgZWFzaWx5IHJlcHJvZHVjZWQgd2l0 aCBzZWxlY3QgY29udHJvbHMgY29udGFpbmluZyBtYW55CisobW9yZSB0aGFuIDIwKSBpdGVtcyB0 aGF0IGhhZCBuYXJyb3cgd2lkdGhzLgorPGJyPgorCis8c2VsZWN0IGlkPSJzZWxlY3RJZCI+Cisg IDxvcHRpb24+YTwvb3B0aW9uPgorICA8b3B0aW9uPmI8L29wdGlvbj4KKyAgPG9wdGlvbj5jPC9v cHRpb24+CisgIDxvcHRpb24+ZDwvb3B0aW9uPgorICA8b3B0aW9uPmU8L29wdGlvbj4KKyAgPG9w dGlvbj5mPC9vcHRpb24+CisgIDxvcHRpb24+Zzwvb3B0aW9uPgorICA8b3B0aW9uPmg8L29wdGlv bj4KKyAgPG9wdGlvbj5pPC9vcHRpb24+CisgIDxvcHRpb24+ajwvb3B0aW9uPgorICA8b3B0aW9u Pms8L29wdGlvbj4KKyAgPG9wdGlvbj5sPC9vcHRpb24+CisgIDxvcHRpb24+bTwvb3B0aW9uPgor ICA8b3B0aW9uPm48L29wdGlvbj4KKyAgPG9wdGlvbj5vPC9vcHRpb24+CisgIDxvcHRpb24+cDwv b3B0aW9uPgorICA8b3B0aW9uPnE8L29wdGlvbj4KKyAgPG9wdGlvbj5yPC9vcHRpb24+CisgIDxv cHRpb24+czwvb3B0aW9uPgorICA8b3B0aW9uPnQ8L29wdGlvbj4KKyAgPG9wdGlvbj51PC9vcHRp b24+CisgIDxvcHRpb24+djwvb3B0aW9uPgorICA8b3B0aW9uPnc8L29wdGlvbj4KKyAgPG9wdGlv bj54PC9vcHRpb24+CisgIDxvcHRpb24+eTwvb3B0aW9uPgorICA8b3B0aW9uPno8L29wdGlvbj4K Kzwvc2VsZWN0PgorCis8L2JvZHk+Cis8L2h0bWw+CkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2No cm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRm b3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcAkocmV2aXNpb24gNDQzMzEpCisrKyBX ZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTU1LDYgKzE1NSw3IEBAIHByaXZhdGU6CiAgICAgICAgICwgbV9zZWxlY3RlZElu ZGV4KDApCiAgICAgICAgICwgbV93aWxsQWNjZXB0T25BYmFuZG9uKGZhbHNlKQogICAgICAgICAs IG1fdmlzaWJsZVJvd3MoMCkKKyAgICAgICAgLCBtX2Jhc2VXaWR0aCgwKQogICAgICAgICAsIG1f cG9wdXBDbGllbnQoY2xpZW50KQogICAgICAgICAsIG1fcmVwZWF0aW5nQ2hhcigwKQogICAgICAg ICAsIG1fbGFzdENoYXJUaW1lKDApCkBAIC0zNTAsNiArMzUxLDcgQEAgdm9pZCBQb3B1cENvbnRh aW5lcjo6c2hvd0V4dGVybmFsKGNvbnN0IAogICAgIGlmICghbGlzdEJveCgpKQogICAgICAgICBy ZXR1cm47CiAKKyAgICBsaXN0Qm94KCktPnNldEJhc2VXaWR0aChyZWN0LndpZHRoKCkpOwogICAg IGxpc3RCb3goKS0+dXBkYXRlRnJvbUVsZW1lbnQoKTsKIAogICAgIGlmIChsaXN0Qm94KCktPm51 bUl0ZW1zKCkgPCAxKSB7Cg==