<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>259038</bug_id>
          
          <creation_ts>2023-07-09 16:27:29 -0700</creation_ts>
          <short_desc>[CSS Math Functions] Fix failures in css/css-values/minmax-percentage-serialize.html</short_desc>
          <delta_ts>2024-09-18 23:09:01 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>278244</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Tim Nguyen (:ntim)">ntim</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1965856</commentid>
    <comment_count>0</comment_count>
    <who name="Tim Nguyen (:ntim)">ntim</who>
    <bug_when>2023-07-09 16:27:29 -0700</bug_when>
    <thetext>`min(1%, 2%, 3%)` should stay `min(1%, 2%, 3%)` instead of collapsing to `calc(1%)`, given we can&apos;t conclude whether 1% is positive or negative.

Same for `max(1%, 2%, 3%)`.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1965857</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2023-07-09 16:27:38 -0700</bug_when>
    <thetext>&lt;rdar://problem/111986644&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1965858</commentid>
    <comment_count>2</comment_count>
    <who name="Tim Nguyen (:ntim)">ntim</who>
    <bug_when>2023-07-09 16:30:26 -0700</bug_when>
    <thetext>The only exception to this is if there&apos;s only one argument (see bug 259037)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1965862</commentid>
    <comment_count>3</comment_count>
    <who name="Tim Nguyen (:ntim)">ntim</who>
    <bug_when>2023-07-09 18:29:22 -0700</bug_when>
    <thetext>So arguably, WebKit&apos;s behavior is more correct here, since it does the collapsing only for properties that have a non-negative range.

The test should perhaps be adjusted to test for both types of properties.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1965863</commentid>
    <comment_count>4</comment_count>
    <who name="Tim Nguyen (:ntim)">ntim</who>
    <bug_when>2023-07-09 18:36:41 -0700</bug_when>
    <thetext>It does look like the test uses text-indent, which does take a negative range as well, so WebKit isn&apos;t working as intended here.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1965867</commentid>
    <comment_count>5</comment_count>
    <who name="Tim Nguyen (:ntim)">ntim</who>
    <bug_when>2023-07-09 19:50:40 -0700</bug_when>
    <thetext>Hmm, this is more about whether a percentage can resolve to a negative value. `text-indent` / `margin-left` percentages are relative to the size of the containing block...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2061359</commentid>
    <comment_count>6</comment_count>
    <who name="Tim Nguyen (:ntim)">ntim</who>
    <bug_when>2024-09-18 23:06:31 -0700</bug_when>
    <thetext>The test now fully passes. Not sure what exactly fixed it though</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2061362</commentid>
    <comment_count>7</comment_count>
    <who name="Tim Nguyen (:ntim)">ntim</who>
    <bug_when>2024-09-18 23:09:01 -0700</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 278244 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>