259028 2023-07-09 01:36:57 -0700 [user-activation] Fix html/user-activation/activation-trigger-pointerevent.html WPT 2024-09-12 21:48:24 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://github.com/web-platform-tests/wpt/pull/42118 https://bugs.webkit.org/show_bug.cgi?id=263887 https://wpt.fyi/results/html/user-activation/activation-trigger-pointerevent.html%3Fmouse?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&view=interop&q=label%3Ainterop-2023-events InRadar P2 Normal --- 1 ntim a_protyasha a_protyasha webkit-bug-importer oldest_to_newest 1965819 0 ntim 2023-07-09 01:36:57 -0700 https://searchfox.org/wubkat/rev/2517a540e6f5a2037c6843102f3a9cb753f2f9f0/Source/WebCore/dom/UserGestureIndicator.cpp#133-138 The function call (`window->notifyActivated(currentToken()->startTime());`) should happen only for specific events: An activation triggering input event is any event whose isTrusted attribute is true and whose type is one of: "keydown", provided the key is neither the Esc key nor a shortcut key reserved by the user agent. "mousedown". "pointerdown", provided the event's pointerType is "mouse". "pointerup", provided the event's pointerType is not "mouse". "touchend". Here's where we currently trigger it (see EventHandler.cpp notably): https://searchfox.org/wubkat/search?q=symbol:_ZN7WebCore20UserGestureIndicatorC1ESt8optionalINS_26ProcessingUserGestureStateEEPNS_8DocumentENS_15UserGestureTypeENS0_23ProcessInteractionStyleES1_IN3WTF4UUIDEE&redirect=false We don't seem to currently trigger it from pointer events. 1965820 1 webkit-bug-importer 2023-07-09 01:37:06 -0700 <rdar://problem/111970701> 1965821 2 ntim 2023-07-09 01:37:29 -0700 The spec for this is at: https://html.spec.whatwg.org/multipage/interaction.html#user-activation-processing-model 1965822 3 ntim 2023-07-09 01:38:37 -0700 WPT: https://wpt.fyi/results/html/user-activation/activation-trigger-pointerevent.html%3Fmouse?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&view=interop&q=label%3Ainterop-2023-events 1979288 4 a_protyasha 2023-09-22 00:09:16 -0700 Pull request: https://github.com/WebKit/WebKit/pull/18067 1979387 5 ews-feeder 2023-09-22 10:36:06 -0700 Committed 268320@main (df336e8effd7): <https://commits.webkit.org/268320@main> Reviewed commits have been landed. Closing PR #18067 and removing active labels. 1996018 6 ntim 2023-11-30 14:53:30 -0800 This was reverted 1996020 7 a_protyasha 2023-11-30 14:54:23 -0800 Thanks for flipping the bits, Tim. I'll address re-landing soon! 1998915 8 a_protyasha 2023-12-12 02:49:09 -0800 Pull request: https://github.com/WebKit/WebKit/pull/21668 1998916 9 a_protyasha 2023-12-12 02:55:38 -0800 The original fix to address this bug was reverted because it introduced the regression in bug 263887. The PR posted just now attempts to do things "the right way" by imbibing certain web automation script to execute with user activation and not have a blanket "make all web automation script blessed with user activation" policy. 2058676 10 ews-feeder 2024-09-09 11:26:45 -0700 Committed 283353@main (5d09b59ae940): <https://commits.webkit.org/283353@main> Reviewed commits have been landed. Closing PR #21668 and removing active labels. 2059880 11 ews-feeder 2024-09-12 21:48:24 -0700 Committed 283286.32@safari-7620-branch (5c4d89309ff0): <https://commits.webkit.org/283286.32@safari-7620-branch> Reviewed commits have been landed. Closing PR #1735 and removing active labels.